* [PATCH] serial: 8250: omap: Use serial8250_em485_supported
@ 2022-09-16 11:09 Matthias Schiffer
2022-09-16 11:16 ` Ilpo Järvinen
0 siblings, 1 reply; 2+ messages in thread
From: Matthias Schiffer @ 2022-09-16 11:09 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Jiri Slaby, Lukas Wunner, Thierry Reding, Ilpo Järvinen,
linux-serial, linux-kernel, Matthias Schiffer
8250_omap uses em485, fill in rs485_supported accordingly. This makes
RS485 work with 8250_omap again, which was broken with the introduction
of the RS485 config sanitization.
Fixes: be2e2cb1d2819 ("serial: Sanitize rs485_struct")
Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
---
drivers/tty/serial/8250/8250_omap.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/tty/serial/8250/8250_omap.c b/drivers/tty/serial/8250/8250_omap.c
index ff51ff91b9237..38ee3e42251af 100644
--- a/drivers/tty/serial/8250/8250_omap.c
+++ b/drivers/tty/serial/8250/8250_omap.c
@@ -1337,6 +1337,7 @@ static int omap8250_probe(struct platform_device *pdev)
up.port.throttle = omap_8250_throttle;
up.port.unthrottle = omap_8250_unthrottle;
up.port.rs485_config = serial8250_em485_config;
+ up.port.rs485_supported = serial8250_em485_supported;
up.rs485_start_tx = serial8250_em485_start_tx;
up.rs485_stop_tx = serial8250_em485_stop_tx;
up.port.has_sysrq = IS_ENABLED(CONFIG_SERIAL_8250_CONSOLE);
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] serial: 8250: omap: Use serial8250_em485_supported
2022-09-16 11:09 [PATCH] serial: 8250: omap: Use serial8250_em485_supported Matthias Schiffer
@ 2022-09-16 11:16 ` Ilpo Järvinen
0 siblings, 0 replies; 2+ messages in thread
From: Ilpo Järvinen @ 2022-09-16 11:16 UTC (permalink / raw)
To: Matthias Schiffer
Cc: Greg Kroah-Hartman, Jiri Slaby, Lukas Wunner, Thierry Reding,
linux-serial, LKML
[-- Attachment #1: Type: text/plain, Size: 1249 bytes --]
On Fri, 16 Sep 2022, Matthias Schiffer wrote:
> 8250_omap uses em485, fill in rs485_supported accordingly. This makes
> RS485 work with 8250_omap again, which was broken with the introduction
> of the RS485 config sanitization.
>
> Fixes: be2e2cb1d2819 ("serial: Sanitize rs485_struct")
> Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
> ---
Yes, good catch. I really don't know how I managed to miss it.
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
--
i.
> drivers/tty/serial/8250/8250_omap.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/tty/serial/8250/8250_omap.c b/drivers/tty/serial/8250/8250_omap.c
> index ff51ff91b9237..38ee3e42251af 100644
> --- a/drivers/tty/serial/8250/8250_omap.c
> +++ b/drivers/tty/serial/8250/8250_omap.c
> @@ -1337,6 +1337,7 @@ static int omap8250_probe(struct platform_device *pdev)
> up.port.throttle = omap_8250_throttle;
> up.port.unthrottle = omap_8250_unthrottle;
> up.port.rs485_config = serial8250_em485_config;
> + up.port.rs485_supported = serial8250_em485_supported;
> up.rs485_start_tx = serial8250_em485_start_tx;
> up.rs485_stop_tx = serial8250_em485_stop_tx;
> up.port.has_sysrq = IS_ENABLED(CONFIG_SERIAL_8250_CONSOLE);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-16 11:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-16 11:09 [PATCH] serial: 8250: omap: Use serial8250_em485_supported Matthias Schiffer
2022-09-16 11:16 ` Ilpo Järvinen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.