From: Tom Zanussi <zanussi@us.ibm.com>
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Karim Yaghmour <karim@opersys.com>,
linux-kernel@vger.kernel.org
Subject: Re: kernel/relay.c: a strange usage of delayed_work
Date: Fri, 04 May 2007 00:42:30 -0500 [thread overview]
Message-ID: <1178257351.4623.16.camel@ubuntu> (raw)
In-Reply-To: <20070503213835.GA243@tv-sign.ru>
On Fri, 2007-05-04 at 01:38 +0400, Oleg Nesterov wrote:
> relay_switch_subbuf() does schedule_delayed_work(&buf->wake_readers, 1),
> wakeup_readers() only does wake_up_interruptible() and nothing more.
>
> Why can't we use a plain timer for this?
>
> In any case, this "wake_up ->read_wait after a minimal possible delay"
> looks somewhat strange to me, could you explain? just curious.
>
The reason it's done that way is that if the event that causes the
relay_switch_subbuf() happens to be an event logged from schedule(), and
we directly call wake_up_interruptible() at that point, we lock up the
machine because it ends up back in schedule(). Deferring it avoids the
problem.
I don't see any problem with using a plain timer instead - I'll work up
a patch to make that change.
Tom
next prev parent reply other threads:[~2007-05-04 5:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-25 23:10 2.6.21-rc7-mm1: BUG_ON in kthread_bind during _cpu_down Rafael J. Wysocki
2007-04-25 23:54 ` Andrew Morton
2007-04-26 10:09 ` Gautham R Shenoy
2007-04-26 10:15 ` Oleg Nesterov
2007-04-26 12:58 ` Gautham R Shenoy
2007-04-28 1:42 ` Andrew Morton
2007-05-01 18:48 ` [PATCH] add-suspend-related-notifications-for-cpu-hotplug-cleanup Oleg Nesterov
2007-05-01 22:56 ` libata-core.c: unsafe cancel_delayed_work() usage? Oleg Nesterov
2007-05-01 23:35 ` Jeff Garzik
2007-05-01 23:48 ` Oleg Nesterov
2007-05-03 21:38 ` kernel/relay.c: a strange usage of delayed_work Oleg Nesterov
2007-05-04 5:42 ` Tom Zanussi [this message]
2007-04-26 10:20 ` 2.6.21-rc7-mm1: BUG_ON in kthread_bind during _cpu_down Eric W. Biederman
2007-04-26 20:20 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1178257351.4623.16.camel@ubuntu \
--to=zanussi@us.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=karim@opersys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@tv-sign.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.