From: Oleg Nesterov <oleg@tv-sign.ru>
To: Andrew Morton <akpm@linux-foundation.org>, Alan Cox <alan@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: libata-core.c: unsafe cancel_delayed_work() usage?
Date: Wed, 2 May 2007 02:56:54 +0400 [thread overview]
Message-ID: <20070501225654.GA190@tv-sign.ru> (raw)
In-Reply-To: <20070427184258.62794053.akpm@linux-foundation.org>
On 04/27, Andrew Morton wrote:
>
> It'd be good if people could take some time to sit down and re-review the
> code which we presently have. I plan on sending it all off for 2.6.22 and
> there might be some glitches but it seems to have a good track record so
> far.
Alan, the usage of cancel_delayed_work() in drivers/ata/libata-core.c looks
suspicious to me, both ->hotplug_task and ->port_task can re-arm themselves,
so cancel_delayed_work + flush_workqueue (or cancel_work_sync) is not enough.
Could you confirm/nack my understanding?
Oleg.
next prev parent reply other threads:[~2007-05-01 22:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-25 23:10 2.6.21-rc7-mm1: BUG_ON in kthread_bind during _cpu_down Rafael J. Wysocki
2007-04-25 23:54 ` Andrew Morton
2007-04-26 10:09 ` Gautham R Shenoy
2007-04-26 10:15 ` Oleg Nesterov
2007-04-26 12:58 ` Gautham R Shenoy
2007-04-28 1:42 ` Andrew Morton
2007-05-01 18:48 ` [PATCH] add-suspend-related-notifications-for-cpu-hotplug-cleanup Oleg Nesterov
2007-05-01 22:56 ` Oleg Nesterov [this message]
2007-05-01 23:35 ` libata-core.c: unsafe cancel_delayed_work() usage? Jeff Garzik
2007-05-01 23:48 ` Oleg Nesterov
2007-05-03 21:38 ` kernel/relay.c: a strange usage of delayed_work Oleg Nesterov
2007-05-04 5:42 ` Tom Zanussi
2007-04-26 10:20 ` 2.6.21-rc7-mm1: BUG_ON in kthread_bind during _cpu_down Eric W. Biederman
2007-04-26 20:20 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070501225654.GA190@tv-sign.ru \
--to=oleg@tv-sign.ru \
--cc=akpm@linux-foundation.org \
--cc=alan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.