Re: [PATCH] SH7760 ASoC support

[Liam Girdwood <lg@opensource.wolfsonmicro.com>]

On Thu, 2007-05-10 at 15:07 +0200, Manuel Lauss wrote:
> On Thu, May 10, 2007 at 09:58:17PM +0900, Paul Mundt wrote:
> > On Thu, May 10, 2007 at 02:08:33PM +0200, Manuel Lauss wrote:
> > > +##
> > > +## Audio unit modules
> > > +##
> > > +
> > > +config SND_SOC_SH4_HAC
> > > +	select AC97_BUS
> > > +	select SND_SOC_AC97_BUS
> > > +	select SND_AC97_CODEC
> > > +	tristate
> > > +
> > > +config SND_SOC_SH4_SSI
> > > +	tristate
> > > +
> > This might seem like a silly question, but how are these two supposed to
> > be enabled? At the very least you should have some dependencies on the
> > CPU subtypes that support these blocks.
> > 
> > > +
> > > +
> > > +##
> > > +## Boards
> > > +##
> > > +
> > Or are you expecting that the board-specific code will simply select
> > these?
> 
> That was the idea; the other ASoC boards do similar things.

Fwiw, the board or machine driver (when selected) currently selects it's
audio interface driver and DMA driver. The board/machine driver does
however depend on the selected MACH_MACHINE (e.g. MACH_POODLE for Sharp
Poodle) so it only exposes a single y,m,n Kconfig selection for audio as
it's completely platform specific.

The ASoC git tree dev branch does the opposite, as everything can be
selected for quicker build/debug.

Liam