From: Paul Mundt <lethal@linux-sh.org>
To: Manuel Lauss <mano@roarinelk.homelinux.net>
Cc: alsa-devel@alsa-project.org, linuxsh-dev@lists.sf.net
Subject: Re: [PATCH] SH7760 ASoC support
Date: Thu, 10 May 2007 21:58:17 +0900 [thread overview]
Message-ID: <20070510125817.GC18534@linux-sh.org> (raw)
In-Reply-To: <20070510120833.GA9539@roarinelk.homelinux.net>
On Thu, May 10, 2007 at 02:08:33PM +0200, Manuel Lauss wrote:
> +##
> +## Audio unit modules
> +##
> +
> +config SND_SOC_SH4_HAC
> + select AC97_BUS
> + select SND_SOC_AC97_BUS
> + select SND_AC97_CODEC
> + tristate
> +
> +config SND_SOC_SH4_SSI
> + tristate
> +
This might seem like a silly question, but how are these two supposed to
be enabled? At the very least you should have some dependencies on the
CPU subtypes that support these blocks.
> +
> +
> +##
> +## Boards
> +##
> +
Or are you expecting that the board-specific code will simply select
these?
Are you planning on submitting a stub that enables these? Or is this just
to be a placeholder until some board wants them?
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
next prev parent reply other threads:[~2007-05-10 12:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-10 12:08 [PATCH] SH7760 ASoC support Manuel Lauss
2007-05-10 12:58 ` Paul Mundt [this message]
2007-05-10 13:07 ` Manuel Lauss
2007-05-10 13:31 ` Liam Girdwood
-- strict thread matches above, loose matches on Subject: below --
2007-05-10 15:42 Manuel Lauss
2007-05-11 12:19 ` Liam Girdwood
2007-05-14 9:21 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070510125817.GC18534@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=alsa-devel@alsa-project.org \
--cc=linuxsh-dev@lists.sf.net \
--cc=mano@roarinelk.homelinux.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.