All of lore.kernel.org
 help / color / mirror / Atom feed
From: jamal <hadi@cyberus.ca>
To: Patrick McHardy <kaber@trash.net>
Cc: David Miller <davem@davemloft.net>,
	"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@intel.com>,
	Thomas Graf <tgraf@suug.ch>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	netdev@vger.kernel.org
Subject: Re: [LAST CALL] [PATCH] [NET_SCHED]make qdisc_restart more readable
Date: Mon, 14 May 2007 08:41:38 -0400	[thread overview]
Message-ID: <1179146498.15622.66.camel@localhost> (raw)
In-Reply-To: <46483C8C.5040403@trash.net>

On Mon, 2007-14-05 at 12:40 +0200, Patrick McHardy wrote:

> Two final suggestions, sorry for not mentioning this earlier.

np

> > +			printk(KERN_DEBUG
> > +			       "Dead loop on netdevice %s, fix it urgently!\n",
> > +			       dev->name);
> 
> > +	if (unlikely (ret != NETDEV_TX_BUSY && net_ratelimit()))
> > +		printk(KERN_DEBUG " BUG %s code %d qlen %d\n",dev->name, ret, q->q.qlen);
> 
> 
> For both of these KERN_WARNING or above 

I will make them KERN_WARNING ..

> seems to make sense so
> the messages don't end up in some debug log. Please also fix
> whitespace 

What whitespace issue?

> and line length for the second printk if you're
> going to change this :)

I will fix the length of the second one.

Thanks Patrick.

cheers,
jamal


  reply	other threads:[~2007-05-14 12:41 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-11  0:13 [RFC] make qdisc_restart more readable jamal
2007-05-11 15:56 ` Waskiewicz Jr, Peter P
2007-05-11 18:04   ` jamal
2007-05-11 18:13     ` Waskiewicz Jr, Peter P
2007-05-11 18:35       ` jamal
2007-05-11 18:46         ` Waskiewicz Jr, Peter P
2007-05-11 19:29           ` take 2 WAS (RE: " jamal
2007-05-11 22:01             ` Waskiewicz Jr, Peter P
2007-05-11 22:43               ` jamal
2007-05-12  9:46             ` Thomas Graf
2007-05-12 11:58               ` jamal
2007-05-12 12:18             ` take 3 " jamal
2007-05-12 17:02               ` Patrick McHardy
2007-05-12 19:56                 ` jamal
2007-05-13 14:28                   ` [LAST CALL] [PATCH] [NET_SCHED]make " jamal
2007-05-14 10:40                     ` Patrick McHardy
2007-05-14 12:41                       ` jamal [this message]
2007-05-14 12:43                         ` Patrick McHardy
2007-05-14 13:30                     ` jamal
2007-05-14 20:09                       ` Waskiewicz Jr, Peter P
2007-05-16 22:55                       ` jamal
2007-05-16 23:00                         ` David Miller
2007-05-16 23:15                         ` Sridhar Samudrala
2007-05-17  2:12                           ` jamal
2007-05-11 17:01 ` [RFC] make " Thomas Graf
2007-05-11 18:11   ` jamal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1179146498.15622.66.camel@localhost \
    --to=hadi@cyberus.ca \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    --cc=peter.p.waskiewicz.jr@intel.com \
    --cc=tgraf@suug.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.