From: Ben Collins <ben.collins@ubuntu.com>
To: Roland Dreier <rdreier@cisco.com>
Cc: linux-kernel@vger.kernel.org, Linus Torvalds <torvalds@osdl.org>,
Ganesh Varadarajan <ganesh@veritas.com>,
linux-usb-devel@lists.sourceforge.net
Subject: Re: [PATCH] Remove duplicate ID in ipaq driver
Date: Wed, 16 May 2007 17:36:48 -0400 [thread overview]
Message-ID: <1179351408.6510.24.camel@cunning> (raw)
In-Reply-To: <ada1whgmqlx.fsf@cisco.com>
On Wed, 2007-05-16 at 13:59 -0700, Roland Dreier wrote:
> > /* The first entry is a placeholder for the insmod-specified device */
> > - { USB_DEVICE(0x049F, 0x0003) },
>
> Is it obvious why this patch is correct? Especially given the
> comment just before the line you delete, and the code
>
> if (vendor) {
> ipaq_id_table[0].idVendor = vendor;
> ipaq_id_table[0].idProduct = product;
> }
>
> in ipaq_init()?
My mistake, quick on the patching going through this dupe list.
Might I add that this is terrible use of the device table, though.
Clutters userspace, and adds processing to module-init-tools programs.
--
Ubuntu : http://www.ubuntu.com/
Linux1394: http://wiki.linux1394.org/
next prev parent reply other threads:[~2007-05-16 21:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-16 20:54 [PATCH] Remove duplicate ID in ipaq driver Ben Collins
2007-05-16 20:59 ` Roland Dreier
2007-05-16 21:36 ` Ben Collins [this message]
2007-05-17 12:43 ` [linux-usb-devel] " Greg KH
2007-05-17 13:02 ` Ben Collins
2007-05-17 13:32 ` Valdis.Kletnieks
2007-05-17 13:32 ` Greg KH
2007-05-16 21:04 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1179351408.6510.24.camel@cunning \
--to=ben.collins@ubuntu.com \
--cc=ganesh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=rdreier@cisco.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.