Re: [PATCH] Remove duplicate ID in ipaq driver

[Jiri Slaby <jirislaby@gmail.com>]

Ben Collins napsal(a):
> Cc: Ganesh Varadarajan <ganesh@veritas.com>
> Cc: linux-usb-devel@lists.sourceforge.net
> Signed-off-by: Ben Collins <bcollins@ubuntu.com>
> 
> diff --git a/drivers/usb/serial/ipaq.c b/drivers/usb/serial/ipaq.c
> index 4df0ec7..7c85be4 100644
> --- a/drivers/usb/serial/ipaq.c
> +++ b/drivers/usb/serial/ipaq.c
> @@ -92,7 +92,6 @@ static void ipaq_destroy_lists(struct usb_serial_port *port);
>  
>  static struct usb_device_id ipaq_id_table [] = {
>  	/* The first entry is a placeholder for the insmod-specified device */

I wonder if the people ever read the comments? ^^^^^^^^^
It's used for parameter from command line when modprobing. See ipaq_init.

> -	{ USB_DEVICE(0x049F, 0x0003) },
>  	{ USB_DEVICE(0x0104, 0x00BE) }, /* Socket USB Sync */
>  	{ USB_DEVICE(0x03F0, 0x1016) }, /* HP USB Sync */
>  	{ USB_DEVICE(0x03F0, 0x1116) }, /* HP USB Sync 1611 */
> 

regards,
-- 
http://www.fi.muni.cz/~xslaby/            Jiri Slaby
faculty of informatics, masaryk university, brno, cz
e-mail: jirislaby gmail com, gpg pubkey fingerprint:
 B674 9967 0407 CE62 ACC8  22A0 32CC 55C3 39D4 7A7E