All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Alan Cox <alan@redhat.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
	jgarzik@pobox.com, Linux IDE <linux-ide@vger.kernel.org>
Subject: Re: [PATCH] libata: Add MMIO support to pata_sil680
Date: Thu, 24 May 2007 13:42:17 +1000	[thread overview]
Message-ID: <1179978137.32247.1035.camel@localhost.localdomain> (raw)
In-Reply-To: <20070524001302.GA18571@devserv.devel.redhat.com>


> There are errata for config space and posting in some chipsets  and as you
> says its slow. The 400nS command writing bit applies too - they chipsets are
> not that smart in my experience.

Ok, I've start doing it, however, reset is the only case I've found.

Currently libata does the 400ns thingy in the inline ata_pause() which
unconditionally does ata_altstatus(); ndelay(400); (and thus does it on
PIO, MMIO, anything ...).

Do you want me to change that to use the MMIO flush hook as well ?

If we're going to do that, we probably need to be careful to have
everybody have a properly populated MMIO flush hook as there might be
current drivers (especially SATA) who rely on this. Jeff ?

Cheers,
Ben.
 


  reply	other threads:[~2007-05-24  3:48 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-15  6:12 [PATCH] libata: Add MMIO support to pata_sil680 Benjamin Herrenschmidt
2007-05-15  6:14 ` Benjamin Herrenschmidt
2007-05-23 13:42   ` Alan Cox
2007-05-23 22:48     ` Benjamin Herrenschmidt
2007-05-23 23:31       ` Alan Cox
2007-05-23 23:43         ` Benjamin Herrenschmidt
2007-05-24  0:13           ` Alan Cox
2007-05-24  3:42             ` Benjamin Herrenschmidt [this message]
2007-05-24  9:54               ` Alan Cox
2007-05-24 10:52                 ` Jeff Garzik
2007-05-24 11:09                   ` Alan Cox
2007-05-24 11:09                     ` Jeff Garzik
2007-05-25  0:29                     ` Jeff Garzik
2007-05-25  0:40                       ` Alan Cox
2007-05-25  0:51                         ` Jeff Garzik
2007-05-25 14:20                           ` Alan Cox
2007-05-28  2:21                             ` Jeff Garzik
2007-05-24  6:02         ` Jeff Garzik
2007-05-24  9:33           ` Alan Cox
2007-05-24  9:55             ` Jeff Garzik
2007-05-24 10:08               ` Benjamin Herrenschmidt
2007-05-24 20:56                 ` Mark Lord
2007-05-24 22:52                   ` Benjamin Herrenschmidt
2007-05-25 11:32                     ` Mark Lord
2007-05-24 10:06           ` Benjamin Herrenschmidt
  -- strict thread matches above, loose matches on Subject: below --
2008-02-12 15:58 Tim Ellis
2008-02-12 21:02 ` Benjamin Herrenschmidt
2008-02-12 21:42   ` Alan Cox
2008-02-15 15:52   ` Guennadi Liakhovetski
2008-02-15 15:53     ` Alan Cox
2008-02-15 21:45       ` Benjamin Herrenschmidt
2008-02-15 22:27         ` Alan Cox
2008-02-15 22:55           ` Benjamin Herrenschmidt
2008-02-15 23:56         ` Tim Ellis
2008-02-25 22:57           ` Jeff Garzik
2008-02-25 23:06             ` Guennadi Liakhovetski
2008-02-26  0:58             ` Benjamin Herrenschmidt
2008-02-15 21:36     ` Benjamin Herrenschmidt
2007-05-16  0:21 Benjamin Herrenschmidt
2007-05-16 12:05 ` Alan Cox
2007-05-16 12:12   ` Benjamin Herrenschmidt
2007-05-18  1:00 ` Jeff Garzik
2007-05-15  6:11 Benjamin Herrenschmidt
2007-05-15  6:14 ` Benjamin Herrenschmidt
2007-05-15 11:08 ` Alan Cox
2007-05-15 20:32   ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1179978137.32247.1035.camel@localhost.localdomain \
    --to=benh@kernel.crashing.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=alan@redhat.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.