From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Jeff Garzik <jeff@garzik.org>
Cc: Tim Ellis <tim@ngndg.com>,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] libata: Add MMIO support to pata_sil680
Date: Tue, 26 Feb 2008 11:58:22 +1100 [thread overview]
Message-ID: <1203987502.15052.71.camel@pasglop> (raw)
In-Reply-To: <47C347C3.40404@garzik.org>
> Yes.
>
> Alan loves to complain about lack of MMIO flush, but in practice this is
> rarely the source of problems such as the one you describe.
>
> But if its broken its broken, and we need to revert. Any luck getting
> benh access to the device?
>
Especially since reverting it will break a whole bunch of cell blades,
which wouldn't be nice (those cannot do PIO and have that controller).
In the meantime, we might "workaround" with a hack to only enable MMIO
on those cell
blades, something like:
#ifdef CONFIG_PPC64
if (machine_is(cell))
mmio = 1;
#endif
That might get us out of the regression until we find the proper
solution ?
Cheers,
Ben.
next prev parent reply other threads:[~2008-02-26 0:59 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-12 15:58 [PATCH] libata: Add MMIO support to pata_sil680 Tim Ellis
2008-02-12 21:02 ` Benjamin Herrenschmidt
2008-02-12 21:42 ` Alan Cox
2008-02-15 15:52 ` Guennadi Liakhovetski
2008-02-15 15:53 ` Alan Cox
2008-02-15 21:45 ` Benjamin Herrenschmidt
2008-02-15 22:27 ` Alan Cox
2008-02-15 22:55 ` Benjamin Herrenschmidt
2008-02-15 23:56 ` Tim Ellis
2008-02-25 22:57 ` Jeff Garzik
2008-02-25 23:06 ` Guennadi Liakhovetski
2008-02-26 0:58 ` Benjamin Herrenschmidt [this message]
2008-03-25 23:31 ` [PATCH] Work around breakage introduced in pata_sil680 by switching it to MMIO Guennadi Liakhovetski
2008-03-25 23:36 ` Alan Cox
2008-03-26 8:20 ` Benjamin Herrenschmidt
2008-02-15 21:36 ` [PATCH] libata: Add MMIO support to pata_sil680 Benjamin Herrenschmidt
-- strict thread matches above, loose matches on Subject: below --
2007-05-16 0:21 Benjamin Herrenschmidt
2007-05-16 12:05 ` Alan Cox
2007-05-16 12:12 ` Benjamin Herrenschmidt
2007-05-18 1:00 ` Jeff Garzik
2007-05-15 6:12 Benjamin Herrenschmidt
2007-05-15 6:14 ` Benjamin Herrenschmidt
2007-05-23 13:42 ` Alan Cox
2007-05-23 22:48 ` Benjamin Herrenschmidt
2007-05-23 23:31 ` Alan Cox
2007-05-23 23:43 ` Benjamin Herrenschmidt
2007-05-24 0:13 ` Alan Cox
2007-05-24 3:42 ` Benjamin Herrenschmidt
2007-05-24 9:54 ` Alan Cox
2007-05-24 10:52 ` Jeff Garzik
2007-05-24 11:09 ` Alan Cox
2007-05-24 11:09 ` Jeff Garzik
2007-05-25 0:29 ` Jeff Garzik
2007-05-25 0:40 ` Alan Cox
2007-05-25 0:51 ` Jeff Garzik
2007-05-25 14:20 ` Alan Cox
2007-05-28 2:21 ` Jeff Garzik
2007-05-24 6:02 ` Jeff Garzik
2007-05-24 9:33 ` Alan Cox
2007-05-24 9:55 ` Jeff Garzik
2007-05-24 10:08 ` Benjamin Herrenschmidt
2007-05-24 20:56 ` Mark Lord
2007-05-24 22:52 ` Benjamin Herrenschmidt
2007-05-25 11:32 ` Mark Lord
2007-05-24 10:06 ` Benjamin Herrenschmidt
2007-05-15 6:11 Benjamin Herrenschmidt
2007-05-15 6:14 ` Benjamin Herrenschmidt
2007-05-15 11:08 ` Alan Cox
2007-05-15 20:32 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1203987502.15052.71.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=g.liakhovetski@gmx.de \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tim@ngndg.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.