* [PATCH] drm/file: fix client_name_lock kernel-doc warning
@ 2024-10-09 14:03 Jani Nikula
2024-10-09 14:23 ` Dmitry Osipenko
0 siblings, 1 reply; 3+ messages in thread
From: Jani Nikula @ 2024-10-09 14:03 UTC (permalink / raw)
To: dri-devel
Cc: jani.nikula, Stephen Rothwell, Tvrtko Ursulin, Dmitry Osipenko,
Pierre-Eric Pelloux-Prayer, Christian König
It's client_name_lock, not name_lock. Also unify style while at it.
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Closes: https://lore.kernel.org/r/20241009172650.29169e6f@canb.auug.org.au
Fixes: 56c594d8df64 ("drm: add DRM_SET_CLIENT_NAME ioctl")
Cc: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
Cc: Dmitry Osipenko <dmitry.osipenko@collabora.com>
Cc: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Cc: Christian König <christian.koenig@amd.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
include/drm/drm_file.h | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/include/drm/drm_file.h b/include/drm/drm_file.h
index d4f1c115ea0f..f0ef32e9fa5e 100644
--- a/include/drm/drm_file.h
+++ b/include/drm/drm_file.h
@@ -395,7 +395,10 @@ struct drm_file {
* Userspace-provided name; useful for accounting and debugging.
*/
const char *client_name;
- /** @name_lock: Protects @client_name. */
+
+ /**
+ * @client_name_lock: Protects @client_name.
+ */
struct mutex client_name_lock;
};
--
2.39.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] drm/file: fix client_name_lock kernel-doc warning
2024-10-09 14:03 [PATCH] drm/file: fix client_name_lock kernel-doc warning Jani Nikula
@ 2024-10-09 14:23 ` Dmitry Osipenko
2024-10-09 14:33 ` Christian König
0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Osipenko @ 2024-10-09 14:23 UTC (permalink / raw)
To: Jani Nikula, dri-devel
Cc: Stephen Rothwell, Tvrtko Ursulin, Pierre-Eric Pelloux-Prayer,
Christian König
On 10/9/24 17:03, Jani Nikula wrote:
> It's client_name_lock, not name_lock. Also unify style while at it.
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Closes: https://lore.kernel.org/r/20241009172650.29169e6f@canb.auug.org.au
> Fixes: 56c594d8df64 ("drm: add DRM_SET_CLIENT_NAME ioctl")
> Cc: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
> Cc: Dmitry Osipenko <dmitry.osipenko@collabora.com>
> Cc: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
> Cc: Christian König <christian.koenig@amd.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> include/drm/drm_file.h | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/include/drm/drm_file.h b/include/drm/drm_file.h
> index d4f1c115ea0f..f0ef32e9fa5e 100644
> --- a/include/drm/drm_file.h
> +++ b/include/drm/drm_file.h
> @@ -395,7 +395,10 @@ struct drm_file {
> * Userspace-provided name; useful for accounting and debugging.
> */
> const char *client_name;
> - /** @name_lock: Protects @client_name. */
> +
> + /**
> + * @client_name_lock: Protects @client_name.
> + */
> struct mutex client_name_lock;
> };
Thanks for the quick fix! Please apply to misc-next
Reviewed-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
--
Best regards,
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/file: fix client_name_lock kernel-doc warning
2024-10-09 14:23 ` Dmitry Osipenko
@ 2024-10-09 14:33 ` Christian König
0 siblings, 0 replies; 3+ messages in thread
From: Christian König @ 2024-10-09 14:33 UTC (permalink / raw)
To: Dmitry Osipenko, Jani Nikula, dri-devel
Cc: Stephen Rothwell, Tvrtko Ursulin, Pierre-Eric Pelloux-Prayer
Am 09.10.24 um 16:23 schrieb Dmitry Osipenko:
> On 10/9/24 17:03, Jani Nikula wrote:
>> It's client_name_lock, not name_lock. Also unify style while at it.
>>
>> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
>> Closes: https://lore.kernel.org/r/20241009172650.29169e6f@canb.auug.org.au
>> Fixes: 56c594d8df64 ("drm: add DRM_SET_CLIENT_NAME ioctl")
>> Cc: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
>> Cc: Dmitry Osipenko <dmitry.osipenko@collabora.com>
>> Cc: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
>> Cc: Christian König <christian.koenig@amd.com>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> ---
>> include/drm/drm_file.h | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/include/drm/drm_file.h b/include/drm/drm_file.h
>> index d4f1c115ea0f..f0ef32e9fa5e 100644
>> --- a/include/drm/drm_file.h
>> +++ b/include/drm/drm_file.h
>> @@ -395,7 +395,10 @@ struct drm_file {
>> * Userspace-provided name; useful for accounting and debugging.
>> */
>> const char *client_name;
>> - /** @name_lock: Protects @client_name. */
>> +
>> + /**
>> + * @client_name_lock: Protects @client_name.
>> + */
>> struct mutex client_name_lock;
>> };
> Thanks for the quick fix! Please apply to misc-next
Done.
Christian.
>
> Reviewed-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-09 14:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-09 14:03 [PATCH] drm/file: fix client_name_lock kernel-doc warning Jani Nikula
2024-10-09 14:23 ` Dmitry Osipenko
2024-10-09 14:33 ` Christian König
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.