From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Marc Eshel <eshel@almaden.ibm.com>
Cc: "J. Bruce Fields" <bfields@fieldses.org>,
linux-fsdevel@vger.kernel.org, nfs@lists.sourceforge.net,
David Teigland <teigland@redhat.com>
Subject: Re: [NFS] [PATCH] locks: provide a file lease method enabling cluster-coherent leases
Date: Sat, 02 Jun 2007 14:21:22 -0400 [thread overview]
Message-ID: <1180808482.6687.30.camel@heimdal.trondhjem.org> (raw)
In-Reply-To: <OF3A5C7199.4DE8BA91-ON882572EE.006302AD-882572EE.0063A704@us.ibm.com>
On Sat, 2007-06-02 at 11:09 -0700, Marc Eshel wrote:
> A cluster filesystem don't need the inode operation breake_lease. The fs
> must be able to detect the conflict and break the lease using
> __break_lease() call on all the nodes that hold a conflicting leases.
> Marc.
Currently, the lease handling is done all in the VFS, and is done prior
to calling any filesystem operations. Bruce's break_lease() inode
operation allows the VFS to notify the filesystem that some operation is
going to be called that requires the lease to be broken.
My point is that in doing so, you are not atomic with the operation that
requires the lease to be broken. Some different node may re-establish a
lease while we're calling back down into the filesystem to perform the
operation.
So I agree with you. The break_lease() inode operation isn't going to
work. The filesystem is going to have to figure out for itself when it
needs to notify other nodes that the lease needs breaking, and it needs
to figure out its own methods for ensuring atomicity.
Cheers
Trond
next prev parent reply other threads:[~2007-06-02 18:21 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-31 21:40 cluster-coherent leases J. Bruce Fields
2007-05-31 21:40 ` [PATCH] locks: share more common lease code J. Bruce Fields
2007-05-31 21:40 ` [PATCH] locks: provide a file lease method enabling cluster-coherent leases J. Bruce Fields
2007-05-31 21:40 ` [PATCH] gfs2: stop giving out non-cluster-coherent leases J. Bruce Fields
2007-05-31 22:34 ` [PATCH] locks: provide a file lease method enabling cluster-coherent leases Trond Myklebust
2007-06-01 16:53 ` [NFS] " J. Bruce Fields
2007-06-02 17:39 ` Trond Myklebust
2007-06-02 18:09 ` Marc Eshel
2007-06-02 18:21 ` Trond Myklebust [this message]
2007-06-04 13:59 ` J. Bruce Fields
2007-06-05 22:04 ` Robert Rappaport
2007-06-05 22:53 ` [NFS] " Trond Myklebust
2007-06-05 22:56 ` Marc Eshel
2007-06-05 23:40 ` Trond Myklebust
2007-06-06 18:43 ` Robert Rappaport
2007-06-07 14:43 ` [NFS] " Robert Rappaport
2007-06-07 17:05 ` J. Bruce Fields
2007-06-08 22:14 ` (unknown), J. Bruce Fields
2007-06-08 22:14 ` (no subject) J. Bruce Fields
[not found] ` <11813408953536-git-send-email->
2007-06-08 22:14 ` [PATCH 1/5] locks: share more common lease code J. Bruce Fields
2007-06-08 22:14 ` J. Bruce Fields
[not found] ` <11813408952518-git-send-email->
2007-06-08 22:14 ` [PATCH 2/5] locks: provide a file lease method enabling cluster-coherent leases J. Bruce Fields
2007-06-08 22:14 ` J. Bruce Fields
[not found] ` <11813408951909-git-send-email->
2007-06-08 22:14 ` [PATCH 3/5] locks: rename lease functions to reflect locks.c conventions J. Bruce Fields
2007-06-08 22:14 ` J. Bruce Fields
[not found] ` <11813408954053-git-send-email->
2007-06-08 22:14 ` [PATCH 4/5] gfs2: stop giving out non-cluster-coherent leases J. Bruce Fields
2007-06-08 22:14 ` J. Bruce Fields
[not found] ` <11813408951694-git-send-email->
2007-06-08 22:14 ` [PATCH 5/5] nfs: disable leases over NFS J. Bruce Fields
2007-06-08 22:14 ` J. Bruce Fields
2007-06-09 14:18 ` [PATCH 4/5] gfs2: stop giving out non-cluster-coherent leases Steven Whitehouse
2007-06-09 16:35 ` Marc Eshel
2007-06-11 9:38 ` Steven Whitehouse
2007-06-11 17:07 ` J. Bruce Fields
2007-06-09 16:56 ` [PATCH 3/5] locks: rename lease functions to reflect locks.c conventions Marc Eshel
2007-06-11 16:53 ` J. Bruce Fields
2007-06-02 18:23 ` [NFS] [PATCH] locks: provide a file lease method enabling cluster-coherent leases Trond Myklebust
2007-06-01 13:14 ` Peter Staubach
2007-06-01 16:44 ` [NFS] " J. Bruce Fields
2007-06-01 17:41 ` Matthew Wilcox
2007-06-01 18:08 ` J. Bruce Fields
2007-05-31 21:51 ` [PATCH] locks: share more common lease code Trond Myklebust
2007-06-01 16:30 ` [NFS] " J. Bruce Fields
2007-06-01 16:36 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1180808482.6687.30.camel@heimdal.trondhjem.org \
--to=trond.myklebust@fys.uio.no \
--cc=bfields@fieldses.org \
--cc=eshel@almaden.ibm.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=nfs@lists.sourceforge.net \
--cc=teigland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.