* [KJ][PATCH]is_power_of_2-block/rd.c
@ 2007-06-07 10:09 ` vignesh babu
0 siblings, 0 replies; 2+ messages in thread
From: vignesh babu @ 2007-06-07 9:57 UTC (permalink / raw)
To: axboe, page0588; +Cc: linux-kernel, Kernel Janitors List
Replacing (n & (n-1)) in the context of power of 2 checks
with is_power_of_2
Signed-off-by: vignesh babu <vignesh.babu@wipro.com>
---
diff --git a/drivers/block/rd.c b/drivers/block/rd.c
index a1512da..e57f729 100644
--- a/drivers/block/rd.c
+++ b/drivers/block/rd.c
@@ -56,6 +56,7 @@
#include <linux/backing-dev.h>
#include <linux/blkpg.h>
#include <linux/writeback.h>
+#include <linux/log2.h>
#include <asm/uaccess.h>
@@ -422,7 +423,7 @@ static int __init rd_init(void)
int err = -ENOMEM;
if (rd_blocksize > PAGE_SIZE || rd_blocksize < 512 ||
- (rd_blocksize & (rd_blocksize-1))) {
+ !is_power_of_2(rd_blocksize)) {
printk("RAMDISK: wrong blocksize %d, reverting to defaults\n",
rd_blocksize);
rd_blocksize = BLOCK_SIZE;
--
Vignesh Babu BM
_____________________________________________________________
"Why is it that every time I'm with you, makes me believe in magic?"
^ permalink raw reply related [flat|nested] 2+ messages in thread* [KJ][PATCH]is_power_of_2-block/rd.c
@ 2007-06-07 10:09 ` vignesh babu
0 siblings, 0 replies; 2+ messages in thread
From: vignesh babu @ 2007-06-07 10:09 UTC (permalink / raw)
To: axboe, page0588; +Cc: linux-kernel, Kernel Janitors List
Replacing (n & (n-1)) in the context of power of 2 checks
with is_power_of_2
Signed-off-by: vignesh babu <vignesh.babu@wipro.com>
---
diff --git a/drivers/block/rd.c b/drivers/block/rd.c
index a1512da..e57f729 100644
--- a/drivers/block/rd.c
+++ b/drivers/block/rd.c
@@ -56,6 +56,7 @@
#include <linux/backing-dev.h>
#include <linux/blkpg.h>
#include <linux/writeback.h>
+#include <linux/log2.h>
#include <asm/uaccess.h>
@@ -422,7 +423,7 @@ static int __init rd_init(void)
int err = -ENOMEM;
if (rd_blocksize > PAGE_SIZE || rd_blocksize < 512 ||
- (rd_blocksize & (rd_blocksize-1))) {
+ !is_power_of_2(rd_blocksize)) {
printk("RAMDISK: wrong blocksize %d, reverting to defaults\n",
rd_blocksize);
rd_blocksize = BLOCK_SIZE;
--
Vignesh Babu BM
_____________________________________________________________
"Why is it that every time I'm with you, makes me believe in magic?"
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-06-07 10:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-06-07 9:57 [KJ][PATCH]is_power_of_2-block/rd.c vignesh babu
2007-06-07 10:09 ` [KJ][PATCH]is_power_of_2-block/rd.c vignesh babu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.