* [KJ][PATCH]is_power_of_2-sparc/mm/srmmu.c
@ 2007-06-07 9:57 ` vignesh babu
0 siblings, 0 replies; 4+ messages in thread
From: vignesh babu @ 2007-06-07 9:57 UTC (permalink / raw)
To: wli, davem, zaitcev, ecd, jj, anton
Cc: sparclinux, linux-mm, linux-kernel, Kernel Janitors List
Replacing (n & (n-1)) in the context of power of 2 checks
with is_power_of_2
Signed-off-by: vignesh babu <vignesh.babu@wipro.com>
---
diff --git a/arch/sparc/mm/srmmu.c b/arch/sparc/mm/srmmu.c
index e5eaa80..741d303 100644
--- a/arch/sparc/mm/srmmu.c
+++ b/arch/sparc/mm/srmmu.c
@@ -19,6 +19,7 @@
#include <linux/fs.h>
#include <linux/seq_file.h>
#include <linux/kdebug.h>
+#include <linux/log2.h>
#include <asm/bitext.h>
#include <asm/page.h>
@@ -354,7 +355,7 @@ void srmmu_free_nocache(unsigned long vaddr, int
size)
vaddr, srmmu_nocache_end);
BUG();
}
- if (size & (size-1)) {
+ if (!is_power_of_2(size)) {
printk("Size 0x%x is not a power of 2\n", size);
BUG();
}
--
Vignesh Babu BM
_____________________________________________________________
"Why is it that every time I'm with you, makes me believe in magic?"
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [KJ][PATCH]is_power_of_2-sparc/mm/srmmu.c
@ 2007-06-07 9:57 ` vignesh babu
0 siblings, 0 replies; 4+ messages in thread
From: vignesh babu @ 2007-06-07 9:57 UTC (permalink / raw)
To: wli, davem, zaitcev, ecd, jj, anton
Cc: sparclinux, linux-mm, linux-kernel, Kernel Janitors List
Replacing (n & (n-1)) in the context of power of 2 checks
with is_power_of_2
Signed-off-by: vignesh babu <vignesh.babu@wipro.com>
---
diff --git a/arch/sparc/mm/srmmu.c b/arch/sparc/mm/srmmu.c
index e5eaa80..741d303 100644
--- a/arch/sparc/mm/srmmu.c
+++ b/arch/sparc/mm/srmmu.c
@@ -19,6 +19,7 @@
#include <linux/fs.h>
#include <linux/seq_file.h>
#include <linux/kdebug.h>
+#include <linux/log2.h>
#include <asm/bitext.h>
#include <asm/page.h>
@@ -354,7 +355,7 @@ void srmmu_free_nocache(unsigned long vaddr, int
size)
vaddr, srmmu_nocache_end);
BUG();
}
- if (size & (size-1)) {
+ if (!is_power_of_2(size)) {
printk("Size 0x%x is not a power of 2\n", size);
BUG();
}
--
Vignesh Babu BM
_____________________________________________________________
"Why is it that every time I'm with you, makes me believe in magic?"
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [KJ][PATCH]is_power_of_2-sparc/mm/srmmu.c
@ 2007-06-07 9:57 ` vignesh babu
0 siblings, 0 replies; 4+ messages in thread
From: vignesh babu @ 2007-06-07 10:09 UTC (permalink / raw)
To: wli, davem, zaitcev, ecd, jj, anton
Cc: sparclinux, linux-mm, linux-kernel, Kernel Janitors List
Replacing (n & (n-1)) in the context of power of 2 checks
with is_power_of_2
Signed-off-by: vignesh babu <vignesh.babu@wipro.com>
---
diff --git a/arch/sparc/mm/srmmu.c b/arch/sparc/mm/srmmu.c
index e5eaa80..741d303 100644
--- a/arch/sparc/mm/srmmu.c
+++ b/arch/sparc/mm/srmmu.c
@@ -19,6 +19,7 @@
#include <linux/fs.h>
#include <linux/seq_file.h>
#include <linux/kdebug.h>
+#include <linux/log2.h>
#include <asm/bitext.h>
#include <asm/page.h>
@@ -354,7 +355,7 @@ void srmmu_free_nocache(unsigned long vaddr, int
size)
vaddr, srmmu_nocache_end);
BUG();
}
- if (size & (size-1)) {
+ if (!is_power_of_2(size)) {
printk("Size 0x%x is not a power of 2\n", size);
BUG();
}
--
Vignesh Babu BM
_____________________________________________________________
"Why is it that every time I'm with you, makes me believe in magic?"
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [KJ][PATCH]is_power_of_2-sparc/mm/srmmu.c
@ 2007-06-07 9:57 ` vignesh babu
0 siblings, 0 replies; 4+ messages in thread
From: vignesh babu @ 2007-06-07 10:09 UTC (permalink / raw)
To: wli, davem, zaitcev, ecd, jj, anton
Cc: sparclinux, linux-mm, linux-kernel, Kernel Janitors List
Replacing (n & (n-1)) in the context of power of 2 checks
with is_power_of_2
Signed-off-by: vignesh babu <vignesh.babu@wipro.com>
---
diff --git a/arch/sparc/mm/srmmu.c b/arch/sparc/mm/srmmu.c
index e5eaa80..741d303 100644
--- a/arch/sparc/mm/srmmu.c
+++ b/arch/sparc/mm/srmmu.c
@@ -19,6 +19,7 @@
#include <linux/fs.h>
#include <linux/seq_file.h>
#include <linux/kdebug.h>
+#include <linux/log2.h>
#include <asm/bitext.h>
#include <asm/page.h>
@@ -354,7 +355,7 @@ void srmmu_free_nocache(unsigned long vaddr, int
size)
vaddr, srmmu_nocache_end);
BUG();
}
- if (size & (size-1)) {
+ if (!is_power_of_2(size)) {
printk("Size 0x%x is not a power of 2\n", size);
BUG();
}
--
Vignesh Babu BM
_____________________________________________________________
"Why is it that every time I'm with you, makes me believe in magic?"
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-06-07 10:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-06-07 9:57 [KJ][PATCH]is_power_of_2-sparc/mm/srmmu.c vignesh babu
2007-06-07 10:09 ` [KJ][PATCH]is_power_of_2-sparc/mm/srmmu.c vignesh babu
2007-06-07 10:09 ` [KJ][PATCH]is_power_of_2-sparc/mm/srmmu.c vignesh babu
2007-06-07 9:57 ` [KJ][PATCH]is_power_of_2-sparc/mm/srmmu.c vignesh babu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.