* [PATCH]is_power_of_2-scsi/esp_scsi.c
@ 2007-06-12 5:36 ` vignesh babu
0 siblings, 0 replies; 2+ messages in thread
From: vignesh babu @ 2007-06-12 5:24 UTC (permalink / raw)
To: James.Bottomley; +Cc: linux-scsi, Kernel Janitors List
Replacing (n & (n-1)) in the context of power of 2 checks
with is_power_of_2
Signed-off-by: vignesh babu <vignesh.babu@wipro.com>
---
diff --git a/drivers/scsi/esp_scsi.c b/drivers/scsi/esp_scsi.c
index ec71061..c416154 100644
--- a/drivers/scsi/esp_scsi.c
+++ b/drivers/scsi/esp_scsi.c
@@ -14,6 +14,7 @@
#include <linux/moduleparam.h>
#include <linux/init.h>
#include <linux/irqreturn.h>
+#include <linux/log2.h>
#include <asm/irq.h>
#include <asm/io.h>
@@ -1130,7 +1131,7 @@ static int esp_reconnect(struct esp *esp)
if (!(bits & esp->scsi_id_mask))
goto do_reset;
bits &= ~esp->scsi_id_mask;
- if (!bits || (bits & (bits - 1)))
+ if (!is_power_of_2(bits))
goto do_reset;
target = ffs(bits) - 1;
--
Vignesh Babu BM
_____________________________________________________________
"Why is it that every time I'm with you, makes me believe in magic?"
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [KJ] [PATCH]is_power_of_2-scsi/esp_scsi.c
@ 2007-06-12 5:36 ` vignesh babu
0 siblings, 0 replies; 2+ messages in thread
From: vignesh babu @ 2007-06-12 5:36 UTC (permalink / raw)
To: James.Bottomley; +Cc: linux-scsi, Kernel Janitors List
Replacing (n & (n-1)) in the context of power of 2 checks
with is_power_of_2
Signed-off-by: vignesh babu <vignesh.babu@wipro.com>
---
diff --git a/drivers/scsi/esp_scsi.c b/drivers/scsi/esp_scsi.c
index ec71061..c416154 100644
--- a/drivers/scsi/esp_scsi.c
+++ b/drivers/scsi/esp_scsi.c
@@ -14,6 +14,7 @@
#include <linux/moduleparam.h>
#include <linux/init.h>
#include <linux/irqreturn.h>
+#include <linux/log2.h>
#include <asm/irq.h>
#include <asm/io.h>
@@ -1130,7 +1131,7 @@ static int esp_reconnect(struct esp *esp)
if (!(bits & esp->scsi_id_mask))
goto do_reset;
bits &= ~esp->scsi_id_mask;
- if (!bits || (bits & (bits - 1)))
+ if (!is_power_of_2(bits))
goto do_reset;
target = ffs(bits) - 1;
--
Vignesh Babu BM
_____________________________________________________________
"Why is it that every time I'm with you, makes me believe in magic?"
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-06-12 5:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-06-12 5:24 [PATCH]is_power_of_2-scsi/esp_scsi.c vignesh babu
2007-06-12 5:36 ` [KJ] [PATCH]is_power_of_2-scsi/esp_scsi.c vignesh babu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.