All of lore.kernel.org
 help / color / mirror / Atom feed
From: vignesh babu <vignesh.babu@wipro.com>
To: matthew@wil.cx
Cc: linux-scsi@vger.kernel.org,
	Kernel Janitors List <kernel-janitors@lists.osdl.org>
Subject: [KJ] [PATCH][RESEND]is_power_of_2-scsi/NCR53C9x.c
Date: Wed, 13 Jun 2007 05:31:19 +0000	[thread overview]
Message-ID: <1181711960.13391.47.camel@merlin.linuxcoe.com> (raw)

David S. Miller (davem@caip.rutgers.edu)
LSILOGIC/SYMBIOS/NCR 53C8XX and 53C1010 PCI-SCSI drivers
P:	Matthew Wilcox
M:	matthew@wil.cx
L:	linux-scsi@vger.kernel.org
S:	Maintained


Replacing (n & (n-1)) in the context of power of 2 checks
with is_power_of_2

Thanks Mathew for pointing out the double check that was going on for 0.I have fixed that.

Signed-off-by: vignesh babu <vignesh.babu@wipro.com>
--- 
diff --git a/drivers/scsi/NCR53C9x.c b/drivers/scsi/NCR53C9x.c
index 8b5334c..60692dc 100644
--- a/drivers/scsi/NCR53C9x.c
+++ b/drivers/scsi/NCR53C9x.c
@@ -33,6 +33,7 @@
 #include <linux/proc_fs.h>
 #include <linux/stat.h>
 #include <linux/init.h>
+#include <linux/log2.h>
 
 #include "scsi.h"
 #include <scsi/scsi_host.h>
@@ -1648,10 +1649,8 @@ static inline int reconnect_target(struct NCR_ESP *esp, struct ESP_regs *eregs)
 	if(2 != fcount(esp, eregs))
 		return -1;
 	it = esp_read(eregs->esp_fdata);
-	if(!(it & me))
-		return -1;
 	it &= ~me;
-	if(it & (it - 1))
+	if(!is_power_of_2(it))
 		return -1;
 	while(!(it & 1))
 		targ++, it >>= 1;

-- 
Vignesh Babu BM 
_____________________________________________________________ 
"Why is it that every time I'm with you, makes me believe in magic?"

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors

WARNING: multiple messages have this Message-ID (diff)
From: vignesh babu <vignesh.babu@wipro.com>
To: matthew@wil.cx
Cc: linux-scsi@vger.kernel.org,
	Kernel Janitors List <kernel-janitors@lists.osdl.org>
Subject: [PATCH][RESEND]is_power_of_2-scsi/NCR53C9x.c
Date: Wed, 13 Jun 2007 10:49:19 +0530	[thread overview]
Message-ID: <1181711960.13391.47.camel@merlin.linuxcoe.com> (raw)

David S. Miller (davem@caip.rutgers.edu)
LSILOGIC/SYMBIOS/NCR 53C8XX and 53C1010 PCI-SCSI drivers
P:	Matthew Wilcox
M:	matthew@wil.cx
L:	linux-scsi@vger.kernel.org
S:	Maintained


Replacing (n & (n-1)) in the context of power of 2 checks
with is_power_of_2

Thanks Mathew for pointing out the double check that was going on for 0.I have fixed that.

Signed-off-by: vignesh babu <vignesh.babu@wipro.com>
--- 
diff --git a/drivers/scsi/NCR53C9x.c b/drivers/scsi/NCR53C9x.c
index 8b5334c..60692dc 100644
--- a/drivers/scsi/NCR53C9x.c
+++ b/drivers/scsi/NCR53C9x.c
@@ -33,6 +33,7 @@
 #include <linux/proc_fs.h>
 #include <linux/stat.h>
 #include <linux/init.h>
+#include <linux/log2.h>
 
 #include "scsi.h"
 #include <scsi/scsi_host.h>
@@ -1648,10 +1649,8 @@ static inline int reconnect_target(struct NCR_ESP *esp, struct ESP_regs *eregs)
 	if(2 != fcount(esp, eregs))
 		return -1;
 	it = esp_read(eregs->esp_fdata);
-	if(!(it & me))
-		return -1;
 	it &= ~me;
-	if(it & (it - 1))
+	if(!is_power_of_2(it))
 		return -1;
 	while(!(it & 1))
 		targ++, it >>= 1;

-- 
Vignesh Babu BM 
_____________________________________________________________ 
"Why is it that every time I'm with you, makes me believe in magic?"


             reply	other threads:[~2007-06-13  5:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-13  5:19 vignesh babu [this message]
2007-06-13  5:31 ` [KJ] [PATCH][RESEND]is_power_of_2-scsi/NCR53C9x.c vignesh babu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1181711960.13391.47.camel@merlin.linuxcoe.com \
    --to=vignesh.babu@wipro.com \
    --cc=kernel-janitors@lists.osdl.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=matthew@wil.cx \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.