* [PATCH]is_power_of_2-nfs/internal.h @ 2007-06-14 8:20 ` vignesh babu 0 siblings, 0 replies; 11+ messages in thread From: vignesh babu @ 2007-06-14 8:08 UTC (permalink / raw) To: neilb; +Cc: Kernel Janitors List, nfs Replacing (n & (n-1)) in the context of power of 2 checks with is_power_of_2 Signed-off-by: vignesh babu <vignesh.babu@wipro.com> --- diff --git a/fs/nfs/internal.h b/fs/nfs/internal.h index ad2b40d..5dca432 100644 --- a/fs/nfs/internal.h +++ b/fs/nfs/internal.h @@ -3,6 +3,7 @@ */ #include <linux/mount.h> +#include <linux/log2.h> struct nfs_string; struct nfs_mount_data; @@ -167,7 +168,7 @@ static inline unsigned long nfs_block_bits(unsigned long bsize, unsigned char *nrbitsp) { /* make sure blocksize is a power of two */ - if ((bsize & (bsize - 1)) || nrbitsp) { + if (is_power_of_2(bsize) || nrbitsp) { unsigned char nrbits; for (nrbits = 31; nrbits && !(bsize & (1 << nrbits)); nrbits--) -- Vignesh Babu BM _____________________________________________________________ "Why is it that every time I'm with you, makes me believe in magic?" ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ NFS maillist - NFS@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs ^ permalink raw reply related [flat|nested] 11+ messages in thread
* [KJ] [PATCH]is_power_of_2-nfs/internal.h @ 2007-06-14 8:20 ` vignesh babu 0 siblings, 0 replies; 11+ messages in thread From: vignesh babu @ 2007-06-14 8:20 UTC (permalink / raw) To: neilb; +Cc: Kernel Janitors List, nfs Replacing (n & (n-1)) in the context of power of 2 checks with is_power_of_2 Signed-off-by: vignesh babu <vignesh.babu@wipro.com> --- diff --git a/fs/nfs/internal.h b/fs/nfs/internal.h index ad2b40d..5dca432 100644 --- a/fs/nfs/internal.h +++ b/fs/nfs/internal.h @@ -3,6 +3,7 @@ */ #include <linux/mount.h> +#include <linux/log2.h> struct nfs_string; struct nfs_mount_data; @@ -167,7 +168,7 @@ static inline unsigned long nfs_block_bits(unsigned long bsize, unsigned char *nrbitsp) { /* make sure blocksize is a power of two */ - if ((bsize & (bsize - 1)) || nrbitsp) { + if (is_power_of_2(bsize) || nrbitsp) { unsigned char nrbits; for (nrbits = 31; nrbits && !(bsize & (1 << nrbits)); nrbits--) -- Vignesh Babu BM _____________________________________________________________ "Why is it that every time I'm with you, makes me believe in magic?" _______________________________________________ Kernel-janitors mailing list Kernel-janitors@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors ^ permalink raw reply related [flat|nested] 11+ messages in thread
* [KJ] Re: [NFS] [PATCH]is_power_of_2-nfs/internal.h 2007-06-14 8:20 ` [KJ] [PATCH]is_power_of_2-nfs/internal.h vignesh babu @ 2007-06-14 15:45 ` Trond Myklebust -1 siblings, 0 replies; 11+ messages in thread From: Trond Myklebust @ 2007-06-14 15:45 UTC (permalink / raw) To: vignesh.babu; +Cc: neilb, Kernel Janitors List, nfs On Thu, 2007-06-14 at 13:38 +0530, vignesh babu wrote: > Replacing (n & (n-1)) in the context of power of 2 checks > with is_power_of_2 > > Signed-off-by: vignesh babu <vignesh.babu@wipro.com> > --- > diff --git a/fs/nfs/internal.h b/fs/nfs/internal.h > index ad2b40d..5dca432 100644 > --- a/fs/nfs/internal.h > +++ b/fs/nfs/internal.h > @@ -3,6 +3,7 @@ > */ > > #include <linux/mount.h> > +#include <linux/log2.h> > > struct nfs_string; > struct nfs_mount_data; > @@ -167,7 +168,7 @@ static inline > unsigned long nfs_block_bits(unsigned long bsize, unsigned char *nrbitsp) > { > /* make sure blocksize is a power of two */ > - if ((bsize & (bsize - 1)) || nrbitsp) { > + if (is_power_of_2(bsize) || nrbitsp) { > unsigned char nrbits; > > for (nrbits = 31; nrbits && !(bsize & (1 << nrbits)); nrbits--) > We don't need the extra test for bsize = 0 that this introduces: bsize is guaranteed to be at least 1024 or greater. Trond _______________________________________________ Kernel-janitors mailing list Kernel-janitors@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH]is_power_of_2-nfs/internal.h @ 2007-06-14 15:45 ` Trond Myklebust 0 siblings, 0 replies; 11+ messages in thread From: Trond Myklebust @ 2007-06-14 15:45 UTC (permalink / raw) To: vignesh.babu; +Cc: neilb, Kernel Janitors List, nfs On Thu, 2007-06-14 at 13:38 +0530, vignesh babu wrote: > Replacing (n & (n-1)) in the context of power of 2 checks > with is_power_of_2 > > Signed-off-by: vignesh babu <vignesh.babu@wipro.com> > --- > diff --git a/fs/nfs/internal.h b/fs/nfs/internal.h > index ad2b40d..5dca432 100644 > --- a/fs/nfs/internal.h > +++ b/fs/nfs/internal.h > @@ -3,6 +3,7 @@ > */ > > #include <linux/mount.h> > +#include <linux/log2.h> > > struct nfs_string; > struct nfs_mount_data; > @@ -167,7 +168,7 @@ static inline > unsigned long nfs_block_bits(unsigned long bsize, unsigned char *nrbitsp) > { > /* make sure blocksize is a power of two */ > - if ((bsize & (bsize - 1)) || nrbitsp) { > + if (is_power_of_2(bsize) || nrbitsp) { > unsigned char nrbits; > > for (nrbits = 31; nrbits && !(bsize & (1 << nrbits)); nrbits--) > We don't need the extra test for bsize == 0 that this introduces: bsize is guaranteed to be at least 1024 or greater. Trond ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ NFS maillist - NFS@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs ^ permalink raw reply [flat|nested] 11+ messages in thread
* NFS and Samba Winbindd 2007-06-14 15:45 ` [PATCH]is_power_of_2-nfs/internal.h Trond Myklebust (?) @ 2007-06-15 6:50 ` Laurenz, Dirk 2007-06-15 9:44 ` Chris Osicki -1 siblings, 1 reply; 11+ messages in thread From: Laurenz, Dirk @ 2007-06-15 6:50 UTC (permalink / raw) To: nfs@lists.sourceforge.net [-- Attachment #1: Type: text/plain, Size: 1382 bytes --] Hi, i have the following problem, which i'm not able to solve. The setup is as follows: Linux 2.6 Kernel (SLES9-32bit, Post SP3) nssswitch.conf [...] groups: files ldap windbindd [...] A user in a an global samba/ldap group. This group is in a local winbindgroup TESTGROUP. (This is right concept used and works for samba shares and interactive logons directly to the server) There is a directory /test with the only acl TESTGROUP:rwx This works: su - $user cd /work mkdir test So all right's a resolved correctly This works not exportfs *:/work -o all_squash,anonuid=12345,anongid=12345 uid of $user is 12345 mount /work on some host on /mnt cd /mnt on the nfs client results in Permission denied setting an acl: setfacl -m u:$User:rwx results in cd /mnt and ls is working. my question is now: is the nfsd unable to resolv winbindd local groups? Mit freundlichem Gruss, Dirk Laurenz Systems Engineer S DE SE PS N/O Fujitsu Siemens Computers Hildesheimer Strasse 25 30880 Laatzen Germany Telephone: +49 511 84 89 18 08 Telefax: +49 511 84 89 25 18 08 Mobile: +49 170 22 10 781 Email: mailto: dirk.laurenz@fujitsu-siemens.com Internet: http://www.fujitsu-siemens.com Firmenangaben: http://www.fujitsu-siemens.de/imprint.html [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #2: Laurenz, Dirk.vcf --] [-- Type: text/x-vcard; name="Laurenz, Dirk.vcf", Size: 434 bytes --] BEGIN:VCARD VERSION:2.1 N:Laurenz;Dirk FN:Laurenz, Dirk ORG:FSC;FSC S DE SE PS Nord/Ost TEL;WORK;VOICE:+49 (511) 8489-1808 TEL;CELL;VOICE:+49 (170) 2210-781 ADR;WORK:;/;Hildesheimer Straße 25;Hannover / Laatzen;;30880;Germany LABEL;WORK;ENCODING=QUOTED-PRINTABLE:/=0D=0AHildesheimer Stra=DFe 25=0D=0AHannover / Laatzen 30880=0D=0AGermany EMAIL;PREF;INTERNET:Dirk.Laurenz@fujitsu-siemens.com REV:20060825T165428Z END:VCARD [-- Attachment #3: Type: text/plain, Size: 286 bytes --] ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ [-- Attachment #4: Type: text/plain, Size: 140 bytes --] _______________________________________________ NFS maillist - NFS@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: NFS and Samba Winbindd 2007-06-15 6:50 ` NFS and Samba Winbindd Laurenz, Dirk @ 2007-06-15 9:44 ` Chris Osicki 2007-06-15 9:58 ` Laurenz, Dirk 0 siblings, 1 reply; 11+ messages in thread From: Chris Osicki @ 2007-06-15 9:44 UTC (permalink / raw) To: nfs Hi Shouldn't it read winbind instead of winbindd in nsswitch.conf? Regards, Chris On Fri, 15 Jun 2007 08:50:36 +0200 "Laurenz, Dirk" <Dirk.Laurenz@fujitsu-siemens.com> wrote: > Hi, > > i have the following problem, which i'm not able to solve. > > The setup is as follows: > > Linux 2.6 Kernel (SLES9-32bit, Post SP3) > nssswitch.conf > [...] > groups: files ldap windbindd > [...] > > A user in a an global samba/ldap group. This group is in a local winbindgroup TESTGROUP. > (This is right concept used and works for samba shares and interactive logons directly to the server) > > There is a directory /test with the only acl TESTGROUP:rwx > > This works: > su - $user > cd /work > mkdir test > > So all right's a resolved correctly > > This works not > exportfs *:/work -o all_squash,anonuid=12345,anongid=12345 > > uid of $user is 12345 > > mount /work on some host on /mnt > cd /mnt on the nfs client results in Permission denied > > setting an acl: > setfacl -m u:$User:rwx > > results in cd /mnt and ls is working. > > my question is now: > is the nfsd unable to resolv winbindd local groups? > > Mit freundlichem Gruss, > > Dirk Laurenz > Systems Engineer > S DE SE PS N/O > Fujitsu Siemens Computers > Hildesheimer Strasse 25 > 30880 Laatzen > Germany > > Telephone: +49 511 84 89 18 08 > Telefax: +49 511 84 89 25 18 08 > Mobile: +49 170 22 10 781 > Email: mailto: dirk.laurenz@fujitsu-siemens.com > Internet: http://www.fujitsu-siemens.com > Firmenangaben: http://www.fujitsu-siemens.de/imprint.html > > > > > ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ NFS maillist - NFS@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: NFS and Samba Winbindd 2007-06-15 9:44 ` Chris Osicki @ 2007-06-15 9:58 ` Laurenz, Dirk 2007-06-20 5:31 ` Laurenz, Dirk 0 siblings, 1 reply; 11+ messages in thread From: Laurenz, Dirk @ 2007-06-15 9:58 UTC (permalink / raw) To: Chris Osicki, nfs@lists.sourceforge.net Hi, sorry, i mistyped this in the email on the server it is correctly typed > -----Original Message----- > From: nfs-bounces@lists.sourceforge.net > [mailto:nfs-bounces@lists.sourceforge.net] On Behalf Of Chris Osicki > Sent: Friday, June 15, 2007 11:44 AM > To: nfs@lists.sourceforge.net > Subject: Re: [NFS] NFS and Samba Winbindd > > > > Hi > > Shouldn't it read winbind instead of winbindd in nsswitch.conf? > > Regards, > Chris > > On Fri, 15 Jun 2007 08:50:36 +0200 > "Laurenz, Dirk" <Dirk.Laurenz@fujitsu-siemens.com> wrote: > > > Hi, > > > > i have the following problem, which i'm not able to solve. > > > > The setup is as follows: > > > > Linux 2.6 Kernel (SLES9-32bit, Post SP3) > > nssswitch.conf > > [...] > > groups: files ldap windbindd > > [...] > > > > A user in a an global samba/ldap group. This group is in a > local winbindgroup TESTGROUP. > > (This is right concept used and works for samba shares and > interactive logons directly to the server) > > > > There is a directory /test with the only acl TESTGROUP:rwx > > > > This works: > > su - $user > > cd /work > > mkdir test > > > > So all right's a resolved correctly > > > > This works not > > exportfs *:/work -o all_squash,anonuid=12345,anongid=12345 > > > > uid of $user is 12345 > > > > mount /work on some host on /mnt > > cd /mnt on the nfs client results in Permission denied > > > > setting an acl: > > setfacl -m u:$User:rwx > > > > results in cd /mnt and ls is working. > > > > my question is now: > > is the nfsd unable to resolv winbindd local groups? > > > > Mit freundlichem Gruss, > > > > Dirk Laurenz > > Systems Engineer > > S DE SE PS N/O > > Fujitsu Siemens Computers > > Hildesheimer Strasse 25 > > 30880 Laatzen > > Germany > > > > Telephone: +49 511 84 89 18 08 > > Telefax: +49 511 84 89 25 18 08 > > Mobile: +49 170 22 10 781 > > Email: mailto: dirk.laurenz@fujitsu-siemens.com > > Internet: http://www.fujitsu-siemens.com > > Firmenangaben: http://www.fujitsu-siemens.de/imprint.html > > > > > > > > > > > > -------------------------------------------------------------- > ----------- > This SF.net email is sponsored by DB2 Express > Download DB2 Express C - the FREE version of DB2 express and take > control of your XML. No limits. Just data. Click to get it now. > http://sourceforge.net/powerbar/db2/ > _______________________________________________ > NFS maillist - NFS@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/nfs > ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ NFS maillist - NFS@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: NFS and Samba Winbindd 2007-06-15 9:58 ` Laurenz, Dirk @ 2007-06-20 5:31 ` Laurenz, Dirk 2007-06-20 14:18 ` Trond Myklebust 0 siblings, 1 reply; 11+ messages in thread From: Laurenz, Dirk @ 2007-06-20 5:31 UTC (permalink / raw) To: Laurenz, Dirk, Chris Osicki, nfs@lists.sourceforge.net Hello List, the problem still persists. Does anyone have an idea? Can i increase the debug level a little bit to see, what the nfsd is doing to resolv memberships? > -----Original Message----- > From: nfs-bounces@lists.sourceforge.net > [mailto:nfs-bounces@lists.sourceforge.net] On Behalf Of Laurenz, Dirk > Sent: Friday, June 15, 2007 11:58 AM > To: Chris Osicki; nfs@lists.sourceforge.net > Subject: Re: [NFS] NFS and Samba Winbindd > > Hi, > > sorry, i mistyped this in the email on the server it is > correctly typed > > > -----Original Message----- > > From: nfs-bounces@lists.sourceforge.net > > [mailto:nfs-bounces@lists.sourceforge.net] On Behalf Of Chris Osicki > > Sent: Friday, June 15, 2007 11:44 AM > > To: nfs@lists.sourceforge.net > > Subject: Re: [NFS] NFS and Samba Winbindd > > > > > > > > Hi > > > > Shouldn't it read winbind instead of winbindd in nsswitch.conf? > > > > Regards, > > Chris > > > > On Fri, 15 Jun 2007 08:50:36 +0200 > > "Laurenz, Dirk" <Dirk.Laurenz@fujitsu-siemens.com> wrote: > > > > > Hi, > > > > > > i have the following problem, which i'm not able to solve. > > > > > > The setup is as follows: > > > > > > Linux 2.6 Kernel (SLES9-32bit, Post SP3) > > > nssswitch.conf > > > [...] > > > groups: files ldap windbindd > > > [...] > > > > > > A user in a an global samba/ldap group. This group is in a > > local winbindgroup TESTGROUP. > > > (This is right concept used and works for samba shares and > > interactive logons directly to the server) > > > > > > There is a directory /test with the only acl TESTGROUP:rwx > > > > > > This works: > > > su - $user > > > cd /work > > > mkdir test > > > > > > So all right's a resolved correctly > > > > > > This works not > > > exportfs *:/work -o all_squash,anonuid=12345,anongid=12345 > > > > > > uid of $user is 12345 > > > > > > mount /work on some host on /mnt > > > cd /mnt on the nfs client results in Permission denied > > > > > > setting an acl: > > > setfacl -m u:$User:rwx > > > > > > results in cd /mnt and ls is working. > > > > > > my question is now: > > > is the nfsd unable to resolv winbindd local groups? > > > > > > Mit freundlichem Gruss, > > > > > > Dirk Laurenz > > > Systems Engineer > > > S DE SE PS N/O > > > Fujitsu Siemens Computers > > > Hildesheimer Strasse 25 > > > 30880 Laatzen > > > Germany > > > > > > Telephone: +49 511 84 89 18 08 > > > Telefax: +49 511 84 89 25 18 08 > > > Mobile: +49 170 22 10 781 > > > Email: mailto: dirk.laurenz@fujitsu-siemens.com > > > Internet: http://www.fujitsu-siemens.com > > > Firmenangaben: http://www.fujitsu-siemens.de/imprint.html > > > > > > > > > > > > > > > > > > > -------------------------------------------------------------- > > ----------- > > This SF.net email is sponsored by DB2 Express > > Download DB2 Express C - the FREE version of DB2 express and take > > control of your XML. No limits. Just data. Click to get it now. > > http://sourceforge.net/powerbar/db2/ > > _______________________________________________ > > NFS maillist - NFS@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/nfs > > > > -------------------------------------------------------------- > ----------- > This SF.net email is sponsored by DB2 Express > Download DB2 Express C - the FREE version of DB2 express and take > control of your XML. No limits. Just data. Click to get it now. > http://sourceforge.net/powerbar/db2/ > _______________________________________________ > NFS maillist - NFS@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/nfs > ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ NFS maillist - NFS@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: NFS and Samba Winbindd 2007-06-20 5:31 ` Laurenz, Dirk @ 2007-06-20 14:18 ` Trond Myklebust 0 siblings, 0 replies; 11+ messages in thread From: Trond Myklebust @ 2007-06-20 14:18 UTC (permalink / raw) To: Laurenz, Dirk; +Cc: Chris Osicki, nfs@lists.sourceforge.net On Wed, 2007-06-20 at 07:31 +0200, Laurenz, Dirk wrote: > Hello List, > > the problem still persists. Does anyone have an idea? > Can i increase the debug level a little bit to see, what > the nfsd is doing to resolv memberships? Do you have /lib/libnss_winbind.so installed, have you set up smb.conf correctly, logged into the domain and started winbind? (see the full description in "man winbind"). If it is all set up correctly, then you should be able to type getent group TESTGROUP on the command line, and see the group TESTGROUP being resolved to the correct Windoze group entry. Trond > > -----Original Message----- > > From: nfs-bounces@lists.sourceforge.net > > [mailto:nfs-bounces@lists.sourceforge.net] On Behalf Of Laurenz, Dirk > > Sent: Friday, June 15, 2007 11:58 AM > > To: Chris Osicki; nfs@lists.sourceforge.net > > Subject: Re: [NFS] NFS and Samba Winbindd > > > > Hi, > > > > sorry, i mistyped this in the email on the server it is > > correctly typed > > > > > -----Original Message----- > > > From: nfs-bounces@lists.sourceforge.net > > > [mailto:nfs-bounces@lists.sourceforge.net] On Behalf Of Chris Osicki > > > Sent: Friday, June 15, 2007 11:44 AM > > > To: nfs@lists.sourceforge.net > > > Subject: Re: [NFS] NFS and Samba Winbindd > > > > > > > > > > > > Hi > > > > > > Shouldn't it read winbind instead of winbindd in nsswitch.conf? > > > > > > Regards, > > > Chris > > > > > > On Fri, 15 Jun 2007 08:50:36 +0200 > > > "Laurenz, Dirk" <Dirk.Laurenz@fujitsu-siemens.com> wrote: > > > > > > > Hi, > > > > > > > > i have the following problem, which i'm not able to solve. > > > > > > > > The setup is as follows: > > > > > > > > Linux 2.6 Kernel (SLES9-32bit, Post SP3) > > > > nssswitch.conf > > > > [...] > > > > groups: files ldap windbindd > > > > [...] > > > > > > > > A user in a an global samba/ldap group. This group is in a > > > local winbindgroup TESTGROUP. > > > > (This is right concept used and works for samba shares and > > > interactive logons directly to the server) > > > > > > > > There is a directory /test with the only acl TESTGROUP:rwx > > > > > > > > This works: > > > > su - $user > > > > cd /work > > > > mkdir test > > > > > > > > So all right's a resolved correctly > > > > > > > > This works not > > > > exportfs *:/work -o all_squash,anonuid=12345,anongid=12345 > > > > > > > > uid of $user is 12345 > > > > > > > > mount /work on some host on /mnt > > > > cd /mnt on the nfs client results in Permission denied > > > > > > > > setting an acl: > > > > setfacl -m u:$User:rwx > > > > > > > > results in cd /mnt and ls is working. > > > > > > > > my question is now: > > > > is the nfsd unable to resolv winbindd local groups? > > > > > > > > Mit freundlichem Gruss, > > > > > > > > Dirk Laurenz > > > > Systems Engineer > > > > S DE SE PS N/O > > > > Fujitsu Siemens Computers > > > > Hildesheimer Strasse 25 > > > > 30880 Laatzen > > > > Germany > > > > > > > > Telephone: +49 511 84 89 18 08 > > > > Telefax: +49 511 84 89 25 18 08 > > > > Mobile: +49 170 22 10 781 > > > > Email: mailto: dirk.laurenz@fujitsu-siemens.com > > > > Internet: http://www.fujitsu-siemens.com > > > > Firmenangaben: http://www.fujitsu-siemens.de/imprint.html > > > > > > > > > > > > > > > > > > > > > > > > > > -------------------------------------------------------------- > > > ----------- > > > This SF.net email is sponsored by DB2 Express > > > Download DB2 Express C - the FREE version of DB2 express and take > > > control of your XML. No limits. Just data. Click to get it now. > > > http://sourceforge.net/powerbar/db2/ > > > _______________________________________________ > > > NFS maillist - NFS@lists.sourceforge.net > > > https://lists.sourceforge.net/lists/listinfo/nfs > > > > > > > -------------------------------------------------------------- > > ----------- > > This SF.net email is sponsored by DB2 Express > > Download DB2 Express C - the FREE version of DB2 express and take > > control of your XML. No limits. Just data. Click to get it now. > > http://sourceforge.net/powerbar/db2/ > > _______________________________________________ > > NFS maillist - NFS@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/nfs > > > > ------------------------------------------------------------------------- > This SF.net email is sponsored by DB2 Express > Download DB2 Express C - the FREE version of DB2 express and take > control of your XML. No limits. Just data. Click to get it now. > http://sourceforge.net/powerbar/db2/ > _______________________________________________ > NFS maillist - NFS@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/nfs ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ NFS maillist - NFS@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [KJ] [PATCH]is_power_of_2-nfs/internal.h 2007-06-14 8:20 ` [KJ] [PATCH]is_power_of_2-nfs/internal.h vignesh babu @ 2007-06-14 15:59 ` Yoann Padioleau -1 siblings, 0 replies; 11+ messages in thread From: Yoann Padioleau @ 2007-06-14 15:59 UTC (permalink / raw) To: vignesh.babu; +Cc: neilb, Kernel Janitors List, nfs vignesh babu <vignesh.babu@wipro.com> writes: > Replacing (n & (n-1)) in the context of power of 2 checks > with is_power_of_2 > > Signed-off-by: vignesh babu <vignesh.babu@wipro.com> > --- > diff --git a/fs/nfs/internal.h b/fs/nfs/internal.h > index ad2b40d..5dca432 100644 > --- a/fs/nfs/internal.h > +++ b/fs/nfs/internal.h > @@ -3,6 +3,7 @@ > */ > > #include <linux/mount.h> > +#include <linux/log2.h> > > struct nfs_string; > struct nfs_mount_data; > @@ -167,7 +168,7 @@ static inline > unsigned long nfs_block_bits(unsigned long bsize, unsigned char *nrbitsp) > { > /* make sure blocksize is a power of two */ > - if ((bsize & (bsize - 1)) || nrbitsp) { > + if (is_power_of_2(bsize) || nrbitsp) { Did I miss something but why in this case it's not + if (!is_power_of_2(bsize) || nrbitsp) { ? > unsigned char nrbits; > > for (nrbits = 31; nrbits && !(bsize & (1 << nrbits)); nrbits--) > > -- > Vignesh Babu BM > _____________________________________________________________ > "Why is it that every time I'm with you, makes me believe in magic?" > > _______________________________________________ > Kernel-janitors mailing list > Kernel-janitors@lists.linux-foundation.org > https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors _______________________________________________ Kernel-janitors mailing list Kernel-janitors@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [KJ] [PATCH]is_power_of_2-nfs/internal.h @ 2007-06-14 15:59 ` Yoann Padioleau 0 siblings, 0 replies; 11+ messages in thread From: Yoann Padioleau @ 2007-06-14 15:59 UTC (permalink / raw) To: vignesh.babu; +Cc: neilb, Kernel Janitors List, nfs vignesh babu <vignesh.babu@wipro.com> writes: > Replacing (n & (n-1)) in the context of power of 2 checks > with is_power_of_2 > > Signed-off-by: vignesh babu <vignesh.babu@wipro.com> > --- > diff --git a/fs/nfs/internal.h b/fs/nfs/internal.h > index ad2b40d..5dca432 100644 > --- a/fs/nfs/internal.h > +++ b/fs/nfs/internal.h > @@ -3,6 +3,7 @@ > */ > > #include <linux/mount.h> > +#include <linux/log2.h> > > struct nfs_string; > struct nfs_mount_data; > @@ -167,7 +168,7 @@ static inline > unsigned long nfs_block_bits(unsigned long bsize, unsigned char *nrbitsp) > { > /* make sure blocksize is a power of two */ > - if ((bsize & (bsize - 1)) || nrbitsp) { > + if (is_power_of_2(bsize) || nrbitsp) { Did I miss something but why in this case it's not + if (!is_power_of_2(bsize) || nrbitsp) { ? > unsigned char nrbits; > > for (nrbits = 31; nrbits && !(bsize & (1 << nrbits)); nrbits--) > > -- > Vignesh Babu BM > _____________________________________________________________ > "Why is it that every time I'm with you, makes me believe in magic?" > > _______________________________________________ > Kernel-janitors mailing list > Kernel-janitors@lists.linux-foundation.org > https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ NFS maillist - NFS@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2007-06-20 14:18 UTC | newest] Thread overview: 11+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2007-06-14 8:08 [PATCH]is_power_of_2-nfs/internal.h vignesh babu 2007-06-14 8:20 ` [KJ] [PATCH]is_power_of_2-nfs/internal.h vignesh babu 2007-06-14 15:45 ` [KJ] Re: [NFS] [PATCH]is_power_of_2-nfs/internal.h Trond Myklebust 2007-06-14 15:45 ` [PATCH]is_power_of_2-nfs/internal.h Trond Myklebust 2007-06-15 6:50 ` NFS and Samba Winbindd Laurenz, Dirk 2007-06-15 9:44 ` Chris Osicki 2007-06-15 9:58 ` Laurenz, Dirk 2007-06-20 5:31 ` Laurenz, Dirk 2007-06-20 14:18 ` Trond Myklebust 2007-06-14 15:59 ` [KJ] [PATCH]is_power_of_2-nfs/internal.h Yoann Padioleau 2007-06-14 15:59 ` Yoann Padioleau
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.