Re: [RFC][ASoC] New device/driver arch

[Liam Girdwood <lg@opensource.wolfsonmicro.com>]

On Fri, 2007-06-15 at 10:01 -0500, Seth Forshee wrote:
> Hi Liam,
> 
> On 6/14/07, Liam Girdwood <lg@opensource.wolfsonmicro.com> wrote:
> 
> > Example machine driver for Mainstone with WM8753 is here :-
> >
> > http://opensource.wolfsonmicro.com/cgi-bin/gitweb/gitweb.cgi?p=linux-2.6-asoc;a=blob;f=sound/soc/pxa/mainstone_wm8753.c;h=a49c1c528063494aeadee26ea3e07405c3a8762e;hb=ppc-dev
> >
> > The machine driver now also does the I2C/SPI probing (instead of the
> > codec) and also does any codec IO (to better support multiple
> > controllers).
> >
> 
> The way in which the platform device is created in this file seems to
> have a problem.  The mainstone_wm8753_probe() function (along
> everything else after that point) seems to expect that the platform
> device will be encapsulated in a struct snd_soc_machine, but this
> doesn't seem to be the case since you are instantiating the device
> with platform_driver_probe().  Am I missing something?

Your right. This is a bug. Will fix.

Thanks

Liam