Re: [PATCH 4/4] Add libvdisk, and vdisk_tool

[Mark McLoughlin <markmc@redhat.com>]

Hi Ben,

On Tue, 2007-06-19 at 09:16 -0400, Ben Guthro wrote:

> diff -r 7cad1f06a7f6 tools/vdisk/vdisk_common.c

...

> +       if (vdisk->use_aio) {

...

> +               vdisk->ioctx = (io_context_t) REQUEST_ASYNC_FD;   
> +               vdisk->aio_fd = io_setup(VDISK_HASH_SZ, &vdisk->ioctx);
> +               if (vdisk->aio_fd < 0) {
> +                       VIDDBG(0, "io_setup can't get async poll ID (%s). "
> +                              " Async IO will not be available\n",
> +                               strerror(errno));
> +                       vdisk->use_aio = 0;             
> +               }

	Note that the aio and qcow blktap drivers now use the tapaio wrapper to
poll on aio events, so it'd be nice if this code did the same.

	Since the aio code isn't used by qemu, perhaps it'd be better to move
it out of libvdisk and into blktap?

Cheers,
Mark.