All of lore.kernel.org
 help / color / mirror / Atom feed
From: Soeren Sonnenburg <kernel@nn7.de>
To: Rudolf Marek <r.marek@assembler.cz>
Cc: lkml <linux-kernel@vger.kernel.org>,
	LM Sensors <lm-sensors@lm-sensors.org>
Subject: Re: [lm-sensors] [PATCH] hwmon/coretemp: Fix a broken error path
Date: Mon, 25 Jun 2007 19:35:28 +0000	[thread overview]
Message-ID: <1182800128.4674.4.camel@localhost> (raw)
In-Reply-To: <46800759.6040605@assembler.cz>

On Mon, 2007-06-25 at 20:20 +0200, Rudolf Marek wrote:
> > Hi Rudolf,
> > 
> > just one more update:
> > 
> > When I put my machine into s2ram and make it resume, one of the coretemp
> > sensors gets lost. Ahh and I am already rmmod coretemp / loading
> > microcode after resume / insmod coretemp...
> 
> Hello, If I understand correctly you unload the driver before suspend. Resume, 
> update microcode, load the driver correct?

no I did not unload the driver but rmmod it after resume before I load
the microcode.

> Please can you check dmesg if for example one core complains about bad microcode 
> version?

indeed core1 still complains. and I just now loaded the new microcode
( rmmod of coretemp before and insmod after) and voila coretemp displays
both cpu's again. So I guess the microcode reloading is done to soon
after resume...

Soeren
-- 
Sometimes, there's a moment as you're waking, when you become aware of
the real world around you, but you're still dreaming.

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

WARNING: multiple messages have this Message-ID (diff)
From: Soeren Sonnenburg <kernel@nn7.de>
To: Rudolf Marek <r.marek@assembler.cz>
Cc: lkml <linux-kernel@vger.kernel.org>,
	LM Sensors <lm-sensors@lm-sensors.org>
Subject: Re: [PATCH] hwmon/coretemp: Fix a broken error path - microcode	update fix
Date: Mon, 25 Jun 2007 21:35:28 +0200	[thread overview]
Message-ID: <1182800128.4674.4.camel@localhost> (raw)
In-Reply-To: <46800759.6040605@assembler.cz>

On Mon, 2007-06-25 at 20:20 +0200, Rudolf Marek wrote:
> > Hi Rudolf,
> > 
> > just one more update:
> > 
> > When I put my machine into s2ram and make it resume, one of the coretemp
> > sensors gets lost. Ahh and I am already rmmod coretemp / loading
> > microcode after resume / insmod coretemp...
> 
> Hello, If I understand correctly you unload the driver before suspend. Resume, 
> update microcode, load the driver correct?

no I did not unload the driver but rmmod it after resume before I load
the microcode.

> Please can you check dmesg if for example one core complains about bad microcode 
> version?

indeed core1 still complains. and I just now loaded the new microcode
( rmmod of coretemp before and insmod after) and voila coretemp displays
both cpu's again. So I guess the microcode reloading is done to soon
after resume...

Soeren
-- 
Sometimes, there's a moment as you're waking, when you become aware of
the real world around you, but you're still dreaming.

  reply	other threads:[~2007-06-25 19:35 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-16 20:43 git-current: latest coretemp changes break s2ram Soeren Sonnenburg
2007-06-16 21:17 ` [PATCH] hwmon/coretemp: Fix a broken error path Jean Delvare
2007-06-17  9:16   ` Soeren Sonnenburg
2007-06-17 17:56     ` Rudolf Marek
     [not found]       ` <1182335403.21563.99.camel@localhost>
2007-06-21 20:57         ` [lm-sensors] [PATCH] hwmon/coretemp: Fix a broken error path - Rudolf Marek
2007-06-21 20:57           ` [PATCH] hwmon/coretemp: Fix a broken error path - microcode update fix Rudolf Marek
2007-06-21 21:55           ` [lm-sensors] [PATCH] hwmon/coretemp: Fix a broken error path - Soeren Sonnenburg
2007-06-21 21:55             ` [PATCH] hwmon/coretemp: Fix a broken error path - microcode update fix Soeren Sonnenburg
2007-06-25 13:57           ` [lm-sensors] [PATCH] hwmon/coretemp: Fix a broken error path - Soeren Sonnenburg
2007-06-25 13:57             ` [PATCH] hwmon/coretemp: Fix a broken error path - microcode update fix Soeren Sonnenburg
2007-06-25 18:20             ` [lm-sensors] [PATCH] hwmon/coretemp: Fix a broken error path - Rudolf Marek
2007-06-25 18:20               ` [PATCH] hwmon/coretemp: Fix a broken error path - microcode update fix Rudolf Marek
2007-06-25 19:35               ` Soeren Sonnenburg [this message]
2007-06-25 19:35                 ` Soeren Sonnenburg
2007-06-18  7:17     ` [PATCH] hwmon/coretemp: Fix a broken error path Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1182800128.4674.4.camel@localhost \
    --to=kernel@nn7.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=r.marek@assembler.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.