From: jamal <hadi@cyberus.ca>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Patrick McHardy <kaber@trash.net>,
Zhang Rui <rui.zhang@intel.com>,
netdev@vger.kernel.org,
"linux-acpi@vger" <linux-acpi@vger.kernel.org>,
lenb@kernel.org, Thomas Graf <tgraf@suug.ch>
Subject: Re: Fwd: [PATCH] [-mm] ACPI: export ACPI events via netlink
Date: Sat, 30 Jun 2007 11:32:16 -0400 [thread overview]
Message-ID: <1183217536.5165.25.camel@localhost> (raw)
In-Reply-To: <1183129006.4089.84.camel@johannes.berg>
On Fri, 2007-29-06 at 16:56 +0200, Johannes Berg wrote:
> +static void genl_unregister_mc_group(struct genl_multicast_group *grp)
> +{
> + /*
> + * TODO: fix multicast group re-use by clearing the bit
> + * for this group in all genetlink sockets.
> + */
> + clear_bit(grp->id, mc_groups);
> + list_del(&grp->list);
I think you need a
genl_ctrl_event(CTRL_CMD_DELMCAST_GRP, family);
here? You may need to save the mcast details before you delete.
> + NLA_PUT_U32(skb, CTRL_ATTR_MCAST_GRP_ID, grp->id);
> + NLA_PUT_STRING(skb, CTRL_ATTR_MCAST_GRP_NAME,
> + grp->name);
> +
Consider my earlier suggestion to use CTRL_ATTR_MCAST_GRP which has both
id and name in one struct.
Other than that - looking good.
cheers,
jamal
next prev parent reply other threads:[~2007-06-30 15:32 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-22 9:47 [PATCH] [-mm] ACPI: export ACPI events via netlink Zhang Rui
2007-05-22 10:05 ` Samuel Ortiz
2007-05-22 10:10 ` Evgeniy Polyakov
2007-05-22 11:03 ` jamal
2007-05-23 1:17 ` Zhang Rui
2007-05-27 9:40 ` Zhang Rui
[not found] ` <4466a10705270629h31977813hd2fc8330bcd87f78@mail.gmail.com>
2007-05-27 13:34 ` Fwd: " jamal
2007-06-14 8:59 ` Zhang Rui
2007-06-14 11:28 ` jamal
2007-06-15 1:01 ` Zhang Rui
2007-06-15 10:26 ` jamal
2007-06-18 15:01 ` jamal
2007-06-19 3:32 ` Zhang Rui
2007-06-25 22:40 ` Johannes Berg
2007-06-26 13:33 ` jamal
2007-06-26 13:42 ` Johannes Berg
2007-06-27 23:24 ` jamal
2007-06-28 9:45 ` Johannes Berg
2007-06-29 11:17 ` jamal
2007-06-29 11:28 ` Johannes Berg
2007-06-29 11:48 ` jamal
2007-06-29 11:58 ` Johannes Berg
2007-06-29 11:51 ` Patrick McHardy
2007-06-29 11:59 ` Johannes Berg
2007-06-29 12:04 ` Patrick McHardy
2007-06-29 12:01 ` jamal
2007-06-29 12:09 ` Patrick McHardy
2007-06-29 12:46 ` Johannes Berg
2007-06-29 12:48 ` Patrick McHardy
2007-06-29 12:51 ` Johannes Berg
2007-06-29 13:02 ` jamal
2007-06-29 13:12 ` Patrick McHardy
2007-06-29 13:27 ` jamal
2007-06-29 13:32 ` Patrick McHardy
2007-06-29 13:13 ` Johannes Berg
2007-06-29 12:57 ` Johannes Berg
2007-06-29 13:11 ` Patrick McHardy
2007-06-29 13:15 ` Johannes Berg
2007-06-29 13:23 ` Patrick McHardy
2007-06-29 13:34 ` Johannes Berg
2007-06-29 13:44 ` Patrick McHardy
2007-06-29 13:49 ` Johannes Berg
2007-06-29 13:53 ` Patrick McHardy
2007-06-29 14:05 ` Johannes Berg
2007-06-29 14:18 ` Johannes Berg
2007-06-29 14:56 ` Johannes Berg
2007-06-30 15:32 ` jamal [this message]
2007-07-02 8:43 ` Johannes Berg
2007-07-02 12:56 ` Patrick McHardy
2007-07-02 14:34 ` Johannes Berg
2007-07-02 14:38 ` Patrick McHardy
2007-07-02 14:48 ` Johannes Berg
2007-07-02 22:12 ` Johannes Berg
2007-07-03 10:08 ` [PATCH] netlink: allocate group bitmaps dynamically Johannes Berg
2007-07-03 12:05 ` Patrick McHardy
2007-07-03 14:09 ` Johannes Berg
2007-07-03 14:11 ` Patrick McHardy
2007-07-03 14:32 ` Johannes Berg
2007-07-03 23:13 ` Johannes Berg
2007-07-03 10:09 ` [PATCH] netlink: allow removing multicast groups Johannes Berg
2007-07-03 10:10 ` [PATCH] generic netlink: dynamic " Johannes Berg
2007-07-03 11:56 ` Fwd: [PATCH] [-mm] ACPI: export ACPI events via netlink Patrick McHardy
2007-06-29 13:24 ` jamal
2007-06-29 13:11 ` jamal
2007-06-19 11:30 ` Johannes Berg
2007-06-19 16:20 ` jamal
2007-06-20 11:25 ` Johannes Berg
2007-06-21 15:47 ` jamal
2007-06-22 10:09 ` Johannes Berg
2007-06-25 17:08 ` jamal
2007-06-26 8:50 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1183217536.5165.25.camel@localhost \
--to=hadi@cyberus.ca \
--cc=johannes@sipsolutions.net \
--cc=kaber@trash.net \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.