[U-Boot-Users] [PATCH 0/3]Patchset for Ati bios emulator and Ati frambuffer driver

[U-Boot-Users] [PATCH 0/3]Patchset for Ati bios emulator and Ati frambuffer driver

[Jason Jin]

Hi, Stefan

This patchset add Ati bios emulator and Ati video card framebuffer driver to u-boot. The bios emulator and the framebuffer driver work for Ati PCI and PCIE video card. We tested the patchset on 9200 PCI card, X300, X700 and X800 PCIE card in u-boot on MPC8641HPCN board. After the video card bios finish runnig in the bios emulator, We can use the Ati framebuffer driver in u-boot, we can also use the radeon base driver in kernel directly for those Ati video card.

Thanks,
Jason

[U-Boot-Users] [PATCH 0/3]Patchset for Ati bios emulator and Ati frambuffer driver

[Wolfgang Denk]

In message <11836285951474-git-send-email-Jason.jin@freescale.com> you wrote:
> 
> This patchset add Ati bios emulator and Ati video card framebuffer driver to u-boot. The bios emulator and the framebuffer driver work for Ati PCI and PCIE video card. We tested the patchset on 9200 PCI card, X300, X700 and X800 PCIE card in u-boot on M
> PC8641HPCN board. After the video card bios finish runnig in the bios emulator, We can use the Ati framebuffer driver in u-boot, we can also use the radeon base driver in kernel directly for those Ati video card.

Please restrict your line length to < 80 characters or so when
posting, and make sure to read the patch submission rules - see
http://www.denx.de/wiki/UBoot/Patches

Ati bios emulator - Why do we need another emulator? Is the one we
have in board/MAI/bios_emulator/ not sufficient for your purposes?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
Cleverness and Style have no place in getting a project completed.
                                                  -- Tom Christiansen

[U-Boot-Users] [PATCH 0/3]Patchset for Ati bios emulator and Ati frambuffer driver

[Jin Zhengxiong-R64188]

Hi, Wolfgang,

Thanks for your feedback, Please see my inline comments.

Best Regards,
Jason

> -----Original Message-----
> From: wd at denx.de [mailto:wd at denx.de] 
> Sent: Thursday, July 05, 2007 5:54 PM
> To: Jin Zhengxiong-R64188
> Cc: sr at denx.de; u-boot-users at lists.sourceforge.net; Loeliger 
> Jon-LOELIGER
> Subject: Re: [U-Boot-Users] [PATCH 0/3]Patchset for Ati bios 
> emulator and Ati frambuffer driver 
> 
> In message 
> <11836285951474-git-send-email-Jason.jin@freescale.com> you wrote:
> > 
> > This patchset add Ati bios emulator and Ati video card framebuffer 
> > driver to u-boot. The bios emulator and the framebuffer 
> driver work for Ati PCI and PCIE video card. We tested the 
> patchset on 9200 PCI card, X300, X700 and X800 PCIE card in 
> u-boot on M PC8641HPCN board. After the video card bios 
> finish runnig in the bios emulator, We can use the Ati 
> framebuffer driver in u-boot, we can also use the radeon base 
> driver in kernel directly for those Ati video card.
> 
> Please restrict your line length to < 80 characters or so 
> when posting, and make sure to read the patch submission 
> rules - see http://www.denx.de/wiki/UBoot/Patches

Each of the two patch is a logical part and I think they should not be
split into separate part, I'll try to provide a URL for the two patches.

> Ati bios emulator - Why do we need another emulator? Is the 
> one we have in board/MAI/bios_emulator/ not sufficient for 
> your purposes?

Yes, I found there's a bios_emulator in board/MAI/bios_emulator, but
it's board specific and I can not use it directly, actually both of the
emulator come from Scitech, I tried to make it clean and clear during my
porting. On the other side, I tried to compile it for the MAI board but
compile failed.  
If other board want to use the bios emulator, I suggest moving it out
from the board and make it clean.

[U-Boot-Users] [PATCH 0/3]Patchset for Ati bios emulator and Ati frambuffer driver

[Wolfgang Denk]

Hello,

in message <CC27DED0F8F39E48A7E75FD768688B7A3E97A2@zch01exm27.fsl.freescale.net> you wrote:
> 
> > Please restrict your line length to < 80 characters or so 
> > when posting, and make sure to read the patch submission 
> > rules - see http://www.denx.de/wiki/UBoot/Patches
> 
> Each of the two patch is a logical part and I think they should not be
> split into separate part, I'll try to provide a URL for the two patches.

Well, ok, but actually this has nothing to do with the line length of
your postings on this mailing list, right?

> > Ati bios emulator - Why do we need another emulator? Is the 
> > one we have in board/MAI/bios_emulator/ not sufficient for 
> > your purposes?
> 
> Yes, I found there's a bios_emulator in board/MAI/bios_emulator, but
> it's board specific and I can not use it directly, actually both of the
> emulator come from Scitech, I tried to make it clean and clear during my
> porting. On the other side, I tried to compile it for the MAI board but
> compile failed.  
> If other board want to use the bios emulator, I suggest moving it out
> from the board and make it clean.

Can you please do that, then? It's the logic consequence.  I  do  not
want  to  add  another  800  kB of code for a feature that is already
present. If cleanup and.or generalization is  needed,  then  this  is
what  has  to  be done. If you find that your solution is better than
the existing one, you have to prove that and replace the old one.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The only thing necessary for the triumph of evil is for good  men  to
do nothing.                                            - Edmund Burke

[U-Boot-Users] [PATCH 0/3]Patchset for Ati bios emulator and Ati frambuffer driver

[Jin Zhengxiong-R64188]

 

> -----Original Message-----
> From: wd at denx.de [mailto:wd at denx.de] 
> Sent: Friday, July 06, 2007 2:56 AM
> To: Jin Zhengxiong-R64188
> Cc: u-boot-users at lists.sourceforge.net
> Subject: Re: [U-Boot-Users] [PATCH 0/3]Patchset for Ati bios 
> emulator and Ati frambuffer driver 
> 
> Hello,
> 
> in message 
> <CC27DED0F8F39E48A7E75FD768688B7A3E97A2@zch01exm27.fsl.freesca
> le.net> you wrote:
> > 
> > > Please restrict your line length to < 80 characters or so when 
> > > posting, and make sure to read the patch submission rules - see 
> > > http://www.denx.de/wiki/UBoot/Patches
> > 
> > Each of the two patch is a logical part and I think they 
> should not be 
> > split into separate part, I'll try to provide a URL for the 
> two patches.
> 
> Well, ok, but actually this has nothing to do with the line 
> length of your postings on this mailing list, right?
 
Ok, I'll try to fix this next time. And I'm trying to find a place to
put the patch.

> > > Ati bios emulator - Why do we need another emulator? Is 
> the one we 
> > > have in board/MAI/bios_emulator/ not sufficient for your purposes?
> > 
> > Yes, I found there's a bios_emulator in 
> board/MAI/bios_emulator, but 
> > it's board specific and I can not use it directly, actually both of 
> > the emulator come from Scitech, I tried to make it clean and clear 
> > during my porting. On the other side, I tried to compile it for the 
> > MAI board but compile failed.
> > If other board want to use the bios emulator, I suggest 
> moving it out 
> > from the board and make it clean.
> 
> Can you please do that, then? It's the logic consequence.  I  
> do  not want  to  add  another  800  kB of code for a feature 
> that is already present. If cleanup and.or generalization is  
> needed,  then  this  is what  has  to  be done. If you find 
> that your solution is better than the existing one, you have 
> to prove that and replace the old one.

Actually, The BIOS emulator I posted and the BIOS emulator in board/MAI
are both come from SciTech. But as it's under the MAI board,  my
understand is if I want to use it for different platforms, I need to
move it out and try to cleanup it and make it pass compile and make it
work (The BIOS emulator under MAI board is about 6M and I don't know if
some files such as the bat files and win32 directory is useful for
u-boot). 

So I think it can be interpretated as I've moved out and cleanup the
BIOS emulator from MAI board. But I haven't MAI board in hand and can
not test if the board can work normally after remove the bios_emulator.
So I did not send a patch to remove the code in the board/MAI. I can
only test this 'moved out' BIOS emulator on the board in hand such as
85xx,86xx and 7448 board. If I can contact with the maintainer of the
MAI board. Maybe she or he can help to test this.

Thanks
Jason

[U-Boot-Users] [PATCH 0/3]Patchset for Ati bios emulator and Ati frambuffer driver

[Wolfgang Denk]

Hello,

in message <CC27DED0F8F39E48A7E75FD768688B7A3E9859@zch01exm27.fsl.freescale.net> you wrote:
>
> Actually, The BIOS emulator I posted and the BIOS emulator in board/MAI
> are both come from SciTech. But as it's under the MAI board,  my

That was my impression that it's based on the same code. Which is why
I think that needs to be cleaned up.

> understand is if I want to use it for different platforms, I need to
> move it out and try to cleanup it and make it pass compile and make it
> work (The BIOS emulator under MAI board is about 6M and I don't know if
> some files such as the bat files and win32 directory is useful for
> u-boot). 

I think you are right - there is some crap in this directory.

> So I think it can be interpretated as I've moved out and cleanup the
> BIOS emulator from MAI board. But I haven't MAI board in hand and can
> not test if the board can work normally after remove the bios_emulator.

Understood. Well, but at least we can try and (1) remove  the  (board
specific)  BIOS  emulator from the MAI board directory and (2) switch
to use your commin implementation yet.

If you can proivide a patch that the MAI still  compiles  and  links,
that  wouldbe  a  good  base  that other users could test it - I hope
there are still MAI users around? [Otherwise we can simply remove the
whole board support? ;-) ]

> So I did not send a patch to remove the code in the board/MAI. I can
> only test this 'moved out' BIOS emulator on the board in hand such as
> 85xx,86xx and 7448 board. If I can contact with the maintainer of the
> MAI board. Maybe she or he can help to test this.

That's what I hope, too. Alternatively, at least some MAI users would
be able to run some tests.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Don't think; let the machine do it for you!"        - E. C. Berkeley

[U-Boot-Users] [PATCH 0/3]Patchset for Ati bios emulator and Ati frambuffer driver

[Jin Zhengxiong-R64188]

 
> Understood. Well, but at least we can try and (1) remove  the  (board
> specific)  BIOS  emulator from the MAI board directory and 
> (2) switch to use your commin implementation yet.
> 
> If you can proivide a patch that the MAI still  compiles  and 
>  links, that  wouldbe  a  good  base  that other users could 
> test it - I hope there are still MAI users around? [Otherwise 
> we can simply remove the whole board support? ;-) ]

I'll try to found out a way to minimize the impaction to MAI board when
the 
bios_emulator was moved out.  

Is there someone using this board and can afford some information about
the board and help to test?  Seems like it's a rather old board.

Best Regards,
Jason