From: Hollis Blanchard <hollis@penguinppc.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: GRUB_IEEE1275_FLAG_NO_PARTITION_0
Date: Tue, 10 Jul 2007 15:26:43 -0500 [thread overview]
Message-ID: <1184099203.9495.70.camel@basalt> (raw)
In-Reply-To: <20070709150550.GA13390@aragorn>
On Mon, 2007-07-09 at 17:05 +0200, Robert Millan wrote:
> What's the point of GRUB_IEEE1275_FLAG_NO_PARTITION_0 ? We have code that
> checks this flag, but nobody initialises it:
>
> disk/ieee1275/ofdisk.c: if (! grub_ieee1275_test_flag (GRUB_IEEE1275_FLAG_NO_PARTITION_0))
> include/grub/ieee1275/ieee1275.h: GRUB_IEEE1275_FLAG_NO_PARTITION_0,
In IEEE1275, partition 0 (as in "disk:0") means "the whole disk".
However, CodeGen-based firmware (that means Genesi) have a bug where
partition 0 is actually disk partition 1. In that case, to access the
whole disk, GRUB must open "disk" instead of "disk:0".
I have no idea how the initialization got lost; it should be initialized
in the same place that the other flags are. Checking cvs history may be
in order.
-Hollis
next prev parent reply other threads:[~2007-07-10 20:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-09 15:05 GRUB_IEEE1275_FLAG_NO_PARTITION_0 Robert Millan
2007-07-10 20:26 ` Hollis Blanchard [this message]
2007-07-13 22:31 ` GRUB_IEEE1275_FLAG_NO_PARTITION_0 Robert Millan
2007-07-22 9:15 ` GRUB_IEEE1275_FLAG_NO_PARTITION_0 Robert Millan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1184099203.9495.70.camel@basalt \
--to=hollis@penguinppc.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.