From: Len Brown <len.brown@intel.com>
To: linux-acpi@vger.kernel.org
Cc: Thomas Renninger <trenn@suse.de>, Len Brown <len.brown@intel.com>
Subject: [PATCH 76/77] ACPI: create CONFIG_ACPI_DEBUG_FUNC_TRACE
Date: Sun, 22 Jul 2007 05:15:01 -0400 [thread overview]
Message-ID: <11850957811573-git-send-email-len.brown@intel.com> (raw)
Message-ID: <798d91039849486c7a4f1a458a5680cb55a65408.1185095456.git.len.brown@intel.com> (raw)
In-Reply-To: <11850957801755-git-send-email-len.brown@intel.com>
In-Reply-To: <a1f0eff21edac1bd87e397f56c4258b9611b5a50.1185095456.git.len.brown@intel.com>
From: Thomas Renninger <trenn@suse.de>
Split ACPI_DEBUG into function trace enabled and not enabled.
Function trace is most of the ACPI_DEBUG costs, but is
not much of use for kernel ACPI debugging.
Size of kernel image increased on test compile:
+ 48k (Full ACPI_DEBUG)
+ 35k (ACPI_DEBUG with function trace compiled out)
Performance without function trace is also much better.
Also remove ACPI_LV_DEBUG_OBJECT from default debug level as
a lot vendors let Store (value, debug) in their code and this
might confuse users when it pops up in syslog.
Signed-off-by: Thomas Renninger <trenn@suse.de>
Signed-off-by: Len Brown <len.brown@intel.com>
---
drivers/acpi/Kconfig | 8 ++++++++
include/acpi/acmacros.h | 23 +++++++++++++++++++++++
include/acpi/acoutput.h | 4 ++--
3 files changed, 33 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
index 139f41f..1121a1f 100644
--- a/drivers/acpi/Kconfig
+++ b/drivers/acpi/Kconfig
@@ -280,6 +280,14 @@ config ACPI_DEBUG
of verbosity. Saying Y enables these statements. This will increase
your kernel size by around 50K.
+config ACPI_DEBUG_FUNC_TRACE
+ bool "Additionally enable ACPI function tracing"
+ default n
+ depends on ACPI_DEBUG
+ help
+ ACPI Debug Statements slow down ACPI processing. Function trace
+ is about half of the penalty and is rarely useful.
+
config ACPI_EC
bool
default y
diff --git a/include/acpi/acmacros.h b/include/acpi/acmacros.h
index 8948a64..c22f6da 100644
--- a/include/acpi/acmacros.h
+++ b/include/acpi/acmacros.h
@@ -486,6 +486,8 @@
#define ACPI_FUNCTION_NAME(name)
#endif
+#ifdef DEBUG_FUNC_TRACE
+
#define ACPI_FUNCTION_TRACE(a) ACPI_FUNCTION_NAME(a) \
acpi_ut_trace(ACPI_DEBUG_PARAMETERS)
#define ACPI_FUNCTION_TRACE_PTR(a,b) ACPI_FUNCTION_NAME(a) \
@@ -563,6 +565,27 @@
#endif /* ACPI_SIMPLE_RETURN_MACROS */
+#else /* !DEBUG_FUNC_TRACE */
+
+#define ACPI_FUNCTION_TRACE(a)
+#define ACPI_FUNCTION_TRACE_PTR(a,b)
+#define ACPI_FUNCTION_TRACE_U32(a,b)
+#define ACPI_FUNCTION_TRACE_STR(a,b)
+#define ACPI_FUNCTION_EXIT
+#define ACPI_FUNCTION_STATUS_EXIT(s)
+#define ACPI_FUNCTION_VALUE_EXIT(s)
+#define ACPI_FUNCTION_TRACE(a)
+#define ACPI_FUNCTION_ENTRY()
+
+#define return_VOID return
+#define return_ACPI_STATUS(s) return(s)
+#define return_VALUE(s) return(s)
+#define return_UINT8(s) return(s)
+#define return_UINT32(s) return(s)
+#define return_PTR(s) return(s)
+
+#endif /* DEBUG_FUNC_TRACE */
+
/* Conditional execution */
#define ACPI_DEBUG_EXEC(a) a
diff --git a/include/acpi/acoutput.h b/include/acpi/acoutput.h
index 7812267..c090a8b 100644
--- a/include/acpi/acoutput.h
+++ b/include/acpi/acoutput.h
@@ -178,8 +178,8 @@
/* Defaults for debug_level, debug and normal */
-#define ACPI_DEBUG_DEFAULT (ACPI_LV_INIT | ACPI_LV_WARN | ACPI_LV_ERROR | ACPI_LV_DEBUG_OBJECT)
-#define ACPI_NORMAL_DEFAULT (ACPI_LV_INIT | ACPI_LV_WARN | ACPI_LV_ERROR | ACPI_LV_DEBUG_OBJECT)
+#define ACPI_DEBUG_DEFAULT (ACPI_LV_INIT | ACPI_LV_WARN | ACPI_LV_ERROR)
+#define ACPI_NORMAL_DEFAULT (ACPI_LV_INIT | ACPI_LV_WARN | ACPI_LV_ERROR)
#define ACPI_DEBUG_ALL (ACPI_LV_AML_DISASSEMBLE | ACPI_LV_ALL_EXCEPTIONS | ACPI_LV_ALL)
#endif /* __ACOUTPUT_H__ */
--
1.5.3.rc2.22.g69a9b
next prev parent reply other threads:[~2007-07-22 9:16 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-22 9:13 ACPI patches for 2.6.23 Len Brown
2007-07-22 9:13 ` [PATCH 01/77] ACPI: battery: make internal names consistent with battery "state" Len Brown
2007-07-22 9:13 ` Len Brown
2007-07-22 9:13 ` [PATCH 02/77] ACPI: Cache battery status instead of re-evaluating AML Len Brown
2007-07-22 9:13 ` Len Brown
2007-07-22 9:13 ` [PATCH 03/77] ACPI: battery: Lindent Len Brown
2007-07-22 9:13 ` Len Brown
2007-07-22 9:13 ` [PATCH 04/77] process reading battery status hangs Len Brown
2007-07-22 9:13 ` Len Brown
2007-07-22 9:13 ` [PATCH 05/77] ACPI: video: output switch sysfs support Len Brown
2007-07-22 9:13 ` Len Brown
2007-07-22 9:13 ` [PATCH 06/77] ACPI: dock: cleanup the uid patch Len Brown
2007-07-22 9:13 ` Len Brown
2007-07-22 9:13 ` [PATCH 07/77] ACPI: dock: fix opps after dock driver fails to initialize Len Brown
2007-07-22 9:13 ` Len Brown
2007-07-22 9:13 ` [PATCH 08/77] ACPI: dock: use dynamically allocated platform device Len Brown
2007-07-22 9:13 ` Len Brown
2007-07-22 9:13 ` [PATCH 09/77] ACPI: dock: add immediate_undock option Len Brown
2007-07-22 9:13 ` Len Brown
2007-07-22 9:13 ` [PATCH 10/77] ACPI: dock: unsuppress uevents Len Brown
2007-07-22 9:13 ` Len Brown
2007-07-22 9:13 ` [PATCH 11/77] ACPI: dock: send envp with uevent Len Brown
2007-07-22 9:13 ` Len Brown
2007-07-22 9:13 ` [PATCH 12/77] ACPI: bay: unsuppress uevents Len Brown
2007-07-22 9:13 ` Len Brown
2007-07-22 9:13 ` [PATCH 13/77] ACPI: battery: syntax cleanup Len Brown
2007-07-22 9:13 ` Len Brown
2007-07-22 9:13 ` [PATCH 14/77] ACPI: add ACPI 3.0 _TPC _TSS _PTC throttling support Len Brown
2007-07-22 9:13 ` Len Brown
2007-07-22 9:14 ` [PATCH 15/77] ACPI: Lindent processor throttling code Len Brown
2007-07-22 9:14 ` Len Brown
2007-07-22 9:14 ` [PATCH 16/77] ACPI: bay: send envp with uevent Len Brown
2007-07-22 9:14 ` Len Brown
2007-07-22 9:14 ` [PATCH 17/77] ACPI: Remove Dell Optiplex GX240 from the ACPI blacklist Len Brown
2007-07-22 9:14 ` Len Brown
2007-07-22 9:14 ` [PATCH 18/77] ACPI: disable _OSI(Linux) by default Len Brown
2007-07-22 9:14 ` Len Brown
2007-07-22 9:14 ` [PATCH 19/77] ACPI: Discard invalid elements in _PSS package Len Brown
2007-07-22 9:14 ` Len Brown
2007-07-22 9:14 ` [PATCH 20/77] ACPI: asus_acpi: Do not load if no device has been found Len Brown
2007-07-22 9:14 ` Len Brown
2007-07-22 9:14 ` [PATCH 21/77] ACPI: update MAINTAINERS for EC and battery Len Brown
2007-07-22 9:14 ` Len Brown
2007-07-22 9:14 ` [PATCH 22/77] ACPI EC: Re-factor EC space handler to avoid using label/goto for cycle Len Brown
2007-07-22 9:14 ` Len Brown
2007-07-22 9:14 ` [PATCH 23/77] ACPI EC: drop usage of ACPI_DEBUG_PRINT as too heavy weight Len Brown
2007-07-22 9:14 ` Len Brown
2007-07-22 9:14 ` [PATCH 24/77] ACPI EC: Add support for non-AML EC query handlers Len Brown
2007-07-22 9:14 ` Len Brown
2007-07-22 9:14 ` [PATCH 25/77] ACPI: sbs: probe smart battery vis SMBus controller Len Brown
2007-07-22 9:14 ` Len Brown
2007-07-22 9:14 ` [PATCH 26/77] ACPI: static Len Brown
2007-07-22 9:14 ` Len Brown
2007-07-22 9:14 ` [PATCH 27/77] " Len Brown
2007-07-22 9:14 ` Len Brown
2007-07-22 9:14 ` [PATCH 28/77] ACPI: delete cmdline documentation for deleted hotkey code Len Brown
2007-07-22 9:14 ` Len Brown
2007-07-22 9:14 ` [PATCH 29/77] ACPI video: Don't export sysfs backlight interface if query _BCL fail Len Brown
2007-07-22 9:14 ` Len Brown
2007-07-22 9:14 ` [PATCH 30/77] ACPI: Use menuconfig objects Len Brown
2007-07-22 9:14 ` Len Brown
2007-07-22 9:14 ` [PATCH 32/77] ACPICA: Update _OSI string list Len Brown
2007-07-22 9:14 ` Len Brown
2007-07-22 9:14 ` [PATCH 33/77] ACPICA: Changes for Cygwin compatibility Len Brown
2007-07-22 9:14 ` Len Brown
2007-07-22 9:14 ` [PATCH 34/77] ACPICA: Fixed possible corruption of global GPE list Len Brown
2007-07-22 9:14 ` Len Brown
2007-07-22 9:14 ` [PATCH 35/77] ACPICA: Clear reserved fields for incoming ACPI 1.0 FADTs Len Brown
2007-07-22 9:14 ` Len Brown
2007-07-22 9:14 ` [PATCH 36/77] ACPI: Export events via generic netlink Len Brown
2007-07-22 9:14 ` Len Brown
2007-07-22 9:14 ` [PATCH 37/77] ACPI: netlink: remove unnecessary EXPORT_SYMBOL Len Brown
2007-07-22 9:14 ` Len Brown
2007-07-22 9:14 ` [PATCH 38/77] ACPI: dock: fix oops when _DCK evaluation fails Len Brown
2007-07-22 9:14 ` Len Brown
2007-07-22 9:14 ` [PATCH 39/77] ACPICA: fix memory leak in acpi_ev_pci_config_region_setup() error path Len Brown
2007-07-22 9:14 ` Len Brown
2007-07-22 9:14 ` [PATCH 40/77] ACPI: Enable C3 even when PM2_control is zero Len Brown
2007-07-22 9:14 ` Len Brown
2007-07-22 9:14 ` [PATCH 41/77] ACPI: thinkpad-acpi: add DMI-based modalias Len Brown
2007-07-22 9:14 ` Len Brown
2007-07-22 9:14 ` [PATCH 42/77] ACPI: thinkpad-acpi: remove all uneeded initializers Len Brown
2007-07-22 9:14 ` Len Brown
2007-07-22 9:14 ` [PATCH 43/77] ACPI: thinkpad-acpi: update information on T43 thermal sensor 0xc1 Len Brown
2007-07-22 9:14 ` Len Brown
2007-07-22 9:14 ` [PATCH 44/77] ACPI: thinkpad-acpi: enable more hotkeys Len Brown
2007-07-22 9:14 ` Len Brown
2007-07-22 9:14 ` [PATCH 45/77] ACPI: thinkpad-acpi: export hotkey maximum masks Len Brown
2007-07-22 9:14 ` Len Brown
2007-07-22 9:14 ` [PATCH 46/77] ACPI: thinkpad-acpi: export to sysfs the state of the radio slider switch Len Brown
2007-07-22 9:14 ` Len Brown
2007-07-22 9:14 ` [PATCH 47/77] ACPI: thinkpad-acpi: checkpoint sysfs interface version due to hotkey Len Brown
2007-07-22 9:14 ` Len Brown
2007-07-22 9:14 ` [PATCH 48/77] ACPI: thinkpad-acpi: update CMOS commands documentation Len Brown
2007-07-22 9:14 ` Len Brown
2007-07-22 9:14 ` [PATCH 49/77] ACPI: thinkpad-acpi: register input device Len Brown
2007-07-22 9:14 ` Len Brown
2007-07-22 9:14 ` [PATCH 50/77] ACPI: thinkpad-acpi: add input device support to hotkey subdriver Len Brown
2007-07-22 9:14 ` Len Brown
2007-07-22 9:14 ` [PATCH 51/77] ACPI: thinkpad-acpi: make the input event mode the default Len Brown
2007-07-22 9:14 ` Len Brown
2007-07-22 9:14 ` [PATCH 52/77] ACPI: thinkpad-acpi: add power-management handler capability Len Brown
2007-07-22 9:14 ` Len Brown
2007-07-22 9:14 ` [PATCH 53/77] ACPI: thinkpad-acpi: export EV_SW SW_RADIO events Len Brown
2007-07-22 9:14 ` Len Brown
2007-07-22 9:14 ` [PATCH 54/77] ACPI: thinkpad-acpi: checkpoint sysfs interface version due to input layer Len Brown
2007-07-22 9:14 ` Len Brown
2007-07-22 9:14 ` [PATCH 55/77] ACPI: thinkpad-acpi: rename pci HID constant Len Brown
2007-07-22 9:14 ` Len Brown
2007-07-22 9:14 ` [PATCH 56/77] ACPI: thinkpad_acpi: use bool for boolean parameters Len Brown
2007-07-22 9:14 ` Len Brown
2007-07-22 9:14 ` [PATCH 57/77] ACPI: thinkpad-acpi: store ThinkPad model information Len Brown
2007-07-22 9:14 ` Len Brown
2007-07-22 9:14 ` [PATCH 58/77] ACPI: thinkpad-acpi: allow use of CMOS NVRAM for brightness control Len Brown
2007-07-22 9:14 ` Len Brown
2007-07-22 9:14 ` [PATCH 59/77] ACPI: thinkpad-acpi: react to Lenovo ThinkPad differences in hot key Len Brown
2007-07-22 9:14 ` Len Brown
2007-07-22 9:14 ` [PATCH 60/77] ACPI: thinkpad-acpi: make sure DSDT TMPx readings don't return +128 Len Brown
2007-07-22 9:14 ` Len Brown
2007-07-22 9:14 ` [PATCH 61/77] ACPI: thinkpad-acpi: make EC-based thermal readings non-experimental Len Brown
2007-07-22 9:14 ` Len Brown
2007-07-22 9:14 ` [PATCH 62/77] ACPI: thinkpad-acpi: bump up version to 0.15 Len Brown
2007-07-22 9:14 ` Len Brown
2007-07-22 9:14 ` [PATCH 63/77] ACPI: thinkpad-acpi: add locking to brightness subdriver Len Brown
2007-07-22 9:14 ` Len Brown
2007-07-22 9:14 ` [PATCH 64/77] sony-laptop: add new SNC handlers Len Brown
2007-07-22 9:14 ` Len Brown
2007-07-22 9:14 ` [PATCH 65/77] sony-laptop: map wireless switch events to KEY_WLAN Len Brown
2007-07-22 9:14 ` Len Brown
2007-07-22 9:14 ` [PATCH 66/77] sony-laptop: Add support for recent Vaios Fn keys (C series for now) Len Brown
2007-07-22 9:14 ` Len Brown
2007-07-22 9:14 ` [PATCH 67/77] sony-laptop: Invoke _INI for SNC devices that provide it Len Brown
2007-07-22 9:14 ` Len Brown
2007-07-22 9:14 ` [PATCH 68/77] sony-laptop: Make the driver use MSC_SCAN and a setkeycode and getkeycode key table Len Brown
2007-07-22 9:14 ` Len Brown
2007-07-22 9:14 ` [PATCH 69/77] sony-laptop: Add Vaio FE to the special init sequence Len Brown
2007-07-22 9:14 ` Len Brown
2007-07-22 9:14 ` [PATCH 70/77] sony-laptop: Fix event reading in sony-laptop Len Brown
2007-07-22 9:14 ` Len Brown
2007-07-22 9:14 ` [PATCH 71/77] ACPI: drivers/acpi/pci_link.c: lower printk severity Len Brown
2007-07-22 9:14 ` Len Brown
2007-07-22 9:14 ` [PATCH 72/77] ACPI: fix empty macros found by -Wextra Len Brown
2007-07-22 9:14 ` Len Brown
2007-07-22 9:14 ` [PATCH 73/77] ACPI: export ACPI events via acpi_mc_group multicast group Len Brown
2007-07-22 9:14 ` Len Brown
2007-07-22 9:14 ` [PATCH 74/77] ACPI: update feature-removal-schedule.txt, /sys/firmware/acpi/namespace is gone Len Brown
2007-07-22 9:14 ` Len Brown
2007-07-22 9:15 ` [PATCH 75/77] ACPI: update ACPI proc I/F removal schedule Len Brown
2007-07-22 9:15 ` Len Brown
2007-07-22 9:15 ` Len Brown [this message]
2007-07-22 9:15 ` [PATCH 76/77] ACPI: create CONFIG_ACPI_DEBUG_FUNC_TRACE Len Brown
2007-07-22 9:15 ` [PATCH 77/77] ACPI: Populate /sys/firmware/acpi/tables/ Len Brown
2007-07-22 9:15 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11850957811573-git-send-email-len.brown@intel.com \
--to=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.