From: Steven Whitehouse <swhiteho@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] Re: [PATCH] gfs2/locking/dlm: use an temp variable to reduce a spin_unlock
Date: Wed, 25 Jul 2007 15:09:36 +0100 [thread overview]
Message-ID: <1185372576.8765.477.camel@quoit> (raw)
In-Reply-To: <11853572382497-git-send-email-crquan@gmail.com>
Hi,
Now applied to the GFS2 -nmw git tree. Thanks,
Steve.
On Wed, 2007-07-25 at 17:53 +0800, Denis Cheng wrote:
> this is more clear.
>
> Signed-off-by: Denis Cheng <crquan@gmail.com>
> ---
> fs/gfs2/locking/dlm/plock.c | 11 ++++++-----
> 1 files changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/fs/gfs2/locking/dlm/plock.c b/fs/gfs2/locking/dlm/plock.c
> index fba1f1d..1f7b038 100644
> --- a/fs/gfs2/locking/dlm/plock.c
> +++ b/fs/gfs2/locking/dlm/plock.c
> @@ -346,15 +346,16 @@ static ssize_t dev_write(struct file *file, const char __user *u, size_t count,
>
> static unsigned int dev_poll(struct file *file, poll_table *wait)
> {
> + unsigned int mask = 0;
> +
> poll_wait(file, &send_wq, wait);
>
> spin_lock(&ops_lock);
> - if (!list_empty(&send_list)) {
> - spin_unlock(&ops_lock);
> - return POLLIN | POLLRDNORM;
> - }
> + if (!list_empty(&send_list))
> + mask = POLLIN | POLLRDNORM;
> spin_unlock(&ops_lock);
> - return 0;
> +
> + return mask;
> }
>
> static const struct file_operations dev_fops = {
WARNING: multiple messages have this Message-ID (diff)
From: Steven Whitehouse <swhiteho@redhat.com>
To: Denis Cheng <crquan@gmail.com>
Cc: cluster-devel@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gfs2/locking/dlm: use an temp variable to reduce a spin_unlock
Date: Wed, 25 Jul 2007 15:09:36 +0100 [thread overview]
Message-ID: <1185372576.8765.477.camel@quoit> (raw)
In-Reply-To: <11853572382497-git-send-email-crquan@gmail.com>
Hi,
Now applied to the GFS2 -nmw git tree. Thanks,
Steve.
On Wed, 2007-07-25 at 17:53 +0800, Denis Cheng wrote:
> this is more clear.
>
> Signed-off-by: Denis Cheng <crquan@gmail.com>
> ---
> fs/gfs2/locking/dlm/plock.c | 11 ++++++-----
> 1 files changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/fs/gfs2/locking/dlm/plock.c b/fs/gfs2/locking/dlm/plock.c
> index fba1f1d..1f7b038 100644
> --- a/fs/gfs2/locking/dlm/plock.c
> +++ b/fs/gfs2/locking/dlm/plock.c
> @@ -346,15 +346,16 @@ static ssize_t dev_write(struct file *file, const char __user *u, size_t count,
>
> static unsigned int dev_poll(struct file *file, poll_table *wait)
> {
> + unsigned int mask = 0;
> +
> poll_wait(file, &send_wq, wait);
>
> spin_lock(&ops_lock);
> - if (!list_empty(&send_list)) {
> - spin_unlock(&ops_lock);
> - return POLLIN | POLLRDNORM;
> - }
> + if (!list_empty(&send_list))
> + mask = POLLIN | POLLRDNORM;
> spin_unlock(&ops_lock);
> - return 0;
> +
> + return mask;
> }
>
> static const struct file_operations dev_fops = {
next prev parent reply other threads:[~2007-07-25 14:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-25 9:53 [PATCH] gfs2/locking/dlm: use an temp variable to reduce a spin_unlock Denis Cheng
2007-07-25 14:09 ` Steven Whitehouse [this message]
2007-07-25 14:09 ` Steven Whitehouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1185372576.8765.477.camel@quoit \
--to=swhiteho@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.