From: Rusty Russell <rusty-8n+1lVoiYb80n/F98K4Iww@public.gmane.org>
To: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
Cc: kvm-devel <kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Subject: [PATCH] kvm_vm_ioctl_get_dirty_log doesn't need any, probably doesn't want any
Date: Mon, 30 Jul 2007 22:31:36 +1000 [thread overview]
Message-ID: <1185798696.6131.44.camel@localhost.localdomain> (raw)
I'm not sure what "any" was for: some optimization which got trimmed,
I imagine. But neither "any" nor "i" are used later in the function,
so I've excised it.
Signed-off-by: Rusty Russell <rusty-8n+1lVoiYb80n/F98K4Iww@public.gmane.org>
diff -r a17d7fe2b240 drivers/kvm/kvm_main.c
--- a/drivers/kvm/kvm_main.c Mon Jul 30 15:10:22 2007 +1000
+++ b/drivers/kvm/kvm_main.c Mon Jul 30 15:20:33 2007 +1000
@@ -830,9 +830,7 @@ static int kvm_vm_ioctl_get_dirty_log(st
struct kvm_dirty_log *log)
{
struct kvm_memory_slot *memslot;
- int r, i;
- int n;
- unsigned long any = 0;
+ int r, n;
spin_lock(&kvm->lock);
@@ -851,11 +849,7 @@ static int kvm_vm_ioctl_get_dirty_log(st
if (!memslot->dirty_bitmap)
goto out;
- n = ALIGN(memslot->npages, BITS_PER_LONG) / 8;
-
- for (i = 0; !any && i < n/sizeof(long); ++i)
- any = memslot->dirty_bitmap[i];
-
+ n = BITS_TO_LONGS(memslot->npages) * sizeof(long);
r = -EFAULT;
if (copy_to_user(log->dirty_bitmap, memslot->dirty_bitmap, n))
goto out;
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
next reply other threads:[~2007-07-30 12:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-30 12:31 Rusty Russell [this message]
[not found] ` <1185798696.6131.44.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2007-07-30 12:39 ` [PATCH] kvm_vm_ioctl_get_dirty_log doesn't need any, probably doesn't want any Avi Kivity
[not found] ` <46ADDC16.2090801-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-07-30 13:21 ` [PATCH] kvm_vm_ioctl_get_dirty_log restore "nothing dirty" optimization Rusty Russell
[not found] ` <1185801694.6131.46.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2007-07-30 13:28 ` Avi Kivity
[not found] ` <46ADE78A.7080406-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-07-31 9:57 ` Rusty Russell
[not found] ` <1185875867.6131.76.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2007-07-31 11:10 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1185798696.6131.44.camel@localhost.localdomain \
--to=rusty-8n+1lvoiyb80n/f98k4iww@public.gmane.org \
--cc=avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org \
--cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.