All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: Rusty Russell <rusty-8n+1lVoiYb80n/F98K4Iww@public.gmane.org>
Cc: kvm-devel <kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Subject: Re: [PATCH] kvm_vm_ioctl_get_dirty_log restore "nothing dirty"	optimization
Date: Tue, 31 Jul 2007 14:10:50 +0300	[thread overview]
Message-ID: <46AF18BA.3090103@qumranet.com> (raw)
In-Reply-To: <1185875867.6131.76.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>

Rusty Russell wrote:
> kvm_vm_ioctl_get_dirty_log scans bitmap to see it it's all zero, but
> doesn't use that information.
>
> Avi says:
> 	Looks like it was used to guard	kvm_mmu_slot_remove_write_access();
> 	optimizing the case where the guest just leaves the screen alone (which
> 	it usually does, especially in benchmarks).
>
> 	I'd rather reinstate that optimization.  See
> 	66d8a4e4d4bd470216028daabb9d887b73259c96 where the damage was done.
>
> It's pretty simple: if the bitmap is all zero, we don't need to do anything to
> clean it.
>
>   

Applied; thanks.

-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/

      parent reply	other threads:[~2007-07-31 11:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-30 12:31 [PATCH] kvm_vm_ioctl_get_dirty_log doesn't need any, probably doesn't want any Rusty Russell
     [not found] ` <1185798696.6131.44.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2007-07-30 12:39   ` Avi Kivity
     [not found]     ` <46ADDC16.2090801-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-07-30 13:21       ` [PATCH] kvm_vm_ioctl_get_dirty_log restore "nothing dirty" optimization Rusty Russell
     [not found]         ` <1185801694.6131.46.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2007-07-30 13:28           ` Avi Kivity
     [not found]             ` <46ADE78A.7080406-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-07-31  9:57               ` Rusty Russell
     [not found]                 ` <1185875867.6131.76.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2007-07-31 11:10                   ` Avi Kivity [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46AF18BA.3090103@qumranet.com \
    --to=avi-atkuwr5tajbwk0htik3j/w@public.gmane.org \
    --cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=rusty-8n+1lVoiYb80n/F98K4Iww@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.