All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <htejun@gmail.com>
To: ebiederm@xmission.com, gregkh@suse.de,
	linux-kernel@vger.kernel.org, satyam@infradead.org,
	cornelia.huck@de.ibm.com, stern@rowland.harvard.edu,
	htejun@gmail.com
Cc: Tejun Heo <htejun@gmail.com>
Subject: [PATCH 3/7] sysfs: cosmetic changes in sysfs_lookup()
Date: Tue, 31 Jul 2007 19:15:08 +0900	[thread overview]
Message-ID: <11858769083801-git-send-email-htejun@gmail.com> (raw)
In-Reply-To: <11858769082982-git-send-email-htejun@gmail.com>

* remove space between * and symbol name in variable declaration.

* kill unnecessary new line.

* kill 'found' and test 'sd' instead.

Signed-off-by: Tejun Heo <htejun@gmail.com>
---
 fs/sysfs/dir.c |   15 +++++----------
 1 files changed, 5 insertions(+), 10 deletions(-)

diff --git a/fs/sysfs/dir.c b/fs/sysfs/dir.c
index 1c3a0dd..026ea70 100644
--- a/fs/sysfs/dir.c
+++ b/fs/sysfs/dir.c
@@ -756,24 +756,19 @@ static struct dentry * sysfs_lookup(struct inode *dir, struct dentry *dentry,
 				struct nameidata *nd)
 {
 	struct dentry *ret = NULL;
-	struct sysfs_dirent * parent_sd = dentry->d_parent->d_fsdata;
-	struct sysfs_dirent * sd;
+	struct sysfs_dirent *parent_sd = dentry->d_parent->d_fsdata;
+	struct sysfs_dirent *sd;
 	struct bin_attribute *bin_attr;
 	struct inode *inode;
-	int found = 0;
 
 	mutex_lock(&sysfs_mutex);
 
-	for (sd = parent_sd->s_children; sd; sd = sd->s_sibling) {
-		if (sysfs_type(sd) &&
-		    !strcmp(sd->s_name, dentry->d_name.name)) {
-			found = 1;
+	for (sd = parent_sd->s_children; sd; sd = sd->s_sibling)
+		if (sysfs_type(sd) && !strcmp(sd->s_name, dentry->d_name.name))
 			break;
-		}
-	}
 
 	/* no such entry */
-	if (!found)
+	if (!sd)
 		goto out_unlock;
 
 	/* attach dentry and inode */
-- 
1.5.0.3



  parent reply	other threads:[~2007-07-31 10:15 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-31 10:15 [PATCHSET 2.6.23-rc1] sysfs: locking fix and cleanups Tejun Heo
2007-07-31 10:15 ` [PATCH 1/7] sysfs: fix locking in sysfs_lookup() and sysfs_rename_dir() Tejun Heo
2007-07-31 12:56   ` Cornelia Huck
2007-08-02  0:29   ` Greg KH
2007-08-02  1:10     ` Eric W. Biederman
2007-08-02  1:10     ` Greg KH
2007-07-31 10:15 ` Tejun Heo [this message]
2007-07-31 12:57   ` [PATCH 3/7] sysfs: cosmetic changes in sysfs_lookup() Cornelia Huck
2007-07-31 10:15 ` [PATCH 6/7] sysfs: make sysfs_add_one() automatically check for duplicate entry Tejun Heo
2007-07-31 13:25   ` Cornelia Huck
2007-07-31 10:15 ` [PATCH 4/7] sysfs: simplify sysfs_remove_dir() Tejun Heo
2007-07-31 12:59   ` Cornelia Huck
2007-07-31 13:22     ` Tejun Heo
2007-07-31 10:15 ` [PATCH 5/7] sysfs: make sysfs_add/remove_one() call link/unlink_sibling() implictly Tejun Heo
2007-07-31 13:13   ` Cornelia Huck
2007-07-31 10:15 ` [PATCH 7/7] sysfs: make sysfs_addrm_finish() return void Tejun Heo
2007-07-31 12:55   ` Satyam Sharma
2007-07-31 13:33   ` Cornelia Huck
2007-07-31 12:55 ` [PATCHSET 2.6.23-rc1] sysfs: locking fix and cleanups Cornelia Huck
2007-07-31 13:24   ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11858769083801-git-send-email-htejun@gmail.com \
    --to=htejun@gmail.com \
    --cc=cornelia.huck@de.ibm.com \
    --cc=ebiederm@xmission.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=satyam@infradead.org \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.