From: Tejun Heo <htejun@gmail.com>
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: ebiederm@xmission.com, gregkh@suse.de,
linux-kernel@vger.kernel.org, satyam@infradead.org,
stern@rowland.harvard.edu
Subject: Re: [PATCH 4/7] sysfs: simplify sysfs_remove_dir()
Date: Tue, 31 Jul 2007 22:22:05 +0900 [thread overview]
Message-ID: <46AF377D.4020103@gmail.com> (raw)
In-Reply-To: <20070731145935.3398cfba@gondolin.boeblingen.de.ibm.com>
Cornelia Huck wrote:
> On Tue, 31 Jul 2007 19:15:08 +0900,
> Tejun Heo <htejun@gmail.com> wrote:
>
>> With the shadow directories gone, sysfs_remove_dir() can be simplified.
>>
>> * parent doesn't need to be grabbed separately. Just access
>> old_dentry->d_parent.
>>
>> * parent sd can never change. Remove code to move under the new
>> parent.
>>
>> * Massage comments a bit.
>>
>> Signed-off-by: Tejun Heo <htejun@gmail.com>
>> ---
>> fs/sysfs/dir.c | 26 ++++----------------------
>> 1 files changed, 4 insertions(+), 22 deletions(-)
>>
> It's not sysfs_remove_dir(), but sysfs_rename_dir() :) Otherwise this
> looks good.
Yeah, what was I thinking. :-)
--
tejun
next prev parent reply other threads:[~2007-07-31 13:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-31 10:15 [PATCHSET 2.6.23-rc1] sysfs: locking fix and cleanups Tejun Heo
2007-07-31 10:15 ` [PATCH 6/7] sysfs: make sysfs_add_one() automatically check for duplicate entry Tejun Heo
2007-07-31 13:25 ` Cornelia Huck
2007-07-31 10:15 ` [PATCH 1/7] sysfs: fix locking in sysfs_lookup() and sysfs_rename_dir() Tejun Heo
2007-07-31 12:56 ` Cornelia Huck
2007-08-02 0:29 ` Greg KH
2007-08-02 1:10 ` Eric W. Biederman
2007-08-02 1:10 ` Greg KH
2007-07-31 10:15 ` [PATCH 3/7] sysfs: cosmetic changes in sysfs_lookup() Tejun Heo
2007-07-31 12:57 ` Cornelia Huck
2007-07-31 10:15 ` [PATCH 5/7] sysfs: make sysfs_add/remove_one() call link/unlink_sibling() implictly Tejun Heo
2007-07-31 13:13 ` Cornelia Huck
2007-07-31 10:15 ` [PATCH 4/7] sysfs: simplify sysfs_remove_dir() Tejun Heo
2007-07-31 12:59 ` Cornelia Huck
2007-07-31 13:22 ` Tejun Heo [this message]
2007-07-31 10:15 ` [PATCH 7/7] sysfs: make sysfs_addrm_finish() return void Tejun Heo
2007-07-31 12:55 ` Satyam Sharma
2007-07-31 13:33 ` Cornelia Huck
2007-07-31 12:55 ` [PATCHSET 2.6.23-rc1] sysfs: locking fix and cleanups Cornelia Huck
2007-07-31 13:24 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46AF377D.4020103@gmail.com \
--to=htejun@gmail.com \
--cc=cornelia.huck@de.ibm.com \
--cc=ebiederm@xmission.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=satyam@infradead.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.