All of lore.kernel.org
 help / color / mirror / Atom feed
From: Segher Boessenkool <segher@kernel.crashing.org>
To: linuxppc-dev@ozlabs.org
Subject: [PATCH] Fix a compile warning in pci_32.c
Date: Wed,  1 Aug 2007 17:41:13 +0200	[thread overview]
Message-ID: <11859828761541-git-send-email-segher@kernel.crashing.org> (raw)
Message-ID: <576c3a210d014003c9d4b26f02a95099346f6716.1185982433.git.segher@kernel.crashing.org> (raw)

__must_check, so do so.

Signed-off-by: Segher Boessenkool <segher@kernel.crashing.org>
---
 arch/powerpc/kernel/pci_32.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/arch/powerpc/kernel/pci_32.c b/arch/powerpc/kernel/pci_32.c
index cd35c96..04a3109 100644
--- a/arch/powerpc/kernel/pci_32.c
+++ b/arch/powerpc/kernel/pci_32.c
@@ -581,8 +581,11 @@ pcibios_assign_resources(void)
 			if ((r->flags & IORESOURCE_UNSET) && r->end &&
 			    (!ppc_md.pcibios_enable_device_hook ||
 			     !ppc_md.pcibios_enable_device_hook(dev, 1))) {
+				int rc;
+
 				r->flags &= ~IORESOURCE_UNSET;
-				pci_assign_resource(dev, idx);
+				rc = pci_assign_resource(dev, idx);
+				BUG_ON(rc);
 			}
 		}
 
-- 
1.5.2.1.144.gabc40-dirty

             reply	other threads:[~2007-08-01 15:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-01 15:41 Segher Boessenkool [this message]
2007-08-01 15:41 ` [PATCH] Fix a compile warning in pci_32.c Segher Boessenkool
2007-08-01 15:41   ` [PATCH] Fix a compile warning in powermac/feature.c Segher Boessenkool
2007-08-01 15:41     ` Segher Boessenkool
2007-08-01 15:41       ` [PATCH] Replace a few #defines with empty inline functions Segher Boessenkool
2007-08-01 15:41         ` Segher Boessenkool
2007-08-01 15:41           ` [PATCH] ide/ppc/pmac: Remove a few unused variables Segher Boessenkool
2007-08-01 15:41             ` Segher Boessenkool

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11859828761541-git-send-email-segher@kernel.crashing.org \
    --to=segher@kernel.crashing.org \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.