All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Wysochanski <dwysocha@redhat.com>
To: lvm-devel@redhat.com
Subject: [LVM2 PATCH 1/2] lvrename: factor out core routine
Date: Fri, 03 Aug 2007 13:18:49 -0400	[thread overview]
Message-ID: <1186161529.4398.9.camel@linux-cxyg> (raw)
In-Reply-To: <46AA1020.8060600@ce.jp.nec.com>

On Fri, 2007-07-27 at 11:32 -0400, Jun'ichi Nomura wrote:
> Hi,
> 
> This patch factors out core renaming function from lvrename()
> as a preparation for mirrored LV renaming.
> 
> No functional change except for the order of the validity check.
> It used to be:
>   - check if the new name is not yet used in the VG
>   - check if the old name really exists in the VG
> This order is now reversed.
> As the VG is locked, it should have no problem.
> 
> Also the following cleanups are included:
>   - converting "stack; return 0;" to "return_0"
>   - removing duplicated mirrored LV check
>     (there were 2 identical checks)
> 
> Applicable to the CVS head.
> 

This looks fine and is a nice cleanup.  Will probably move the new
function out of the tools dir though.



      reply	other threads:[~2007-08-03 17:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-27 15:32 [LVM2 PATCH 1/2] lvrename: factor out core routine Jun'ichi Nomura
2007-08-03 17:18 ` Dave Wysochanski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1186161529.4398.9.camel@linux-cxyg \
    --to=dwysocha@redhat.com \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.