From: Jun'ichi Nomura <j-nomura@ce.jp.nec.com>
To: lvm-devel@redhat.com
Subject: [LVM2 PATCH 1/2] lvrename: factor out core routine
Date: Fri, 27 Jul 2007 11:32:48 -0400 [thread overview]
Message-ID: <46AA1020.8060600@ce.jp.nec.com> (raw)
Hi,
This patch factors out core renaming function from lvrename()
as a preparation for mirrored LV renaming.
No functional change except for the order of the validity check.
It used to be:
- check if the new name is not yet used in the VG
- check if the old name really exists in the VG
This order is now reversed.
As the VG is locked, it should have no problem.
Also the following cleanups are included:
- converting "stack; return 0;" to "return_0"
- removing duplicated mirrored LV check
(there were 2 identical checks)
Applicable to the CVS head.
Thanks,
--
Jun'ichi Nomura, NEC Corporation of America
-------------- next part --------------
A non-text attachment was scrubbed...
Name: lvm2-lvrename-extract-core-routine.patch
Type: text/x-patch
Size: 3922 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/lvm-devel/attachments/20070727/822ec4f2/attachment.bin>
next reply other threads:[~2007-07-27 15:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-27 15:32 Jun'ichi Nomura [this message]
2007-08-03 17:18 ` [LVM2 PATCH 1/2] lvrename: factor out core routine Dave Wysochanski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46AA1020.8060600@ce.jp.nec.com \
--to=j-nomura@ce.jp.nec.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.