Where is simple mixer control "Surround" defined for ac97 or via82xx? I cant find it anywhere in ac97....

Where is simple mixer control "Surround" defined for ac97 or via82xx? I cant find it anywhere in ac97....

[John L. Utz III]

The Surround controls exists:

amixer sget Surround
Simple mixer control 'Surround',0
  Capabilities: pvolume pswitch
  Playback channels: Front Left - Front Right
  Limits: Playback 0 - 31
  Mono:
  Front Left: Playback 0 [0%] [-46.50dB] [off]
  Front Right: Playback 0 [0%] [-46.50dB] [off]

amixer controls | grep Surround
numid=20,iface=MIXER,name='Surround Playback Switch'
numid=21,iface=MIXER,name='Surround Playback Volume'

But for the life of me, i cant find the code that implements it!

There are many implementations inside of the hda directory, but those
dont have anything todo with non hda things, the only item in the ac97
directory is for AD18XX:

ac97_codec.c:958:AD18XX_PCM_VOLUME("Surround Playback Volume", 1)


This shouldnt have anything to do with VIA 1618 stuff, right?

tnx!

johnu

Re: Where is simple mixer control "Surround" defined for ac97 or via82xx? I cant find it anywhere in ac97....

[Clemens Ladisch]

John L. Utz III wrote:
> amixer controls | grep Surround
> numid=20,iface=MIXER,name='Surround Playback Switch'
> numid=21,iface=MIXER,name='Surround Playback Volume'
> 
> But for the life of me, i cant find the code that implements it!

Around line 1350 in ac97_codec.c:

	/* build surround controls */
	if ((snd_ac97_try_volume_mix(ac97, AC97_SURROUND_MASTER))
		&& !(ac97->flags & AC97_AD_MULTI)) {
		/* Surround Master (0x38) is with stereo mutes */
		if ((err = snd_ac97_cmix_new_stereo(card, "Surround Playback",
						    AC97_SURROUND_MASTER, 1, 0,
						    ac97)) < 0)
			return err;
	}

HTH
Clemens

Re: Where is simple mixer control "Surround" defined for ac97 or via82xx? I cant find it anywhere in ac97....

[John L. Utz III]

Tnx Clemens!

On Fri, 10 Aug 2007 09:33:46 +0200
"Clemens Ladisch" <cladisch@fastmail.net> wrote:

> John L. Utz III wrote:
> > amixer controls | grep Surround
> > numid=20,iface=MIXER,name='Surround Playback Switch'
> > numid=21,iface=MIXER,name='Surround Playback Volume'
> > 
> > But for the life of me, i cant find the code that implements it!
> 
> Around line 1350 in ac97_codec.c:
> 
> 	/* build surround controls */
> 	if ((snd_ac97_try_volume_mix(ac97, AC97_SURROUND_MASTER))
> 		&& !(ac97->flags & AC97_AD_MULTI)) {
> 		/* Surround Master (0x38) is with stereo mutes */
> 		if ((err = snd_ac97_cmix_new_stereo(card, "Surround
> Playback", AC97_SURROUND_MASTER, 1, 0,
> 						    ac97)) < 0)
> 			return err;
> 	}
> 
> HTH

It does, i think that i'll try to use snd_ac97_rename_vol_ctl() in
patch_vt1618() to make Surround the Rear control.

Hopefully, i'll have a usable patch to submit for vt1618 next week,
woohoo!

> Clemens
> 

Re: Where is simple mixer control "Surround" defined for ac97 or via82xx? I cant find it anywhere in ac97....

[Lee Revell]

On 8/10/07, John L. Utz III <john.utz@dmx.com> wrote:
> It does, i think that i'll try to use snd_ac97_rename_vol_ctl() in
> patch_vt1618() to make Surround the Rear control.
>
> Hopefully, i'll have a usable patch to submit for vt1618 next week,
> woohoo!

Why do you want to rename Surround to Rear?  It would cause people's
mixer settings to be lost.

Lee

Re: Where is simple mixer control "Surround" defined for ac97 or via82xx? I cant find it anywhere in ac97....

[John L. Utz III]

Hi Lee;

tnx for the absolutely reasonable question!

On Fri, 10 Aug 2007 14:04:10 -0400
"Lee Revell" <rlrevell@joe-job.com> wrote:

> On 8/10/07, John L. Utz III <john.utz@dmx.com> wrote:
> > It does, i think that i'll try to use snd_ac97_rename_vol_ctl() in
> > patch_vt1618() to make Surround the Rear control.
> >
> > Hopefully, i'll have a usable patch to submit for vt1618 next week,
> > woohoo!
> 
> Why do you want to rename Surround to Rear?  It would cause people's
> mixer settings to be lost.

As of right now, i actually don't! :-)

I did up until about 15 minutes ago tho!

It wasn't my intent to change it generally, i only wanted to change it
for the 1618.

Peoples mixer settings wouldn't be lost, because the VIA1618 is
currently near unusable under ALSA.

Thus i receive regular pings from random linux loving 1618 owning
netizens along the lines of:

 'where's that patch john?'
 'how soon will it be done?' 

:-)

So, the reason for me to want to change it was to make it just like
the CMI8738-MC6 Rear Output Softvol that i have created.

That turns out to be a stupid idea, because CMI8738-MC6 is the thing
that's not in sync with the current thought on how multichannel audio
is laid out. :-)

So i will rename that CMI8738 softvol to be Surround Playback Volume
instead of Rear Playback Volume and send in a patch shortly.

The reason for all this brain-churn is that i have to make our
product work with both the CMI8738-MC6 and the VT1618.

Because the CMI8738-MC6 is what we have on zillions of existing product
in the field and the VT1618 is what's currently available.

Keeping up with audio chipset EOL's while maintaining 100% product
compatibility with 7 year old product that is *still* in the field is
why i have a job :-)

> Lee
>