Re: [Qemu-devel] [PATCH 4/4][RFC] Add logic to QEMU to read command line options from qcow2 images

[Anthony Liguori <anthony@codemonkey.ws>]

On Sat, 2007-08-11 at 22:28 +0100, Philip Boulain wrote:
> > Yes, I think that another argument should be required as Dan suggested 
> > although I'd like something more explicit like "-read-args-from-image".  
> > In the case where the image was directly executable, it would be 
> > embedded as part of the interpreter arguments.
> 
> This works, so long as qemu disregards "-read-args-from-image" unless it's 
> being called as an interpreter. Otherwise, you've put the lock and the key in 
> the same place. :)
> 
> If an image says:
>    #!/whatever/qemu -read-args-from-image
>    -curious-and-interesting-flags
> 
> This should use those flags:
>    $ ./image.qcow2
> 
> And this shouldn't, because you don't need to have made it executable:
>    $ qemu -hda image.qcow2
> 
> (But this would:)
>    $ qemu -read-args-from-image -hda image.qcow2

Yes.  This is exactly what I think the behavior ought to be.

> (Side thought: presumably, we're assuming that the in-file and on-command-line 
> arguments are unioned, ideally with the latter taking precidence if mutually 
> exclusive.)

Yup, I was thinking the same thing too.  Once the KVM wiki comes back
online I'll write something up on a wiki page.

Regards,

Anthony Liguori

> >> This also doesn't apply outside of UNIX-like environments, e.g. 
> >> Windows...
> > I think this is covered by requiring the additional argument.
> 
> Agreed.
> 
> LionsPhil
> 
>