All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@qumranet.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: "Jorge Lucángeli Obes" <t4m5yn@gmail.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 4/4][RFC] Add logic to QEMU to read command line options from qcow2 images
Date: Thu, 09 Aug 2007 23:16:37 +0300	[thread overview]
Message-ID: <46BB7625.2050900@qumranet.com> (raw)
In-Reply-To: <46BB2A99.3030609@codemonkey.ws>

Anthony Liguori wrote:
>>
>> I think it is a bad idea from a security POV to automatically extract 
>> & use command line args from  a disk image like this without the 
>> admin explicitly requesting this capability.
>> eg If I grabbed a demo disk image from a vendors' or community 
>> website I would
>> certainly not trust whatever args may happen to be embedded in the 
>> disk image
>> and thus do not want QEMU to be automatically running using them.
>>
>> I'd recommend having some command line flag to turn this capability 
>> on. For
>> example a '--args PATH-TO-DISK' flag,
>>
>>   qemu --args $HOME/fedora.qcow
>>   
>
> That's pretty nasty.  How do you specify which disk this is then?  I 
> do agree with you that allowing arbitrary command line arguments in an 
> image file is probably a bad idea.  I think the general idea of being 
> able to launch a single image is useful but I suspect this is not the 
> right way to do it.
>
> What are some people thinking would want to be stored in the file?  
> Most of the command line options are more host specific than guest 
> specific I think.  Maybe we can store a pseudo-config instead that 
> only contains a subset of parameters (and therefore, wouldn't pose a 
> security risk)? 

Memory size, -hdb and -cdrom, processor count, networking setup.  The 
sort of things people push into ad-hoc scripts.

I expect this to be the low-end solution; with high end management 
applications storing configuration options in a database.

  parent reply	other threads:[~2007-08-09 20:16 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-08 18:24 [PATCH 4/4][RFC] Add logic to QEMU to read command line options from qcow2 images Jorge Lucángeli Obes
2007-08-08 19:52 ` [Qemu-devel] " Jorge Lucángeli Obes
2007-08-08 20:24   ` Daniel P. Berrange
2007-08-09 14:54     ` Anthony Liguori
2007-08-09 15:07       ` Daniel P. Berrange
2007-08-09 20:16       ` Avi Kivity [this message]
2007-08-09 20:25         ` Anthony Liguori
2007-08-09 20:30           ` Avi Kivity
2007-08-09 20:32             ` Anthony Liguori
2007-08-09 20:39               ` Avi Kivity
2007-08-09 20:44               ` Brian Wheeler
2007-08-09 20:49                 ` Anthony Liguori
2007-08-10  3:51                 ` dmc
2007-08-10 13:26                   ` Carlos A. M. dos Santos
2007-08-09 20:55         ` Brian Wheeler
2007-08-10  0:48           ` Anthony Liguori
2007-08-11 17:11   ` andrzej zaborowski
2007-08-11 18:06     ` Philip Boulain
2007-08-11 19:08       ` Christian Brunschen
2007-08-11 19:53         ` Anthony Liguori
2007-08-11 19:52       ` Anthony Liguori
2007-08-11 21:28         ` Philip Boulain
2007-08-11 23:17           ` Anthony Liguori
2007-08-13  5:34             ` Jorge Lucángeli Obes
2007-08-13  5:34               ` Jorge Lucángeli Obes
     [not found]               ` <59abf66e0708122234u6fe7a27bwa08f92252951879a-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2007-08-13 15:15                 ` Anthony Liguori
2007-08-13 15:15                   ` [kvm-devel] " Anthony Liguori
2007-08-11 19:49     ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46BB7625.2050900@qumranet.com \
    --to=avi@qumranet.com \
    --cc=anthony@codemonkey.ws \
    --cc=qemu-devel@nongnu.org \
    --cc=t4m5yn@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.