* [PATCH 5/5] mm/... convert #include "linux/..." to #include
@ 2007-08-19 22:19 ` Joe Perches
0 siblings, 0 replies; 12+ messages in thread
From: Joe Perches @ 2007-08-19 22:19 UTC (permalink / raw)
To: kernel-janitors, linux-kernel
Cc: Christoph Lameter, Eric Dumazet, Pekka Enberg, linux-mm
(untested)
There are several files that
#include "linux/file" not #include <linux/file>
#include "asm/file" not #include <asm/file>
Here's a little script that converts them:
egrep -i -r -l --include=*.[ch] \
"^[[:space:]]*\#[[:space:]]*include[[:space:]]*\"(linux|asm)/(.*)\"" * \
| xargs sed -i -e 's/^[[:space:]]*#[[:space:]]*include[[:space:]]*"\(linux\|asm\)\/\(.*\)"/#include <\1\/\2>/g'
Signed-off-by: Joe Perches <joe@perches.com>
diff --git a/mm/slab.c b/mm/slab.c
index a684778..976aeff 100644
--- a/mm/slab.c
+++ b/mm/slab.c
@@ -334,7 +334,7 @@ static __always_inline int index_of(const size_t size)
return i; \
else \
i++;
-#include "linux/kmalloc_sizes.h"
+#include <linux/kmalloc_sizes.h>
#undef CACHE
__bad_size();
} else
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 5/5] mm/... convert #include "linux/..." to #include <linux/...>
@ 2007-08-19 22:19 ` Joe Perches
0 siblings, 0 replies; 12+ messages in thread
From: Joe Perches @ 2007-08-19 22:19 UTC (permalink / raw)
To: kernel-janitors, linux-kernel
Cc: Christoph Lameter, Eric Dumazet, Pekka Enberg, linux-mm
(untested)
There are several files that
#include "linux/file" not #include <linux/file>
#include "asm/file" not #include <asm/file>
Here's a little script that converts them:
egrep -i -r -l --include=*.[ch] \
"^[[:space:]]*\#[[:space:]]*include[[:space:]]*\"(linux|asm)/(.*)\"" * \
| xargs sed -i -e 's/^[[:space:]]*#[[:space:]]*include[[:space:]]*"\(linux\|asm\)\/\(.*\)"/#include <\1\/\2>/g'
Signed-off-by: Joe Perches <joe@perches.com>
diff --git a/mm/slab.c b/mm/slab.c
index a684778..976aeff 100644
--- a/mm/slab.c
+++ b/mm/slab.c
@@ -334,7 +334,7 @@ static __always_inline int index_of(const size_t size)
return i; \
else \
i++;
-#include "linux/kmalloc_sizes.h"
+#include <linux/kmalloc_sizes.h>
#undef CACHE
__bad_size();
} else
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 5/5] mm/... convert #include "linux/..." to #include <linux/...>
@ 2007-08-19 22:19 ` Joe Perches
0 siblings, 0 replies; 12+ messages in thread
From: Joe Perches @ 2007-08-19 22:19 UTC (permalink / raw)
To: kernel-janitors, linux-kernel
Cc: Christoph Lameter, Eric Dumazet, Pekka Enberg, linux-mm
(untested)
There are several files that
#include "linux/file" not #include <linux/file>
#include "asm/file" not #include <asm/file>
Here's a little script that converts them:
egrep -i -r -l --include=*.[ch] \
"^[[:space:]]*\#[[:space:]]*include[[:space:]]*\"(linux|asm)/(.*)\"" * \
| xargs sed -i -e 's/^[[:space:]]*#[[:space:]]*include[[:space:]]*"\(linux\|asm\)\/\(.*\)"/#include <\1\/\2>/g'
Signed-off-by: Joe Perches <joe@perches.com>
diff --git a/mm/slab.c b/mm/slab.c
index a684778..976aeff 100644
--- a/mm/slab.c
+++ b/mm/slab.c
@@ -334,7 +334,7 @@ static __always_inline int index_of(const size_t size)
return i; \
else \
i++;
-#include "linux/kmalloc_sizes.h"
+#include <linux/kmalloc_sizes.h>
#undef CACHE
__bad_size();
} else
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 5/5] mm/... convert #include "linux/..." to #include
2007-08-19 22:19 ` Joe Perches
(?)
@ 2007-08-20 18:06 ` Christoph Lameter
-1 siblings, 0 replies; 12+ messages in thread
From: Christoph Lameter @ 2007-08-20 18:06 UTC (permalink / raw)
To: Joe Perches
Cc: kernel-janitors, linux-kernel, Eric Dumazet, Pekka Enberg,
linux-mm
On Sun, 19 Aug 2007, Joe Perches wrote:
> diff --git a/mm/slab.c b/mm/slab.c
> index a684778..976aeff 100644
> --- a/mm/slab.c
> +++ b/mm/slab.c
> @@ -334,7 +334,7 @@ static __always_inline int index_of(const size_t size)
> return i; \
> else \
> i++;
> -#include "linux/kmalloc_sizes.h"
> +#include <linux/kmalloc_sizes.h>
> #undef CACHE
> __bad_size();
> } else
But I think this was done intentionally to point out that the file
includes is *not* a regular include file.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 5/5] mm/... convert #include "linux/..." to #include <linux/...>
@ 2007-08-20 18:06 ` Christoph Lameter
0 siblings, 0 replies; 12+ messages in thread
From: Christoph Lameter @ 2007-08-20 18:06 UTC (permalink / raw)
To: Joe Perches
Cc: kernel-janitors, linux-kernel, Eric Dumazet, Pekka Enberg,
linux-mm
On Sun, 19 Aug 2007, Joe Perches wrote:
> diff --git a/mm/slab.c b/mm/slab.c
> index a684778..976aeff 100644
> --- a/mm/slab.c
> +++ b/mm/slab.c
> @@ -334,7 +334,7 @@ static __always_inline int index_of(const size_t size)
> return i; \
> else \
> i++;
> -#include "linux/kmalloc_sizes.h"
> +#include <linux/kmalloc_sizes.h>
> #undef CACHE
> __bad_size();
> } else
But I think this was done intentionally to point out that the file
includes is *not* a regular include file.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 5/5] mm/... convert #include "linux/..." to #include <linux/...>
@ 2007-08-20 18:06 ` Christoph Lameter
0 siblings, 0 replies; 12+ messages in thread
From: Christoph Lameter @ 2007-08-20 18:06 UTC (permalink / raw)
To: Joe Perches
Cc: kernel-janitors, linux-kernel, Eric Dumazet, Pekka Enberg,
linux-mm
On Sun, 19 Aug 2007, Joe Perches wrote:
> diff --git a/mm/slab.c b/mm/slab.c
> index a684778..976aeff 100644
> --- a/mm/slab.c
> +++ b/mm/slab.c
> @@ -334,7 +334,7 @@ static __always_inline int index_of(const size_t size)
> return i; \
> else \
> i++;
> -#include "linux/kmalloc_sizes.h"
> +#include <linux/kmalloc_sizes.h>
> #undef CACHE
> __bad_size();
> } else
But I think this was done intentionally to point out that the file
includes is *not* a regular include file.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 5/5] mm/... convert #include "linux/..." to #include
2007-08-20 18:06 ` Christoph Lameter
(?)
@ 2007-08-20 18:49 ` Joe Perches
-1 siblings, 0 replies; 12+ messages in thread
From: Joe Perches @ 2007-08-20 18:49 UTC (permalink / raw)
To: Christoph Lameter
Cc: kernel-janitors, linux-kernel, Eric Dumazet, Pekka Enberg,
linux-mm
On Mon, 2007-08-20 at 11:06 -0700, Christoph Lameter wrote:
> On Sun, 19 Aug 2007, Joe Perches wrote:
> > diff --git a/mm/slab.c b/mm/slab.c
> > -#include "linux/kmalloc_sizes.h"
> > +#include <linux/kmalloc_sizes.h>
> But I think this was done intentionally to point out that the file
> includes is *not* a regular include file.
Maybe. I think it's just a simple error.
mm/slab.c has 2 other includes of
#include <linux/kmalloc_sizes.h>
cheers, Joe
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 5/5] mm/... convert #include "linux/..." to #include <linux/...>
@ 2007-08-20 18:49 ` Joe Perches
0 siblings, 0 replies; 12+ messages in thread
From: Joe Perches @ 2007-08-20 18:49 UTC (permalink / raw)
To: Christoph Lameter
Cc: kernel-janitors, linux-kernel, Eric Dumazet, Pekka Enberg,
linux-mm
On Mon, 2007-08-20 at 11:06 -0700, Christoph Lameter wrote:
> On Sun, 19 Aug 2007, Joe Perches wrote:
> > diff --git a/mm/slab.c b/mm/slab.c
> > -#include "linux/kmalloc_sizes.h"
> > +#include <linux/kmalloc_sizes.h>
> But I think this was done intentionally to point out that the file
> includes is *not* a regular include file.
Maybe. I think it's just a simple error.
mm/slab.c has 2 other includes of
#include <linux/kmalloc_sizes.h>
cheers, Joe
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 5/5] mm/... convert #include "linux/..." to #include <linux/...>
@ 2007-08-20 18:49 ` Joe Perches
0 siblings, 0 replies; 12+ messages in thread
From: Joe Perches @ 2007-08-20 18:49 UTC (permalink / raw)
To: Christoph Lameter
Cc: kernel-janitors, linux-kernel, Eric Dumazet, Pekka Enberg,
linux-mm
On Mon, 2007-08-20 at 11:06 -0700, Christoph Lameter wrote:
> On Sun, 19 Aug 2007, Joe Perches wrote:
> > diff --git a/mm/slab.c b/mm/slab.c
> > -#include "linux/kmalloc_sizes.h"
> > +#include <linux/kmalloc_sizes.h>
> But I think this was done intentionally to point out that the file
> includes is *not* a regular include file.
Maybe. I think it's just a simple error.
mm/slab.c has 2 other includes of
#include <linux/kmalloc_sizes.h>
cheers, Joe
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 5/5] mm/... convert #include "linux/..." to #include
2007-08-20 18:49 ` Joe Perches
(?)
@ 2007-08-20 18:57 ` Christoph Lameter
-1 siblings, 0 replies; 12+ messages in thread
From: Christoph Lameter @ 2007-08-20 18:57 UTC (permalink / raw)
To: Joe Perches
Cc: kernel-janitors, linux-kernel, Eric Dumazet, Pekka Enberg,
linux-mm
On Mon, 20 Aug 2007, Joe Perches wrote:
> Maybe. I think it's just a simple error.
>
> mm/slab.c has 2 other includes of
>
> #include <linux/kmalloc_sizes.h>
>
> cheers, Joe
Ahh. ok.
Then
Acked-by: Christoph Lameter <clameter@sgi.com>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 5/5] mm/... convert #include "linux/..." to #include <linux/...>
@ 2007-08-20 18:57 ` Christoph Lameter
0 siblings, 0 replies; 12+ messages in thread
From: Christoph Lameter @ 2007-08-20 18:57 UTC (permalink / raw)
To: Joe Perches
Cc: kernel-janitors, linux-kernel, Eric Dumazet, Pekka Enberg,
linux-mm
On Mon, 20 Aug 2007, Joe Perches wrote:
> Maybe. I think it's just a simple error.
>
> mm/slab.c has 2 other includes of
>
> #include <linux/kmalloc_sizes.h>
>
> cheers, Joe
Ahh. ok.
Then
Acked-by: Christoph Lameter <clameter@sgi.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 5/5] mm/... convert #include "linux/..." to #include <linux/...>
@ 2007-08-20 18:57 ` Christoph Lameter
0 siblings, 0 replies; 12+ messages in thread
From: Christoph Lameter @ 2007-08-20 18:57 UTC (permalink / raw)
To: Joe Perches
Cc: kernel-janitors, linux-kernel, Eric Dumazet, Pekka Enberg,
linux-mm
On Mon, 20 Aug 2007, Joe Perches wrote:
> Maybe. I think it's just a simple error.
>
> mm/slab.c has 2 other includes of
>
> #include <linux/kmalloc_sizes.h>
>
> cheers, Joe
Ahh. ok.
Then
Acked-by: Christoph Lameter <clameter@sgi.com>
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2007-08-20 18:58 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-19 22:19 [PATCH 5/5] mm/... convert #include "linux/..." to #include Joe Perches
2007-08-19 22:19 ` [PATCH 5/5] mm/... convert #include "linux/..." to #include <linux/...> Joe Perches
2007-08-19 22:19 ` Joe Perches
2007-08-20 18:06 ` [PATCH 5/5] mm/... convert #include "linux/..." to #include Christoph Lameter
2007-08-20 18:06 ` [PATCH 5/5] mm/... convert #include "linux/..." to #include <linux/...> Christoph Lameter
2007-08-20 18:06 ` Christoph Lameter
2007-08-20 18:49 ` [PATCH 5/5] mm/... convert #include "linux/..." to #include Joe Perches
2007-08-20 18:49 ` [PATCH 5/5] mm/... convert #include "linux/..." to #include <linux/...> Joe Perches
2007-08-20 18:49 ` Joe Perches
2007-08-20 18:57 ` [PATCH 5/5] mm/... convert #include "linux/..." to #include Christoph Lameter
2007-08-20 18:57 ` [PATCH 5/5] mm/... convert #include "linux/..." to #include <linux/...> Christoph Lameter
2007-08-20 18:57 ` Christoph Lameter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.