From: Joe Perches <joe@perches.com>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@suse.de>,
Markus Rechberger <markus.rechberger@amd.com>
Subject: Re: [PATCH 4/5] Documentation/firmware/... convert #include
Date: Sun, 19 Aug 2007 22:31:57 +0000 [thread overview]
Message-ID: <1187562717.4200.154.camel@localhost> (raw)
In-Reply-To: <20070819153422.1e0b54af.randy.dunlap@oracle.com>
On Sun, 2007-08-19 at 15:34 -0700, Randy Dunlap wrote:
> > -#include "linux/firmware.h"
> > +#include "firmware.h"
> I believe that it should be <linux/firmware.h>.
OK.
That's not my taste though, especially if only
included by files in the firmware_class directory.
Less pollution/namespace collision in include/linux
cheers, Joe
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@suse.de>,
Markus Rechberger <markus.rechberger@amd.com>
Subject: Re: [PATCH 4/5] Documentation/firmware/... convert #include "linux/..." to #include <linux/...>
Date: Sun, 19 Aug 2007 15:31:57 -0700 [thread overview]
Message-ID: <1187562717.4200.154.camel@localhost> (raw)
In-Reply-To: <20070819153422.1e0b54af.randy.dunlap@oracle.com>
On Sun, 2007-08-19 at 15:34 -0700, Randy Dunlap wrote:
> > -#include "linux/firmware.h"
> > +#include "firmware.h"
> I believe that it should be <linux/firmware.h>.
OK.
That's not my taste though, especially if only
included by files in the firmware_class directory.
Less pollution/namespace collision in include/linux
cheers, Joe
next prev parent reply other threads:[~2007-08-19 22:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-19 22:19 [PATCH 4/5] Documentation/firmware/... convert #include Joe Perches
2007-08-19 22:19 ` [PATCH 4/5] Documentation/firmware/... convert #include "linux/..." to #include <linux/...> Joe Perches
2007-08-19 22:34 ` [PATCH 4/5] Documentation/firmware/... convert #include Randy Dunlap
2007-08-19 22:34 ` [PATCH 4/5] Documentation/firmware/... convert #include "linux/..." to #include <linux/...> Randy Dunlap
2007-08-19 22:31 ` Joe Perches [this message]
2007-08-19 22:31 ` Joe Perches
2007-08-19 22:41 ` [PATCH 4/5] Documentation/firmware/... convert #include Randy Dunlap
2007-08-19 22:41 ` [PATCH 4/5] Documentation/firmware/... convert #include "linux/..." to #include <linux/...> Randy Dunlap
2007-08-19 22:41 ` [PATCH 4/5] Documentation/firmware/... convert #include Joe Perches
2007-08-19 22:41 ` [PATCH 4/5] Documentation/firmware/... convert #include "linux/..." to #include <linux/...> Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1187562717.4200.154.camel@localhost \
--to=joe@perches.com \
--cc=gregkh@suse.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markus.rechberger@amd.com \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.