From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: aherrman@arcor.de
Cc: linux-fbdev-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] radeonfb: fix setting of PPLL_REF_DIV for RV370 5B60
Date: Tue, 04 Sep 2007 15:47:03 +0200 [thread overview]
Message-ID: <1188913623.5972.152.camel@localhost.localdomain> (raw)
In-Reply-To: <20070904110000.GG7320@devil>
On Tue, 2007-09-04 at 13:00 +0200, aherrman@arcor.de wrote:
> As observed with various Radeon X300: console goes blank
> without fixing setting of PPLL_REF_DIV.
>
> Signed-off-by: Andreas Herrmann <aherrman@arcor.de>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> ---
> drivers/video/aty/radeon_base.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/video/aty/radeon_base.c b/drivers/video/aty/radeon_base.c
> index f672c0c..71b0c17 100644
> --- a/drivers/video/aty/radeon_base.c
> +++ b/drivers/video/aty/radeon_base.c
> @@ -1287,7 +1287,8 @@ static void radeon_write_pll_regs(struct radeonfb_info *rinfo, struct radeon_reg
> if (rinfo->family == CHIP_FAMILY_R300 ||
> rinfo->family == CHIP_FAMILY_RS300 ||
> rinfo->family == CHIP_FAMILY_R350 ||
> - rinfo->family == CHIP_FAMILY_RV350) {
> + rinfo->family == CHIP_FAMILY_RV350 ||
> + rinfo->family == CHIP_FAMILY_RV380 ) {
> if (mode->ppll_ref_div & R300_PPLL_REF_DIV_ACC_MASK) {
> /* When restoring console mode, use saved PPLL_REF_DIV
> * setting.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: aherrman@arcor.de
Cc: linux-fbdev-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] radeonfb: fix setting of PPLL_REF_DIV for RV370 5B60
Date: Tue, 04 Sep 2007 15:47:03 +0200 [thread overview]
Message-ID: <1188913623.5972.152.camel@localhost.localdomain> (raw)
In-Reply-To: <20070904110000.GG7320@devil>
On Tue, 2007-09-04 at 13:00 +0200, aherrman@arcor.de wrote:
> As observed with various Radeon X300: console goes blank
> without fixing setting of PPLL_REF_DIV.
>
> Signed-off-by: Andreas Herrmann <aherrman@arcor.de>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> ---
> drivers/video/aty/radeon_base.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/video/aty/radeon_base.c b/drivers/video/aty/radeon_base.c
> index f672c0c..71b0c17 100644
> --- a/drivers/video/aty/radeon_base.c
> +++ b/drivers/video/aty/radeon_base.c
> @@ -1287,7 +1287,8 @@ static void radeon_write_pll_regs(struct radeonfb_info *rinfo, struct radeon_reg
> if (rinfo->family == CHIP_FAMILY_R300 ||
> rinfo->family == CHIP_FAMILY_RS300 ||
> rinfo->family == CHIP_FAMILY_R350 ||
> - rinfo->family == CHIP_FAMILY_RV350) {
> + rinfo->family == CHIP_FAMILY_RV350 ||
> + rinfo->family == CHIP_FAMILY_RV380 ) {
> if (mode->ppll_ref_div & R300_PPLL_REF_DIV_ACC_MASK) {
> /* When restoring console mode, use saved PPLL_REF_DIV
> * setting.
next prev parent reply other threads:[~2007-09-06 12:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-04 11:00 [PATCH 3/4] radeonfb: fix setting of PPLL_REF_DIV for RV370 5B60 aherrman
2007-09-04 13:47 ` Benjamin Herrenschmidt [this message]
2007-09-04 13:47 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1188913623.5972.152.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=aherrman@arcor.de \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.