From: Thomas Gleixner <tglx@linutronix.de>
To: Tony Breeds <tony@bakeyournoodle.com>
Cc: zach@vmware.com, John Stultz <johnstul@us.ibm.com>,
Linux Kernel ML <linux-kernel@vger.kernel.org>,
LinuxPPC-dev <linuxppc-dev@ozlabs.org>,
Paul Mackerras <paulus@samba.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: Fix "no_sync_cmos_clock" logic inversion in kernel/time/ntp.c
Date: Tue, 11 Sep 2007 09:57:50 +0200 [thread overview]
Message-ID: <1189497470.22589.3.camel@chaos> (raw)
In-Reply-To: <20070911074608.GD9814@bakeyournoodle.com>
On Tue, 2007-09-11 at 17:46 +1000, Tony Breeds wrote:
> Signed-off-by: Tony Breeds <tony@bakeyournoodle.com>
>
> ---
>
> Seems to me that this timer will only get started on platforms that say
> they don't want it?
Hell, yes. Good catch !
tglx
> kernel/time/ntp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: working/kernel/time/ntp.c
> ===================================================================
> --- working.orig/kernel/time/ntp.c 2007-09-11 17:34:44.000000000 +1000
> +++ working/kernel/time/ntp.c 2007-09-11 17:34:55.000000000 +1000
> @@ -226,7 +226,7 @@ static void sync_cmos_clock(unsigned lon
>
> static void notify_cmos_timer(void)
> {
> - if (no_sync_cmos_clock)
> + if (!no_sync_cmos_clock)
> mod_timer(&sync_cmos_timer, jiffies + 1);
> }
>
>
> Yours Tony
>
> linux.conf.au http://linux.conf.au/ || http://lca2008.linux.org.au/
> Jan 28 - Feb 02 2008 The Australian Linux Technical Conference!
>
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Gleixner <tglx@linutronix.de>
To: Tony Breeds <tony@bakeyournoodle.com>
Cc: Linux Kernel ML <linux-kernel@vger.kernel.org>,
LinuxPPC-dev <linuxppc-dev@ozlabs.org>,
Andrew Morton <akpm@linux-foundation.org>,
Paul Mackerras <paulus@samba.org>,
Gabriel Paubert <paubert@iram.es>,
zach@vmware.com, John Stultz <johnstul@us.ibm.com>
Subject: Re: Fix "no_sync_cmos_clock" logic inversion in kernel/time/ntp.c
Date: Tue, 11 Sep 2007 09:57:50 +0200 [thread overview]
Message-ID: <1189497470.22589.3.camel@chaos> (raw)
In-Reply-To: <20070911074608.GD9814@bakeyournoodle.com>
On Tue, 2007-09-11 at 17:46 +1000, Tony Breeds wrote:
> Signed-off-by: Tony Breeds <tony@bakeyournoodle.com>
>
> ---
>
> Seems to me that this timer will only get started on platforms that say
> they don't want it?
Hell, yes. Good catch !
tglx
> kernel/time/ntp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: working/kernel/time/ntp.c
> ===================================================================
> --- working.orig/kernel/time/ntp.c 2007-09-11 17:34:44.000000000 +1000
> +++ working/kernel/time/ntp.c 2007-09-11 17:34:55.000000000 +1000
> @@ -226,7 +226,7 @@ static void sync_cmos_clock(unsigned lon
>
> static void notify_cmos_timer(void)
> {
> - if (no_sync_cmos_clock)
> + if (!no_sync_cmos_clock)
> mod_timer(&sync_cmos_timer, jiffies + 1);
> }
>
>
> Yours Tony
>
> linux.conf.au http://linux.conf.au/ || http://lca2008.linux.org.au/
> Jan 28 - Feb 02 2008 The Australian Linux Technical Conference!
>
next prev parent reply other threads:[~2007-09-11 8:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-11 7:46 Fix "no_sync_cmos_clock" logic inversion in kernel/time/ntp.c Tony Breeds
2007-09-11 7:46 ` Tony Breeds
2007-09-11 7:57 ` Thomas Gleixner [this message]
2007-09-11 7:57 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1189497470.22589.3.camel@chaos \
--to=tglx@linutronix.de \
--cc=akpm@linux-foundation.org \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=tony@bakeyournoodle.com \
--cc=zach@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.