All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Walker <dwalker@mvista.com>
To: Andi Kleen <ak@suse.de>
Cc: mingo@elte.hu, Thomas Gleixner <tglx@linutronix.de>,
	linux-rt-users@vger.kernel.org
Subject: Re: [PATCH] Don't sleep in oops_begin()
Date: Mon, 17 Sep 2007 12:07:27 -0700	[thread overview]
Message-ID: <1190056047.3253.104.camel@imap.mvista.com> (raw)
In-Reply-To: <200709172100.03279.ak@suse.de>

On Mon, 2007-09-17 at 21:00 +0200, Andi Kleen wrote:
> > Since it's all got "__" in the front, not good to use this method all
> > over .. If you just need a real spinlock best to use
> > DEFINE_RAW_SPINLOCK() unless your a special situation ..
> 
> Oopsing is a special situation. Nobody knows if all the fancy infrastructure
> lurking inside the other macros still works.

In the case of spinlocks, real time just differs from the mainline
kernel by make a spinlock_t into a mutex .. We know that's not going to
work in this situation. The rest of the debugging added to spinlocks is
mostly un-changed from mainline (like lockdep is still there)..

So you should be able to use a regular mainline style spinlock_t for the
die_lock, even with all the debugging ..

The real time spinlock macros are pretty complex , but it's mostly
compile related complexity that disappears when you run the kernel.

Daniel

  reply	other threads:[~2007-09-17 19:09 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-17 18:12 [PATCH] Don't sleep in oops_begin() Andi Kleen
2007-09-17 18:28 ` Daniel Walker
2007-09-17 18:46   ` Andi Kleen
2007-09-17 18:54     ` Daniel Walker
2007-09-17 19:00       ` Andi Kleen
2007-09-17 19:07         ` Daniel Walker [this message]
2007-09-17 19:38           ` Sven-Thorsten Dietrich
2007-09-17 20:20             ` Andi Kleen
2007-09-17 20:30               ` Sven-Thorsten Dietrich
2007-09-18  0:10               ` Daniel Walker
2007-09-18  8:05                 ` Andi Kleen
2007-09-18  8:30                   ` Thomas Gleixner
2007-09-17 23:13             ` Gregory Haskins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1190056047.3253.104.camel@imap.mvista.com \
    --to=dwalker@mvista.com \
    --cc=ak@suse.de \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.