From: Andi Kleen <ak@suse.de>
To: Sven-Thorsten Dietrich <thebigcorporation@gmail.com>
Cc: Daniel Walker <dwalker@mvista.com>,
mingo@elte.hu, Thomas Gleixner <tglx@linutronix.de>,
linux-rt-users@vger.kernel.org
Subject: Re: [PATCH] Don't sleep in oops_begin()
Date: Mon, 17 Sep 2007 22:20:43 +0200 [thread overview]
Message-ID: <200709172220.43871.ak@suse.de> (raw)
In-Reply-To: <1190057923.3615.26.camel@sven.thebigcorporation.com>
On Monday 17 September 2007 21:38, Sven-Thorsten Dietrich wrote:
> On Mon, 2007-09-17 at 12:07 -0700, Daniel Walker wrote:
> > On Mon, 2007-09-17 at 21:00 +0200, Andi Kleen wrote:
> > > > Since it's all got "__" in the front, not good to use this method all
> > > > over .. If you just need a real spinlock best to use
> > > > DEFINE_RAW_SPINLOCK() unless your a special situation ..
>
> die_lock has been RAW for a while, see older patches...
It's definitely not in 2.6.23-rc4-rt1 and also wasn't in the oops
trace I looked at.
> but DEFINE_RAW or DECLARE_RAW should be used when possible.
I disagree for the oops case. You want the simplest possible code
here.
-Andi
next prev parent reply other threads:[~2007-09-17 20:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-17 18:12 [PATCH] Don't sleep in oops_begin() Andi Kleen
2007-09-17 18:28 ` Daniel Walker
2007-09-17 18:46 ` Andi Kleen
2007-09-17 18:54 ` Daniel Walker
2007-09-17 19:00 ` Andi Kleen
2007-09-17 19:07 ` Daniel Walker
2007-09-17 19:38 ` Sven-Thorsten Dietrich
2007-09-17 20:20 ` Andi Kleen [this message]
2007-09-17 20:30 ` Sven-Thorsten Dietrich
2007-09-18 0:10 ` Daniel Walker
2007-09-18 8:05 ` Andi Kleen
2007-09-18 8:30 ` Thomas Gleixner
2007-09-17 23:13 ` Gregory Haskins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200709172220.43871.ak@suse.de \
--to=ak@suse.de \
--cc=dwalker@mvista.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=thebigcorporation@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.