All of lore.kernel.org
 help / color / mirror / Atom feed
* lib-y vs EXPORT_SYMBOL: who wins?
@ 2007-09-25  5:07 Rusty Russell
  2007-09-25  6:13 ` Sam Ravnborg
  0 siblings, 1 reply; 2+ messages in thread
From: Rusty Russell @ 2007-09-25  5:07 UTC (permalink / raw)
  To: lkml - Kernel Mailing List; +Cc: Sam Ravnborg, Andrew Morton

Various files under lib/ are linked into a .a so they only get linked if
needed.  But many of these functions are also EXPORT_SYMBOL()ed.

This doesn't really make sense: if it's exported it really needs to be
present.  Certain configurations can hit this (lguest uses kasprintf,
and can be a module).

We could do something hacky and try to figure out if any modules need
the symbols, which screws modules built later, but is no worse than a
CONFIG_-based solution.

Or to we just move all the exported functions out of the .a?

Cheers,
Rusty.


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: lib-y vs EXPORT_SYMBOL: who wins?
  2007-09-25  5:07 lib-y vs EXPORT_SYMBOL: who wins? Rusty Russell
@ 2007-09-25  6:13 ` Sam Ravnborg
  0 siblings, 0 replies; 2+ messages in thread
From: Sam Ravnborg @ 2007-09-25  6:13 UTC (permalink / raw)
  To: Rusty Russell; +Cc: lkml - Kernel Mailing List, Andrew Morton

On Tue, Sep 25, 2007 at 03:07:44PM +1000, Rusty Russell wrote:
> Various files under lib/ are linked into a .a so they only get linked if
> needed.  But many of these functions are also EXPORT_SYMBOL()ed.
> 
> This doesn't really make sense: if it's exported it really needs to be
> present.  Certain configurations can hit this (lguest uses kasprintf,
> and can be a module).
> 
> We could do something hacky and try to figure out if any modules need
> the symbols, which screws modules built later, but is no worse than a
> CONFIG_-based solution.
> 
> Or to we just move all the exported functions out of the .a?


I am all for killing lib-y altogether. But do not want to sacrify
kernel bloat for this.
hch suggested a bit of Kconfig tricekery and that seems
like an OK plan to me.
But I'm not in a position to do the detective work at the moment -
feed up with oter stuff for now.

	Sam

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-09-25  6:12 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-09-25  5:07 lib-y vs EXPORT_SYMBOL: who wins? Rusty Russell
2007-09-25  6:13 ` Sam Ravnborg

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.