From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Scott Wood <scottwood@freescale.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: Problem with OF interrupt parsing code
Date: Tue, 02 Oct 2007 08:07:54 +1000 [thread overview]
Message-ID: <1191276474.6310.21.camel@pasglop> (raw)
In-Reply-To: <47016B11.3070609@freescale.com>
On Mon, 2007-10-01 at 16:48 -0500, Scott Wood wrote:
> Benjamin Herrenschmidt wrote:
> > On Mon, 2007-10-01 at 16:37 -0500, Scott Wood wrote:
> >> Scott Wood wrote:
> >> Actually, it doesn't -- it should stop when it sees the
> >> interrupt-controller property in the i8259 node, at which point it'll be
> >> trying to use the raw PCI IRQ pin number as an i8259 IRQ. This is
> >> Unlikely To Work(tm).
> >
> > It will work in the specific 8259 case I suppose since it gets the
> > legacy 1:1 mapping... but it sucks :-)
>
> The mapping between INTA-D and i8259 numbers isn't generally 1:1, and it
> looked as if it'd try using the former... though the code is
> sufficiently complicated that I could easily be missing something.
If the whole of_* thing totally fails, pci_read_irq_line should pickup
the value in the config space PCI_INTERRUPT_LINE. That will work on
things like Pegasos and possibly on this AmigaOne but it sucks.
Ben.
next prev parent reply other threads:[~2007-10-01 22:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-01 21:00 Problem with OF interrupt parsing code Gerhard Pircher
2007-10-01 21:11 ` Gerhard Pircher
2007-10-01 21:39 ` Benjamin Herrenschmidt
2007-10-01 22:33 ` Segher Boessenkool
2007-10-01 22:54 ` Benjamin Herrenschmidt
2007-10-01 22:55 ` Benjamin Herrenschmidt
2007-10-01 23:36 ` Segher Boessenkool
2007-10-02 12:38 ` Gerhard Pircher
2007-10-02 22:03 ` Benjamin Herrenschmidt
2007-10-03 7:43 ` Gerhard Pircher
2007-10-01 21:26 ` Scott Wood
2007-10-01 21:37 ` Scott Wood
2007-10-01 21:43 ` Benjamin Herrenschmidt
2007-10-01 21:48 ` Scott Wood
2007-10-01 22:07 ` Benjamin Herrenschmidt [this message]
2007-10-02 12:46 ` Gerhard Pircher
2007-10-01 21:36 ` Benjamin Herrenschmidt
-- strict thread matches above, loose matches on Subject: below --
2007-10-02 12:40 Gerhard Pircher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1191276474.6310.21.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.