From: jamal <hadi@cyberus.ca>
To: Michael Chan <mchan@broadcom.com>
Cc: Matt Carlson <mcarlson@broadcom.com>, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH][TG3]Some cleanups
Date: Tue, 02 Oct 2007 08:37:07 -0400 [thread overview]
Message-ID: <1191328627.4353.15.camel@localhost> (raw)
In-Reply-To: <1191284504.25892.129.camel@dell>
On Mon, 2007-01-10 at 17:21 -0700, Michael Chan wrote:
> Jamal, in tg3_enqueue_buggy(), we may have to call tg3_tso_bug() which
> will recursively call tg3_start_xmit_dma_bug() after segmenting the TSO
> packet into normal packets. We need to restore the VLAN tag so that the
> GSO code will create the chain of segmented SKBs with the proper VLAN
> tag.
Excellent eye Michael.
The simplest solution seems to me to modify the definition of TG3_SKB_CB
as i did for e1000 from:
(struct tg3_tx_cbdata *)&((__skb)->cb[0])
to:
(struct tg3_tx_cbdata *)&((__skb)->cb[8])
that way the vlan tags are always present and no need to recreate them.
What do you think?
cheers,
jamal
next prev parent reply other threads:[~2007-10-02 12:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-30 18:11 [PATCH][TG3]Some cleanups jamal
2007-09-30 18:12 ` jamal
2007-10-02 0:21 ` Michael Chan
2007-10-02 12:37 ` jamal [this message]
2007-10-02 23:33 ` Michael Chan
2007-10-03 13:18 ` jamal
2007-10-07 15:12 ` jamal
2007-10-08 6:32 ` David Miller
2007-10-08 13:42 ` jamal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1191328627.4353.15.camel@localhost \
--to=hadi@cyberus.ca \
--cc=mcarlson@broadcom.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.