All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Williams <dcbw@redhat.com>
To: Holger Schurig <hs4233@mail.mn-solutions.de>
Cc: linux-wireless@vger.kernel.org, libertas-dev@lists.infradead.org
Subject: Re: [PATCH] libertas: fixes for slow hardware
Date: Mon, 08 Oct 2007 09:15:16 -0400	[thread overview]
Message-ID: <1191849316.2703.26.camel@localhost.localdomain> (raw)
In-Reply-To: <200710081118.27468.hs4233@mail.mn-solutions.de>

On Mon, 2007-10-08 at 11:18 +0200, Holger Schurig wrote:
> This fixes issues where either the CF module is slow (and needs 
> more time while downloading the firmware) or where the host 
> computer is slow, so that some card interrupts arrive while
> the system was still downloading the firmware.
> 
> Signed-off-by: Vitaly V. Bursov <vitalyvb@ukr.net>
> Signed-off-by: Holger Schurig <hs4233@mail.mn-solutions.de>

@@ -405,6 +405,7 @@ static struct sk_buff *if_cs_receive_dat
        skb = dev_alloc_skb(MRVDRV_ETH_RX_PACKET_BUFFER_SIZE + 2);
        if (!skb)
                goto out;
+       skb->dev = priv->dev;
        skb_put(skb, len);
        skb_reserve(skb, 2);/* 16 byte align */
        data = skb->data;

This hunk is not necessary, the skb->dev gets set in
libertas_upload_rx_packet() when calling eth_type_trans().  If using a
kernel <= 2.6.21, setting skb->dev should be handled by
libertas_upload_rx_packet() for you later on.

Dan



  reply	other threads:[~2007-10-08 13:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-08  9:18 [PATCH] libertas: fixes for slow hardware Holger Schurig
2007-10-08 13:15 ` Dan Williams [this message]
2007-10-09  8:41   ` [PATCH, take 2] " Holger Schurig
2007-10-09 11:18     ` Dan Williams
2007-10-09 21:18     ` John W. Linville
2007-10-10  7:24       ` Holger Schurig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1191849316.2703.26.camel@localhost.localdomain \
    --to=dcbw@redhat.com \
    --cc=hs4233@mail.mn-solutions.de \
    --cc=libertas-dev@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.