From: "John W. Linville" <linville@tuxdriver.com>
To: Holger Schurig <hs4233@mail.mn-solutions.de>
Cc: linux-wireless@vger.kernel.org, Dan Williams <dcbw@redhat.com>,
libertas-dev@lists.infradead.org
Subject: Re: [PATCH, take 2] libertas: fixes for slow hardware
Date: Tue, 9 Oct 2007 17:18:22 -0400 [thread overview]
Message-ID: <20071009211822.GA3175@tuxdriver.com> (raw)
In-Reply-To: <200710091041.57159.hs4233@mail.mn-solutions.de>
On Tue, Oct 09, 2007 at 10:41:57AM +0200, Holger Schurig wrote:
> @@ -148,11 +148,11 @@ static int if_cs_poll_while_fw_download(
> {
> int i;
>
> - for (i = 0; i < 500; i++) {
> + for (i = 0; i < 1000; i++) {
> u8 val = if_cs_read8(card, addr);
> if (val == reg)
> return i;
> - udelay(100);
> + udelay(500);
> }
> return -ETIME;
> }
10x the maximum delay? Is this really necessary? How did you
determine this was needed?
If it really is necessary, you need to change the "The host polls
the Card Status register for 50 ms..." comment in if_cs_prog_helper
as well.
John
--
John W. Linville
linville@tuxdriver.com
next prev parent reply other threads:[~2007-10-09 21:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-08 9:18 [PATCH] libertas: fixes for slow hardware Holger Schurig
2007-10-08 13:15 ` Dan Williams
2007-10-09 8:41 ` [PATCH, take 2] " Holger Schurig
2007-10-09 11:18 ` Dan Williams
2007-10-09 21:18 ` John W. Linville [this message]
2007-10-10 7:24 ` Holger Schurig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071009211822.GA3175@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=dcbw@redhat.com \
--cc=hs4233@mail.mn-solutions.de \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.