From: Thomas Sailer <t.sailer@alumni.ethz.ch>
To: Xavier Bestel <xavier.bestel@free.fr>
Cc: Bernd Petrovitsch <bernd@firmix.at>,
"Grosjo.net - jom" <jom@grosjo.net>,
linux-kernel@vger.kernel.org
Subject: Re: Patch for WindowsMobile5 on Linux Kernel
Date: Tue, 09 Oct 2007 13:25:03 +0200 [thread overview]
Message-ID: <1191929103.10858.59.camel@xbox360> (raw)
In-Reply-To: <1191922629.10146.28.camel@frg-rhel40-em64t-04>
On Tue, 2007-10-09 at 11:37 +0200, Xavier Bestel wrote:
> FWIW, the patch in question is a one-liner:
That's not a valid argument. This may work with a WM5 device, but looks
very dubious, wrt. other RNDIS devices. Why are these constants
hardcoded and not taken in some way from the descriptors?
There must be some justification why these values need to be hardcoded,
and if so, this must be dependent on the rndis device really being a WM5
device.
Nacked-By: Thomas Sailer <t.sailer@alumni.ethz.ch>
next prev parent reply other threads:[~2007-10-09 11:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-09 9:20 Patch for WindowsMobile5 on Linux Kernel Grosjo.net - jom
2007-10-09 9:32 ` Bernd Petrovitsch
2007-10-09 9:37 ` Xavier Bestel
2007-10-09 9:46 ` Grosjo.net - jom
2007-10-09 11:25 ` Thomas Sailer [this message]
2007-10-09 9:34 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1191929103.10858.59.camel@xbox360 \
--to=t.sailer@alumni.ethz.ch \
--cc=bernd@firmix.at \
--cc=jom@grosjo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=xavier.bestel@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.