* Patch for WindowsMobile5 on Linux Kernel
@ 2007-10-09 9:20 Grosjo.net - jom
2007-10-09 9:32 ` Bernd Petrovitsch
2007-10-09 9:34 ` Pekka Enberg
0 siblings, 2 replies; 6+ messages in thread
From: Grosjo.net - jom @ 2007-10-09 9:20 UTC (permalink / raw)
To: linux-kernel
Dear all,
Would it be possible to include the patches (available on www.synce.org)
for WindowsMobile5, as most mobile phones are under Window$, and it is
very convenient to connect it to the laptop under Linux
http://www.synce.org/index.php/Connecting_your_Windows_Mobile_2005_device_via_USB_%28usb-rndis-lite%29
Thanks a lot in advance,
Jom
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Patch for WindowsMobile5 on Linux Kernel
2007-10-09 9:20 Patch for WindowsMobile5 on Linux Kernel Grosjo.net - jom
@ 2007-10-09 9:32 ` Bernd Petrovitsch
2007-10-09 9:37 ` Xavier Bestel
2007-10-09 9:34 ` Pekka Enberg
1 sibling, 1 reply; 6+ messages in thread
From: Bernd Petrovitsch @ 2007-10-09 9:32 UTC (permalink / raw)
To: Grosjo.net - jom; +Cc: linux-kernel
On Die, 2007-10-09 at 12:20 +0300, Grosjo.net - jom wrote:
[...]
> Would it be possible to include the patches (available on www.synce.org)
> for WindowsMobile5, as most mobile phones are under Window$, and it is
> very convenient to connect it to the laptop under Linux
do {
Test them
review them
sent them as patches hereover
handle feedback
until(accepted)
Bernd
--
Firmix Software GmbH http://www.firmix.at/
mobil: +43 664 4416156 fax: +43 1 7890849-55
Embedded Linux Development and Services
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Patch for WindowsMobile5 on Linux Kernel
2007-10-09 9:20 Patch for WindowsMobile5 on Linux Kernel Grosjo.net - jom
2007-10-09 9:32 ` Bernd Petrovitsch
@ 2007-10-09 9:34 ` Pekka Enberg
1 sibling, 0 replies; 6+ messages in thread
From: Pekka Enberg @ 2007-10-09 9:34 UTC (permalink / raw)
To: Grosjo.net - jom; +Cc: linux-kernel
Hi,
On 10/9/07, Grosjo.net - jom <jom@grosjo.net> wrote:
> Would it be possible to include the patches (available on www.synce.org)
> for WindowsMobile5, as most mobile phones are under Window$, and it is
> very convenient to connect it to the laptop under Linux
Sounds useful so please ask the synce developers to submit those
patches upstream.
Pekka
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Patch for WindowsMobile5 on Linux Kernel
2007-10-09 9:32 ` Bernd Petrovitsch
@ 2007-10-09 9:37 ` Xavier Bestel
2007-10-09 9:46 ` Grosjo.net - jom
2007-10-09 11:25 ` Thomas Sailer
0 siblings, 2 replies; 6+ messages in thread
From: Xavier Bestel @ 2007-10-09 9:37 UTC (permalink / raw)
To: Bernd Petrovitsch; +Cc: Grosjo.net - jom, linux-kernel
On Tue, 2007-10-09 at 11:32 +0200, Bernd Petrovitsch wrote:
> On Die, 2007-10-09 at 12:20 +0300, Grosjo.net - jom wrote:
> [...]
> > Would it be possible to include the patches (available on www.synce.org)
> > for WindowsMobile5, as most mobile phones are under Window$, and it is
> > very convenient to connect it to the laptop under Linux
>
> do {
> Test them
> review them
> sent them as patches hereover
> handle feedback
> until(accepted)
FWIW, the patch in question is a one-liner:
--- linux-2.6.22-rc3-orig/drivers/net/usb/rndis_host.c 2007-05-25 22:55:14.000000000 -0400
+++ linux-2.6.22-rc3/drivers/net/usb/rndis_host.c 2007-05-27 17:06:16.000000000 -0400
@@ -499,8 +499,7 @@
net->hard_header_len += sizeof (struct rndis_data_hdr);
dev->hard_mtu = net->mtu + net->hard_header_len;
- dev->rx_urb_size = dev->hard_mtu + (dev->maxpacket + 1);
- dev->rx_urb_size &= ~(dev->maxpacket - 1);
+ dev->rx_urb_size = (dev->udev->speed == USB_SPEED_FULL) ? 16384 : 8192;
u.init->max_transfer_size = cpu_to_le32(dev->rx_urb_size);
net->change_mtu = NULL;
Xav
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Patch for WindowsMobile5 on Linux Kernel
2007-10-09 9:37 ` Xavier Bestel
@ 2007-10-09 9:46 ` Grosjo.net - jom
2007-10-09 11:25 ` Thomas Sailer
1 sibling, 0 replies; 6+ messages in thread
From: Grosjo.net - jom @ 2007-10-09 9:46 UTC (permalink / raw)
To: Xavier Bestel; +Cc: Bernd Petrovitsch, linux-kernel
> FWIW, the patch in question is a one-liner:
>
Yes, that is why it shall be probably possible to include it in the kernel ?
I do not have the contact with SynCE developers. Maybe one of you have.
Jom
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Patch for WindowsMobile5 on Linux Kernel
2007-10-09 9:37 ` Xavier Bestel
2007-10-09 9:46 ` Grosjo.net - jom
@ 2007-10-09 11:25 ` Thomas Sailer
1 sibling, 0 replies; 6+ messages in thread
From: Thomas Sailer @ 2007-10-09 11:25 UTC (permalink / raw)
To: Xavier Bestel; +Cc: Bernd Petrovitsch, Grosjo.net - jom, linux-kernel
On Tue, 2007-10-09 at 11:37 +0200, Xavier Bestel wrote:
> FWIW, the patch in question is a one-liner:
That's not a valid argument. This may work with a WM5 device, but looks
very dubious, wrt. other RNDIS devices. Why are these constants
hardcoded and not taken in some way from the descriptors?
There must be some justification why these values need to be hardcoded,
and if so, this must be dependent on the rndis device really being a WM5
device.
Nacked-By: Thomas Sailer <t.sailer@alumni.ethz.ch>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2007-10-09 11:25 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-09 9:20 Patch for WindowsMobile5 on Linux Kernel Grosjo.net - jom
2007-10-09 9:32 ` Bernd Petrovitsch
2007-10-09 9:37 ` Xavier Bestel
2007-10-09 9:46 ` Grosjo.net - jom
2007-10-09 11:25 ` Thomas Sailer
2007-10-09 9:34 ` Pekka Enberg
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.