All of lore.kernel.org
 help / color / mirror / Atom feed
From: Len Brown <lenb@kernel.org>
To: linux-acpi@vger.kernel.org
Cc: Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
	Len Brown <len.brown@intel.com>
Subject: [PATCH 12/37] ACPI: thinkpad-acpi: add mutex-based locking to input device event send path
Date: Wed, 10 Oct 2007 01:06:19 -0400	[thread overview]
Message-ID: <1191992804-14965-13-git-send-email-lenb@kernel.org> (raw)
Message-ID: <8523ed6fb2ca04973fe759fda8ab4af72492fc7e.1191992584.git.len.brown@intel.com> (raw)
In-Reply-To: <1191992804-14965-1-git-send-email-lenb@kernel.org>
In-Reply-To: <fd1caaed466de2ee100e250b6c755376eda7ba3b.1191992584.git.len.brown@intel.com>

From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>

Protect the input device event sending path with a mutex, since hot key
input events are not atomic and require an cohesive event block to be sent
together.

Signed-off-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Signed-off-by: Len Brown <len.brown@intel.com>
---
 drivers/misc/thinkpad_acpi.c |   10 ++++++++++
 1 files changed, 10 insertions(+), 0 deletions(-)

diff --git a/drivers/misc/thinkpad_acpi.c b/drivers/misc/thinkpad_acpi.c
index 8aa0f96..0ced9d6 100644
--- a/drivers/misc/thinkpad_acpi.c
+++ b/drivers/misc/thinkpad_acpi.c
@@ -519,6 +519,7 @@ static char *next_cmd(char **cmds)
 static struct platform_device *tpacpi_pdev;
 static struct class_device *tpacpi_hwmon;
 static struct input_dev *tpacpi_inputdev;
+static struct mutex tpacpi_inputdev_send_mutex;
 
 
 static int tpacpi_resume_handler(struct platform_device *pdev)
@@ -1131,6 +1132,8 @@ static void tpacpi_input_send_key(unsigned int scancode,
 				  unsigned int keycode)
 {
 	if (keycode != KEY_RESERVED) {
+		mutex_lock(&tpacpi_inputdev_send_mutex);
+
 		input_report_key(tpacpi_inputdev, keycode, 1);
 		if (keycode == KEY_UNKNOWN)
 			input_event(tpacpi_inputdev, EV_MSC, MSC_SCAN,
@@ -1142,6 +1145,8 @@ static void tpacpi_input_send_key(unsigned int scancode,
 			input_event(tpacpi_inputdev, EV_MSC, MSC_SCAN,
 				    scancode);
 		input_sync(tpacpi_inputdev);
+
+		mutex_unlock(&tpacpi_inputdev_send_mutex);
 	}
 }
 
@@ -1149,11 +1154,15 @@ static void tpacpi_input_send_radiosw(void)
 {
 	int wlsw;
 
+	mutex_lock(&tpacpi_inputdev_send_mutex);
+
 	if (tp_features.hotkey_wlsw && !hotkey_get_wlsw(&wlsw)) {
 		input_report_switch(tpacpi_inputdev,
 				    SW_RADIO, !!wlsw);
 		input_sync(tpacpi_inputdev);
 	}
+
+	mutex_unlock(&tpacpi_inputdev_send_mutex);
 }
 
 static void hotkey_notify(struct ibm_struct *ibm, u32 event)
@@ -4737,6 +4746,7 @@ static int __init thinkpad_acpi_module_init(void)
 		thinkpad_acpi_module_exit();
 		return ret;
 	}
+	mutex_init(&tpacpi_inputdev_send_mutex);
 	tpacpi_inputdev = input_allocate_device();
 	if (!tpacpi_inputdev) {
 		printk(IBM_ERR "unable to allocate input device\n");
-- 
1.5.3.4.206.g58ba4

  parent reply	other threads:[~2007-10-10  5:06 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-10  5:06 ACPI patch candidates for 2.6.24 merge window Len Brown
2007-10-10  5:06 ` [PATCH 01/37] sony-laptop: old Vaio models contain 2 IO port entries Len Brown
2007-10-10  5:06   ` Len Brown
2007-10-10  5:06   ` [PATCH 02/37] fujitsu-laptop: create Fujitsu laptop platform specific driver Len Brown
2007-10-10  5:06     ` Len Brown
2007-10-10  5:06   ` [PATCH 03/37] ACPI: thermal: use round_jiffies when thermal zone polling is enabled Len Brown
2007-10-10  5:06     ` Len Brown
2007-10-10  5:06   ` [PATCH 04/37] ACPI: Thermal: Drop concurrent thermal checks Len Brown
2007-10-10  5:06     ` Len Brown
2007-10-10  5:06   ` [PATCH 05/37] ACPI: video: Don't call absent methods Len Brown
2007-10-10  5:06     ` Len Brown
2007-10-10  5:06   ` [PATCH 06/37] ACPI: VIDEO: Adjust current level to closest available one Len Brown
2007-10-10  5:06     ` Len Brown
2007-10-10  5:06   ` [PATCH 07/37] ACPI: EC: Drop ECDT-based boot_ec as soon as we find DSDT-based one Len Brown
2007-10-10  5:06     ` Len Brown
2007-10-10  5:06   ` [PATCH 08/37] sony-laptop/thinkpad-acpi: fix INPUT=n build Len Brown
2007-10-10  5:06     ` Len Brown
2007-10-10  5:06   ` [PATCH 09/37] acpi_video: kernel build error if !INPUT Len Brown
2007-10-10  5:06     ` Len Brown
2007-10-10  5:06   ` [PATCH 10/37] ACPI: thinkpad-acpi: make room for more features in tp_features bitfield Len Brown
2007-10-10  5:06     ` Len Brown
2007-10-10  5:06   ` [PATCH 11/37] ACPI: thinkpad-acpi: issue EV_SYNC after EV_SWITCH Len Brown
2007-10-10  5:06     ` Len Brown
2007-10-10  5:06   ` Len Brown [this message]
2007-10-10  5:06     ` [PATCH 12/37] ACPI: thinkpad-acpi: add mutex-based locking to input device event send path Len Brown
2007-10-10  5:06   ` [PATCH 13/37] ACPI: thinkpad-acpi: keep track of module state Len Brown
2007-10-10  5:06     ` Len Brown
2007-10-10  5:06   ` [PATCH 14/37] ACPI: thinkpad-acpi: check version of hot key firmware Len Brown
2007-10-10  5:06     ` Len Brown
2007-10-10  5:06   ` [PATCH 15/37] ACPI: thinkpad-acpi: dequeue all pending hot key events at once (v2.2) Len Brown
2007-10-10  5:06     ` Len Brown
2007-10-10  5:06   ` [PATCH 16/37] ACPI: thinkpad-acpi: fix regression on HKEY LID event handling Len Brown
2007-10-10  5:06     ` Len Brown
2007-10-10  5:06   ` [PATCH 17/37] ACPI: thinkpad-acpi: use a separate platform device for hwmon and name it (v2) Len Brown
2007-10-10  5:06     ` Len Brown
2007-10-10  5:06   ` [PATCH 18/37] ACPI: thinkpad-acpi: duplicate driver attributes to new hwmon pdrv Len Brown
2007-10-10  5:06     ` Len Brown
2007-10-10  5:06   ` [PATCH 19/37] ACPI: Hibernate erroneously disabled Suspend wakeup devices Len Brown
2007-10-10  5:06     ` Len Brown
2007-10-11 10:12       ` Rafael J. Wysocki
2007-10-10  5:06   ` [PATCH 20/37] ACPI: Battery: don't use acpi_extract_package() Len Brown
2007-10-10  5:06     ` Len Brown
2007-10-10  5:06   ` [PATCH 21/37] ACPI: Battery: simplify update scheme Len Brown
2007-10-10  5:06     ` Len Brown
2007-10-10  5:06   ` [PATCH 22/37] ACPI: Battery: Misc clean-ups, no functional changes Len Brown
2007-10-10  5:06     ` Len Brown
2007-10-10  5:06   ` [PATCH 23/37] ACPI: Battery: Add sysfs support Len Brown
2007-10-10  5:06     ` Len Brown
2007-10-10  5:06   ` [PATCH 24/37] ACPI: Battery: add sysfs alarm Len Brown
2007-10-10  5:06     ` Len Brown
2007-10-10  5:06   ` [PATCH 25/37] ACPI: Add acpi_bus_generate_event4() function Len Brown
2007-10-10  5:06     ` Len Brown
2007-10-10  5:06   ` [PATCH 26/37] ACPI: EC: Add new query handler to list head Len Brown
2007-10-10  5:06     ` Len Brown
2007-10-10  5:06   ` [PATCH 27/37] ACPI: SBS: Split host controller (ACPI0001) from SBS driver (ACPI0002) Len Brown
2007-10-10  5:06     ` Len Brown
2007-10-10  5:06   ` [PATCH 28/37] ACPI: SBS: Simplify data structures in SBS Len Brown
2007-10-10  5:06     ` Len Brown
2007-10-10  5:06   ` [PATCH 29/37] ACPI: SBS: Make SBS reads table-driven Len Brown
2007-10-10  5:06     ` Len Brown
2007-10-10  5:06   ` [PATCH 30/37] ACPI: SBS: Add support for power_supply class (and sysfs) Len Brown
2007-10-10  5:06     ` Len Brown
2007-10-10  5:06   ` [PATCH 31/37] ACPI: SBS: Add ACPI_PROCFS around procfs handling code Len Brown
2007-10-10  5:06     ` Len Brown
2007-10-10  5:06   ` [PATCH 32/37] ACPI: SBS: Add sysfs alarm Len Brown
2007-10-10  5:06     ` Len Brown
2007-10-10  5:06   ` [PATCH 33/37] ACPI: AC: Add sysfs interface Len Brown
2007-10-10  5:06     ` Len Brown
2007-10-10  5:06   ` [PATCH 34/37] ACPI: thinkpad-acpi: skip blanks before the data when parsing sysfs Len Brown
2007-10-10  5:06     ` Len Brown
2007-10-10  5:06   ` [PATCH 35/37] ACPI: suppress uninitialized var warning Len Brown
2007-10-10  5:06     ` Len Brown
2007-10-10  5:06   ` [PATCH 36/37] Hibernation: Make sure that ACPI is enabled in acpi_hibernation_finish Len Brown
2007-10-10  5:06     ` Len Brown
2007-10-10  5:06   ` [PATCH 37/37] ACPI: clean up acpi_enter_sleep_state_prep Len Brown
2007-10-10  5:06     ` Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1191992804-14965-13-git-send-email-lenb@kernel.org \
    --to=lenb@kernel.org \
    --cc=hmh@hmh.eng.br \
    --cc=len.brown@intel.com \
    --cc=linux-acpi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.