From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Jeff Garzik <jeff@garzik.org>
Cc: linuxppc-dev list <linuxppc-dev@ozlabs.org>,
netdev@vger.kernel.org, Roland Dreier <rdreier@cisco.com>,
"David S. Miller" <davem@davemloft.net>,
shemminger@linux.foundation.org
Subject: Re: [PATCH] net: Fix new EMAC driver for NAPI changes
Date: Wed, 17 Oct 2007 11:46:54 +1000 [thread overview]
Message-ID: <1192585614.11899.108.camel@pasglop> (raw)
In-Reply-To: <47156258.5010800@garzik.org>
On Tue, 2007-10-16 at 21:16 -0400, Jeff Garzik wrote:
> Benjamin Herrenschmidt wrote:
> > net: Fix new EMAC driver for NAPI changes
> >
> > This fixes the new EMAC driver for the NAPI updates. The previous patch
> > by Roland Dreier (already applied) to do that doesn't actually work. This
> > applies on top of it makes it work on my test Ebony machine.
> >
> > This patch depends on "net: Add __napi_sycnhronize() to sync with napi poll"
> > posted previously.
> >
> > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> > ---
> >
> > The old EMAC driver does things a bit differently (doesn't do useful
> > locking :-) and seems to work with Roland patch. So I'm not going to
> > touch it unless somebody reports me that it has problems
>
> applied
Beware that the depend patch for __napi_synchronize() is still being
discussed :-)
Cheers,
Ben.
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Jeff Garzik <jeff@garzik.org>
Cc: shemminger@linux.foundation.org, netdev@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Roland Dreier <rdreier@cisco.com>,
linuxppc-dev list <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH] net: Fix new EMAC driver for NAPI changes
Date: Wed, 17 Oct 2007 11:46:54 +1000 [thread overview]
Message-ID: <1192585614.11899.108.camel@pasglop> (raw)
In-Reply-To: <47156258.5010800@garzik.org>
On Tue, 2007-10-16 at 21:16 -0400, Jeff Garzik wrote:
> Benjamin Herrenschmidt wrote:
> > net: Fix new EMAC driver for NAPI changes
> >
> > This fixes the new EMAC driver for the NAPI updates. The previous patch
> > by Roland Dreier (already applied) to do that doesn't actually work. This
> > applies on top of it makes it work on my test Ebony machine.
> >
> > This patch depends on "net: Add __napi_sycnhronize() to sync with napi poll"
> > posted previously.
> >
> > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> > ---
> >
> > The old EMAC driver does things a bit differently (doesn't do useful
> > locking :-) and seems to work with Roland patch. So I'm not going to
> > touch it unless somebody reports me that it has problems
>
> applied
Beware that the depend patch for __napi_synchronize() is still being
discussed :-)
Cheers,
Ben.
next prev parent reply other threads:[~2007-10-17 1:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-16 5:40 [PATCH] net: Fix new EMAC driver for NAPI changes Benjamin Herrenschmidt
2007-10-16 5:40 ` Benjamin Herrenschmidt
2007-10-17 1:16 ` Jeff Garzik
2007-10-17 1:16 ` Jeff Garzik
2007-10-17 1:46 ` Benjamin Herrenschmidt [this message]
2007-10-17 1:46 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1192585614.11899.108.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=jeff@garzik.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=rdreier@cisco.com \
--cc=shemminger@linux.foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.